From: Daniel Jacobowitz <drow@false.org>
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: gdb-patches@sourceware.org, David Ung <davidu@mips.com>,
"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: mips-tdep.c: Sign-extend pointers for n32
Date: Sun, 16 Dec 2007 18:49:00 -0000 [thread overview]
Message-ID: <20071216184625.GA22905@caradoc.them.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0710251443260.22756@perivale.mips.com>
On Thu, Oct 25, 2007 at 03:10:20PM +0100, Maciej W. Rozycki wrote:
> 2007-10-25 David Ung <davidu@mips.com>
>
> * mips-tdep.c (mips_n32n64_push_dummy_call): Sign-extend the
> pointer value if the length of the variable is less than the
> width of the register size of the ABI.
>
> OK to apply?
Why just pointers? I'm not entirely sure what's going on above in the
float case, but in the integer case this seems clearly wrong. Zero
extension is probably "right" for trailing bits of structures but what
about negative integers?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-12-16 18:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 14:43 Maciej W. Rozycki
2007-12-16 18:49 ` Daniel Jacobowitz [this message]
2007-12-19 15:27 ` Maciej W. Rozycki
2007-12-19 15:28 ` Daniel Jacobowitz
2007-12-19 16:16 ` Maciej W. Rozycki
2007-12-19 17:08 ` Daniel Jacobowitz
2007-12-20 16:41 ` Maciej W. Rozycki
2007-12-20 17:07 ` Daniel Jacobowitz
2007-12-20 17:18 ` Maciej W. Rozycki
2007-12-20 19:37 ` Daniel Jacobowitz
2007-12-21 4:36 ` Joel Brobecker
2007-12-21 11:34 ` Maciej W. Rozycki
2007-12-21 11:51 ` Joel Brobecker
2007-12-21 12:02 ` Maciej W. Rozycki
2007-12-22 5:30 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071216184625.GA22905@caradoc.them.org \
--to=drow@false.org \
--cc=davidu@mips.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@linux-mips.org \
--cc=macro@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox