From: "Maciej W. Rozycki" <macro@mips.com>
To: gdb-patches@sourceware.org
Cc: David Ung <davidu@mips.com>, "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: mips-tdep.c: Sign-extend pointers for n32
Date: Thu, 25 Oct 2007 14:43:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.61.0710251443260.22756@perivale.mips.com> (raw)
Hello,
The change below fixes a few regressions in the GDB test suite for
MIPS/n32 like the one below:
print (diamond.*left_base_vpmf) ()
UNPREDICTABLE: PC = 0x80020580
Quit
(gdb) FAIL: gdb.cp/member-ptr.exp: print (diamond.*left_base_vpmf) ()
Tested for n32 using the mipsisa32-sde-elf target, with the
mips-sim-sde64/-mips64/-EB and mips-sim-sde64/-mips64/-EL boards, fixing 6
regressions (of 78) for the former and 3 regressions (of 74) for the
latter.
2007-10-25 David Ung <davidu@mips.com>
* mips-tdep.c (mips_n32n64_push_dummy_call): Sign-extend the
pointer value if the length of the variable is less than the
width of the register size of the ABI.
OK to apply?
Maciej
12741-0.diff
Index: binutils-quilt/src/gdb/mips-tdep.c
===================================================================
--- binutils-quilt.orig/src/gdb/mips-tdep.c 2007-09-21 17:19:38.000000000 +0100
+++ binutils-quilt/src/gdb/mips-tdep.c 2007-09-21 17:19:38.000000000 +0100
@@ -3032,6 +3032,10 @@
|| typecode == TYPE_CODE_UNION))
regval <<= ((MIPS64_REGSIZE - partial_len)
* TARGET_CHAR_BIT);
+ /* Sign extend the value if it is an address. */
+ else if (partial_len < MIPS64_REGSIZE
+ && typecode == TYPE_CODE_PTR)
+ regval = extract_signed_integer (val, partial_len);
if (mips_debug)
fprintf_filtered (gdb_stdlog, " - reg=%d val=%s",
next reply other threads:[~2007-10-25 14:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-25 14:43 Maciej W. Rozycki [this message]
2007-12-16 18:49 ` Daniel Jacobowitz
2007-12-19 15:27 ` Maciej W. Rozycki
2007-12-19 15:28 ` Daniel Jacobowitz
2007-12-19 16:16 ` Maciej W. Rozycki
2007-12-19 17:08 ` Daniel Jacobowitz
2007-12-20 16:41 ` Maciej W. Rozycki
2007-12-20 17:07 ` Daniel Jacobowitz
2007-12-20 17:18 ` Maciej W. Rozycki
2007-12-20 19:37 ` Daniel Jacobowitz
2007-12-21 4:36 ` Joel Brobecker
2007-12-21 11:34 ` Maciej W. Rozycki
2007-12-21 11:51 ` Joel Brobecker
2007-12-21 12:02 ` Maciej W. Rozycki
2007-12-22 5:30 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0710251443260.22756@perivale.mips.com \
--to=macro@mips.com \
--cc=davidu@mips.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox