Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@mips.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sourceware.org, David Ung <davidu@mips.com>,
	     "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: mips-tdep.c: Sign-extend pointers for n32
Date: Thu, 20 Dec 2007 17:18:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.61.0712201700380.16321@perivale.mips.com> (raw)
In-Reply-To: <20071220165805.GB17663@caradoc.them.org>

On Thu, 20 Dec 2007, Daniel Jacobowitz wrote:

> I think there's still a problem here, though it is somewhat endemic to
> the argument passing routines:
> 
>     TYPE_CODE_ENUM,             /* Enumeration type */
>     TYPE_CODE_REF,              /* C++ Reference types */
>     TYPE_CODE_CHAR,             /* *real* character type */
>     TYPE_CODE_BOOL,
> 
> And possibly TYPE_CODE_MEMBERPTR too... that's a signed offset,
> probably 32-bit in the n32 case.  Getting this right is a real
> pain.

 Hmm, these are obviously C-style types and I would expect other languages 
to have their own specific ones (Ada, anyone?).  As they map somehow to 
the integer types provided by the underlying architecture, wouldn't it be 
a good idea to actually record which of the plain CPU-specific types each 
of the language types corresponds to?

 This way the mapping would only be provided in a single place -- the 
language ABI for a given architecture -- and all the generic 
target-dependent and possibly target-independent code would not have to 
iterate over all the language types, which is obviously prone to errors 
and hard to fully cover in the test suite.

  Maciej


  reply	other threads:[~2007-12-20 17:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-25 14:43 Maciej W. Rozycki
2007-12-16 18:49 ` Daniel Jacobowitz
2007-12-19 15:27   ` Maciej W. Rozycki
2007-12-19 15:28     ` Daniel Jacobowitz
2007-12-19 16:16       ` Maciej W. Rozycki
2007-12-19 17:08         ` Daniel Jacobowitz
2007-12-20 16:41           ` Maciej W. Rozycki
2007-12-20 17:07             ` Daniel Jacobowitz
2007-12-20 17:18               ` Maciej W. Rozycki [this message]
2007-12-20 19:37                 ` Daniel Jacobowitz
2007-12-21  4:36                 ` Joel Brobecker
2007-12-21 11:34                   ` Maciej W. Rozycki
2007-12-21 11:51                     ` Joel Brobecker
2007-12-21 12:02                       ` Maciej W. Rozycki
2007-12-22  5:30                         ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0712201700380.16321@perivale.mips.com \
    --to=macro@mips.com \
    --cc=davidu@mips.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=macro@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox