From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21662 invoked by alias); 16 Dec 2007 18:46:38 -0000 Received: (qmail 21652 invoked by uid 22791); 16 Dec 2007 18:46:37 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 16 Dec 2007 18:46:28 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 74CD298129; Sun, 16 Dec 2007 18:46:27 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 33AE29811F; Sun, 16 Dec 2007 18:46:27 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1J3yVN-0006yA-Vc; Sun, 16 Dec 2007 13:46:26 -0500 Date: Sun, 16 Dec 2007 18:49:00 -0000 From: Daniel Jacobowitz To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, David Ung , "Maciej W. Rozycki" Subject: Re: mips-tdep.c: Sign-extend pointers for n32 Message-ID: <20071216184625.GA22905@caradoc.them.org> Mail-Followup-To: "Maciej W. Rozycki" , gdb-patches@sourceware.org, David Ung , "Maciej W. Rozycki" References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00211.txt.bz2 On Thu, Oct 25, 2007 at 03:10:20PM +0100, Maciej W. Rozycki wrote: > 2007-10-25 David Ung > > * mips-tdep.c (mips_n32n64_push_dummy_call): Sign-extend the > pointer value if the length of the variable is less than the > width of the register size of the ABI. > > OK to apply? Why just pointers? I'm not entirely sure what's going on above in the float case, but in the integer case this seems clearly wrong. Zero extension is probably "right" for trailing bits of structures but what about negative integers? -- Daniel Jacobowitz CodeSourcery