[commit/branch?] error in return type in solib-target:solib_target_parse_libraries

[commit/branch?] error in return type in solib-target:solib_target_parse_libraries

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

Hello,

When HAVE_LIBEXPAT is not defined, the instance of
solib_target_parse_libraries has a return type that looks incorrect.
Looking at the other instance used when HAVE_LIBEXPAT is defined,
and looking at its usage, it looks like a '*' was just forgotten.
The attached patch allows GDB to build again.

2007-10-12  Joel Brobecker  <brobecker@adacore.com>

        * solib-target.c (solib_target_parse_libraries)
        [HAVEHAVE_LIBEXPAT not defined]: Fix thinko in return type.

I think I should also commit this on the branch. It looks pretty
obvious and fixes a build failure, even if the current number of
targets that use this file is very small (2 AFAICT).

Thanks,
-- 
Joel

[-- Attachment #2: solib-target.c.diff --]
[-- Type: text/plain, Size: 363 bytes --]

Index: solib-target.c
===================================================================
--- solib-target.c	(revision 15032)
+++ solib-target.c	(working copy)
@@ -51,7 +51,7 @@ DEF_VEC_P(lm_info_p);
 
 #if !defined(HAVE_LIBEXPAT)
 
-static VEC(lm_info_p)
+static VEC(lm_info_p) *
 solib_target_parse_libraries (const char *library)
 {
   static int have_warned;

Re: [commit/branch?] error in return type in solib-target:solib_target_parse_libraries

[Daniel Jacobowitz]

On Fri, Oct 12, 2007 at 02:55:33PM -0700, Joel Brobecker wrote:
> 2007-10-12  Joel Brobecker  <brobecker@adacore.com>
> 
>         * solib-target.c (solib_target_parse_libraries)
>         [HAVEHAVE_LIBEXPAT not defined]: Fix thinko in return type.
> 
> I think I should also commit this on the branch.

Yes please.  It looks like we'll need a 6.7.1 sooner rather than
later; I really screwed up this libintl PR.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [commit/branch?] error in return type in solib-target:solib_target_parse_libraries

[Joel Brobecker]

> > 2007-10-12  Joel Brobecker  <brobecker@adacore.com>
> > 
> >         * solib-target.c (solib_target_parse_libraries)
> >         [HAVEHAVE_LIBEXPAT not defined]: Fix thinko in return type.
> > 
> > I think I should also commit this on the branch.
> 
> Yes please.

Thanks. Now checked in.

> It looks like we'll need a 6.7.1 sooner rather than later; I really
> screwed up this libintl PR.

Which libintl PR? I'm doing zillions of things at the same time
these days, so I'm wondering what I missed (or forgot!)...

In terms of 6.7.1, I'm ready anytime.

-- 
Joel

Re: [commit/branch?] error in return type in solib-target:solib_target_parse_libraries

[Daniel Jacobowitz]

On Fri, Oct 12, 2007 at 11:03:08PM -0700, Joel Brobecker wrote:
> Which libintl PR? I'm doing zillions of things at the same time
> these days, so I'm wondering what I missed (or forgot!)...

gdb/2336.  I got the ELF support check wrong :-(

-- 
Daniel Jacobowitz
CodeSourcery

Re: [commit/branch?] error in return type in solib-target:solib_target_parse_libraries

[Joel Brobecker]

> gdb/2336.  I got the ELF support check wrong :-(

Oops! :-). I guess we all missed it... As soon as the fix is confirmed,
we can produce a 6.7.1.

-- 
Joel