From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32373 invoked by alias); 12 Oct 2007 21:56:35 -0000 Received: (qmail 32364 invoked by uid 22791); 12 Oct 2007 21:56:34 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 12 Oct 2007 21:56:32 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 539972ACBDF for ; Fri, 12 Oct 2007 17:55:35 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id BIE1u4vZO8HU for ; Fri, 12 Oct 2007 17:55:35 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 164402ACBDA for ; Fri, 12 Oct 2007 17:55:35 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 17D8BE7B58; Fri, 12 Oct 2007 14:55:33 -0700 (PDT) Date: Fri, 12 Oct 2007 22:07:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [commit/branch?] error in return type in solib-target:solib_target_parse_libraries Message-ID: <20071012215533.GB4038@adacore.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="BOKacYhQ+x31HxR3" Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00344.txt.bz2 --BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 686 Hello, When HAVE_LIBEXPAT is not defined, the instance of solib_target_parse_libraries has a return type that looks incorrect. Looking at the other instance used when HAVE_LIBEXPAT is defined, and looking at its usage, it looks like a '*' was just forgotten. The attached patch allows GDB to build again. 2007-10-12 Joel Brobecker * solib-target.c (solib_target_parse_libraries) [HAVEHAVE_LIBEXPAT not defined]: Fix thinko in return type. I think I should also commit this on the branch. It looks pretty obvious and fixes a build failure, even if the current number of targets that use this file is very small (2 AFAICT). Thanks, -- Joel --BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="solib-target.c.diff" Content-length: 363 Index: solib-target.c =================================================================== --- solib-target.c (revision 15032) +++ solib-target.c (working copy) @@ -51,7 +51,7 @@ DEF_VEC_P(lm_info_p); #if !defined(HAVE_LIBEXPAT) -static VEC(lm_info_p) +static VEC(lm_info_p) * solib_target_parse_libraries (const char *library) { static int have_warned; --BOKacYhQ+x31HxR3--