Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: [commit/branch?] error in return type in solib-target:solib_target_parse_libraries
Date: Fri, 12 Oct 2007 22:07:00 -0000	[thread overview]
Message-ID: <20071012215533.GB4038@adacore.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

Hello,

When HAVE_LIBEXPAT is not defined, the instance of
solib_target_parse_libraries has a return type that looks incorrect.
Looking at the other instance used when HAVE_LIBEXPAT is defined,
and looking at its usage, it looks like a '*' was just forgotten.
The attached patch allows GDB to build again.

2007-10-12  Joel Brobecker  <brobecker@adacore.com>

        * solib-target.c (solib_target_parse_libraries)
        [HAVEHAVE_LIBEXPAT not defined]: Fix thinko in return type.

I think I should also commit this on the branch. It looks pretty
obvious and fixes a build failure, even if the current number of
targets that use this file is very small (2 AFAICT).

Thanks,
-- 
Joel

[-- Attachment #2: solib-target.c.diff --]
[-- Type: text/plain, Size: 363 bytes --]

Index: solib-target.c
===================================================================
--- solib-target.c	(revision 15032)
+++ solib-target.c	(working copy)
@@ -51,7 +51,7 @@ DEF_VEC_P(lm_info_p);
 
 #if !defined(HAVE_LIBEXPAT)
 
-static VEC(lm_info_p)
+static VEC(lm_info_p) *
 solib_target_parse_libraries (const char *library)
 {
   static int have_warned;

             reply	other threads:[~2007-10-12 21:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-12 22:07 Joel Brobecker [this message]
2007-10-13  3:01 ` Daniel Jacobowitz
2007-10-13 10:13   ` Joel Brobecker
2007-10-13 13:52     ` Daniel Jacobowitz
2007-10-13 19:58       ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071012215533.GB4038@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox