Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: muller@ics.u-strasbg.fr
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] ARI fix:  Replace dirent.h by gdb_dirent.h in linux-fork.c
Date: Mon, 08 Oct 2007 13:27:00 -0000	[thread overview]
Message-ID: <200710081326.l98DQs62013226@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <009d01c809a7$a52fc9a0$ef8f5ce0$@u-strasbg.fr> 	(muller@ics.u-strasbg.fr)

> From: "Pierre Muller" <muller@ics.u-strasbg.fr>
> Date: Mon, 8 Oct 2007 14:35:01 +0200
> 
>  This one is almost like the previous that fixed the wait header.
> 
> OK to commit?

It probably doesn't matter on Linux, but in general it is better to
leave the headers in the same order when replacing <xxx.h> with
"gdb_xxx.h".

Mark

> ChangeLog entry:
> 
> 2007-10-08  Pierre Muller  <muller@ics.u-strasbg.fr>
> 
>         * linux-fork.c: ARI fix: include "gdb_dirent.h" instead of
> <dirent.h>.
>         Makefile.in (linux-fork.o): Add gdb_dirent.h dependency.
> 
> 
> 
> Index: linux-fork.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/linux-fork.c,v
> retrieving revision 1.13
> diff -u -p -r1.13 linux-fork.c
> --- linux-fork.c        8 Oct 2007 07:43:42 -0000       1.13
> +++ linux-fork.c        8 Oct 2007 12:27:45 -0000
> @@ -27,10 +27,10 @@
>  #include "linux-fork.h"
>  #include "linux-nat.h"
>  #include "gdb_wait.h"
> +#include "gdb_dirent.h"
> 
>  #include <sys/ptrace.h>
>  #include <sys/param.h>
> -#include <dirent.h>
>  #include <ctype.h>
> 
>  struct fork_info *fork_list;
> Index: Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/gdb/Makefile.in,v
> retrieving revision 1.940
> diff -u -p -r1.940 Makefile.in
> --- Makefile.in 8 Oct 2007 07:43:42 -0000       1.940
> +++ Makefile.in 8 Oct 2007 12:27:46 -0000
> @@ -2236,7 +2236,7 @@ linespec.o: linespec.c $(defs_h) $(symta
>         $(objc_lang_h) $(linespec_h) $(exceptions_h) $(language_h)
>  linux-fork.o: linux-fork.c $(defs_h) $(inferior_h) $(regcache_h)
> $(gdbcmd_h) \
>         $(infcall_h) $(gdb_assert_h) $(gdb_string_h) $(linux_fork_h) \
> -       $(linux_nat_h) $(gdb_wait_h)
> +       $(linux_nat_h) $(gdb_wait_h) $(gdb_dirent_h)
>  linux-nat.o: linux-nat.c $(defs_h) $(inferior_h) $(target_h)
> $(gdb_string_h) \
>         $(gdb_wait_h) $(gdb_assert_h) $(linux_nat_h) $(gdbthread_h) \
>         $(gdbcmd_h) $(regcache_h) $(regset_h) $(inf_ptrace_h) $(auxv_h) \
> 
> 
> 


  reply	other threads:[~2007-10-08 13:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-08 12:34 Pierre Muller
2007-10-08 13:27 ` Mark Kettenis [this message]
2007-10-08 13:48   ` Pierre Muller
2007-10-08 13:59     ` Joel Brobecker
2007-10-08 14:12       ` Pierre Muller
2007-10-08 14:31         ` Mark Kettenis
2007-10-08 14:41           ` Pierre Muller
2007-10-08 14:59             ` Mark Kettenis
2007-10-08 15:10               ` Pierre Muller
2007-10-08 14:47           ` [RFA-v2] " Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710081326.l98DQs62013226@brahms.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sourceware.org \
    --cc=muller@ics.u-strasbg.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox