RE: [RFA] ARI fix: Replace dirent.h by gdb_dirent.h in linux-fork.c

["Pierre Muller" <muller@ics.u-strasbg.fr>]

Thanks, I committed this:

ChangeLog entry:
2007-10-08  Pierre Muller  <muller@ics.u-strasbg.fr>

        * linux-fork.c: Move "gdb_wait.h" include back to the position of
        <sys/wait.h> include before last commit.

Index: linux-fork.c
===================================================================
RCS file: /cvs/src/src/gdb/linux-fork.c,v
retrieving revision 1.13
diff -u -p -r1.13 linux-fork.c
--- linux-fork.c        8 Oct 2007 07:43:42 -0000       1.13
+++ linux-fork.c        8 Oct 2007 14:37:57 -0000
@@ -26,9 +26,9 @@
 #include "gdb_string.h"
 #include "linux-fork.h"
 #include "linux-nat.h"
-#include "gdb_wait.h"

 #include <sys/ptrace.h>
+#include "gdb_wait.h"
 #include <sys/param.h>
 #include <dirent.h>
 #include <ctype.h>



> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Mark Kettenis
> Sent: Monday, October 08, 2007 4:30 PM
> To: muller@ics.u-strasbg.fr
> Cc: brobecker@adacore.com; gdb-patches@sourceware.org
> Subject: Re: [RFA] ARI fix: Replace dirent.h by gdb_dirent.h in linux-
> fork.c
> 
> > From: "Pierre Muller" <muller@ics.u-strasbg.fr>
> > Date: Mon, 8 Oct 2007 16:12:45 +0200
> >
> >   The include ordering stuff seems completely
> > opaque to me anyhow.
> >   <ctype.h> is included as last in linux-fork.c,
> > but right after "defs.h" in breakpoint.c.
> > Is there any rational for this?
> 
> Other than that people have been sloppy in the past?  No I don't think
> so.
> 
> >   Anyhow, if you also agree, it is probably best to leave
> > the ordering exactly as it was, just to stay on the
> > safe side.
> >
> >   Should I move the gdb_wait.h include back to where wait.h was?
> 
> I'd prefer that; consider a patch that does that pre-approved.