From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: "'Mark Kettenis'" <mark.kettenis@xs4all.nl>
Cc: <gdb-patches@sourceware.org>
Subject: RE: [RFA] ARI fix: Replace dirent.h by gdb_dirent.h in linux-fork.c
Date: Mon, 08 Oct 2007 13:48:00 -0000 [thread overview]
Message-ID: <009f01c809b1$f15c5280$d414f780$@u-strasbg.fr> (raw)
In-Reply-To: <200710081326.l98DQs62013226@brahms.sibelius.xs4all.nl>
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Mark Kettenis
> Sent: Monday, October 08, 2007 3:27 PM
> To: muller@ics.u-strasbg.fr
> Cc: gdb-patches@sourceware.org
> Subject: Re: [RFA] ARI fix: Replace dirent.h by gdb_dirent.h in linux-
> fork.c
>
> > From: "Pierre Muller" <muller@ics.u-strasbg.fr>
> > Date: Mon, 8 Oct 2007 14:35:01 +0200
> >
> > This one is almost like the previous that fixed the wait header.
> >
> > OK to commit?
>
> It probably doesn't matter on Linux, but in general it is better to
> leave the headers in the same order when replacing <xxx.h> with
> "gdb_xxx.h".
Maybe, but in my latest commit to linux-fork.c I did exactly
the same operation for the wait header, and moved it up from
the system <header.h> includes to the local "header.h" includes,
and Joel told me that this was the right thing to do...
See the
http://sourceware.org/ml/gdb-patches/2007-10/msg00044.html
thread.
Pierre
next prev parent reply other threads:[~2007-10-08 13:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 12:34 Pierre Muller
2007-10-08 13:27 ` Mark Kettenis
2007-10-08 13:48 ` Pierre Muller [this message]
2007-10-08 13:59 ` Joel Brobecker
2007-10-08 14:12 ` Pierre Muller
2007-10-08 14:31 ` Mark Kettenis
2007-10-08 14:41 ` Pierre Muller
2007-10-08 14:59 ` Mark Kettenis
2007-10-08 15:10 ` Pierre Muller
2007-10-08 14:47 ` [RFA-v2] " Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='009f01c809b1$f15c5280$d414f780$@u-strasbg.fr' \
--to=muller@ics.u-strasbg.fr \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox