From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: muller@ics.u-strasbg.fr
Cc: brobecker@adacore.com, gdb-patches@sourceware.org
Subject: Re: [RFA] ARI fix: Replace dirent.h by gdb_dirent.h in linux-fork.c
Date: Mon, 08 Oct 2007 14:31:00 -0000 [thread overview]
Message-ID: <200710081429.l98ETtZD002804@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <000001c809b5$4c51a9d0$e4f4fd70$@u-strasbg.fr> (muller@ics.u-strasbg.fr)
> From: "Pierre Muller" <muller@ics.u-strasbg.fr>
> Date: Mon, 8 Oct 2007 16:12:45 +0200
>
> The include ordering stuff seems completely
> opaque to me anyhow.
> <ctype.h> is included as last in linux-fork.c,
> but right after "defs.h" in breakpoint.c.
> Is there any rational for this?
Other than that people have been sloppy in the past? No I don't think
so.
> Anyhow, if you also agree, it is probably best to leave
> the ordering exactly as it was, just to stay on the
> safe side.
>
> Should I move the gdb_wait.h include back to where wait.h was?
I'd prefer that; consider a patch that does that pre-approved.
next prev parent reply other threads:[~2007-10-08 14:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 12:34 Pierre Muller
2007-10-08 13:27 ` Mark Kettenis
2007-10-08 13:48 ` Pierre Muller
2007-10-08 13:59 ` Joel Brobecker
2007-10-08 14:12 ` Pierre Muller
2007-10-08 14:31 ` Mark Kettenis [this message]
2007-10-08 14:41 ` Pierre Muller
2007-10-08 14:59 ` Mark Kettenis
2007-10-08 15:10 ` Pierre Muller
2007-10-08 14:47 ` [RFA-v2] " Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710081429.l98ETtZD002804@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox