From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-51169-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31209 invoked by alias); 8 Oct 2007 13:48:43 -0000
Received: (qmail 31197 invoked by uid 22791); 8 Oct 2007 13:48:42 -0000
X-Spam-Check-By: sourceware.org
Received: from ics.u-strasbg.fr (HELO ics.u-strasbg.fr) (130.79.112.250)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 08 Oct 2007 13:48:36 +0000
Received: from ICSMULLER (laocoon.u-strasbg.fr [130.79.112.72]) 	by ics.u-strasbg.fr (Postfix) with ESMTP id DB8F9187027; 	Mon,  8 Oct 2007 15:53:17 +0200 (CEST)
From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: "'Mark Kettenis'" <mark.kettenis@xs4all.nl>
Cc: <gdb-patches@sourceware.org>
References:  <009d01c809a7$a52fc9a0$ef8f5ce0$@u-strasbg.fr> <200710081326.l98DQs62013226@brahms.sibelius.xs4all.nl>
In-Reply-To: <200710081326.l98DQs62013226@brahms.sibelius.xs4all.nl>
Subject: RE: [RFA] ARI fix:  Replace dirent.h by gdb_dirent.h in linux-fork.c
Date: Mon, 08 Oct 2007 13:48:00 -0000
Message-ID: <009f01c809b1$f15c5280$d414f780$@u-strasbg.fr>
MIME-Version: 1.0
Content-Type: text/plain; 	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Office Outlook 12.0
Content-Language: en-us
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-10/txt/msg00147.txt.bz2

> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Mark Kettenis
> Sent: Monday, October 08, 2007 3:27 PM
> To: muller@ics.u-strasbg.fr
> Cc: gdb-patches@sourceware.org
> Subject: Re: [RFA] ARI fix: Replace dirent.h by gdb_dirent.h in linux-
> fork.c
> 
> > From: "Pierre Muller" <muller@ics.u-strasbg.fr>
> > Date: Mon, 8 Oct 2007 14:35:01 +0200
> >
> >  This one is almost like the previous that fixed the wait header.
> >
> > OK to commit?
> 
> It probably doesn't matter on Linux, but in general it is better to
> leave the headers in the same order when replacing <xxx.h> with
> "gdb_xxx.h".

  Maybe, but in my latest commit to linux-fork.c I did exactly
the same operation for the wait header, and moved it up from
the system <header.h> includes to the local "header.h" includes,
and Joel told me that this was the right thing to do...

See the
http://sourceware.org/ml/gdb-patches/2007-10/msg00044.html
thread.

Pierre