From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-51177-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3635 invoked by alias); 8 Oct 2007 14:41:31 -0000
Received: (qmail 3625 invoked by uid 22791); 8 Oct 2007 14:41:30 -0000
X-Spam-Check-By: sourceware.org
Received: from ics.u-strasbg.fr (HELO ics.u-strasbg.fr) (130.79.112.250)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 08 Oct 2007 14:41:26 +0000
Received: from ICSMULLER (laocoon.u-strasbg.fr [130.79.112.72]) 	by ics.u-strasbg.fr (Postfix) with ESMTP id 6AAFD18701E; 	Mon,  8 Oct 2007 16:46:08 +0200 (CEST)
From: "Pierre Muller" <muller@ics.u-strasbg.fr>
To: "'Mark Kettenis'" <mark.kettenis@xs4all.nl>
Cc: <brobecker@adacore.com>, 	<gdb-patches@sourceware.org>
References: <009d01c809a7$a52fc9a0$ef8f5ce0$@u-strasbg.fr> <200710081326.l98DQs62013226@brahms.sibelius.xs4all.nl> <009f01c809b1$f15c5280$d414f780$@u-strasbg.fr> <20071008135843.GL3570@adacore.com> <000001c809b5$4c51a9d0$e4f4fd70$@u-strasbg.fr> <200710081429.l98ETtZD002804@brahms.sibelius.xs4all.nl>
In-Reply-To: <200710081429.l98ETtZD002804@brahms.sibelius.xs4all.nl>
Subject: RE: [RFA] ARI fix:  Replace dirent.h by gdb_dirent.h in linux-fork.c
Date: Mon, 08 Oct 2007 14:41:00 -0000
Message-ID: <000101c809b9$53d559f0$fb800dd0$@u-strasbg.fr>
MIME-Version: 1.0
Content-Type: text/plain; 	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Office Outlook 12.0
Content-Language: en-us
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-10/txt/msg00155.txt.bz2

Thanks, I committed this:

ChangeLog entry:
2007-10-08  Pierre Muller  <muller@ics.u-strasbg.fr>

        * linux-fork.c: Move "gdb_wait.h" include back to the position of
        <sys/wait.h> include before last commit.

Index: linux-fork.c
===================================================================
RCS file: /cvs/src/src/gdb/linux-fork.c,v
retrieving revision 1.13
diff -u -p -r1.13 linux-fork.c
--- linux-fork.c        8 Oct 2007 07:43:42 -0000       1.13
+++ linux-fork.c        8 Oct 2007 14:37:57 -0000
@@ -26,9 +26,9 @@
 #include "gdb_string.h"
 #include "linux-fork.h"
 #include "linux-nat.h"
-#include "gdb_wait.h"

 #include <sys/ptrace.h>
+#include "gdb_wait.h"
 #include <sys/param.h>
 #include <dirent.h>
 #include <ctype.h>



> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Mark Kettenis
> Sent: Monday, October 08, 2007 4:30 PM
> To: muller@ics.u-strasbg.fr
> Cc: brobecker@adacore.com; gdb-patches@sourceware.org
> Subject: Re: [RFA] ARI fix: Replace dirent.h by gdb_dirent.h in linux-
> fork.c
> 
> > From: "Pierre Muller" <muller@ics.u-strasbg.fr>
> > Date: Mon, 8 Oct 2007 16:12:45 +0200
> >
> >   The include ordering stuff seems completely
> > opaque to me anyhow.
> >   <ctype.h> is included as last in linux-fork.c,
> > but right after "defs.h" in breakpoint.c.
> > Is there any rational for this?
> 
> Other than that people have been sloppy in the past?  No I don't think
> so.
> 
> >   Anyhow, if you also agree, it is probably best to leave
> > the ordering exactly as it was, just to stay on the
> > safe side.
> >
> >   Should I move the gdb_wait.h include back to where wait.h was?
> 
> I'd prefer that; consider a patch that does that pre-approved.