From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-51165-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22362 invoked by alias); 8 Oct 2007 13:27:06 -0000
Received: (qmail 22353 invoked by uid 22791); 8 Oct 2007 13:27:06 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 08 Oct 2007 13:26:59 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.0) with ESMTP id l98DQs9W030895; 	Mon, 8 Oct 2007 15:26:54 +0200 (CEST)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.1/Submit) id l98DQs62013226; 	Mon, 8 Oct 2007 15:26:54 +0200 (CEST)
Date: Mon, 08 Oct 2007 13:27:00 -0000
Message-Id: <200710081326.l98DQs62013226@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: muller@ics.u-strasbg.fr
CC: gdb-patches@sourceware.org
In-reply-to: <009d01c809a7$a52fc9a0$ef8f5ce0$@u-strasbg.fr> 	(muller@ics.u-strasbg.fr)
Subject: Re: [RFA] ARI fix:  Replace dirent.h by gdb_dirent.h in linux-fork.c
References:  <009d01c809a7$a52fc9a0$ef8f5ce0$@u-strasbg.fr>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-10/txt/msg00143.txt.bz2

> From: "Pierre Muller" <muller@ics.u-strasbg.fr>
> Date: Mon, 8 Oct 2007 14:35:01 +0200
> 
>  This one is almost like the previous that fixed the wait header.
> 
> OK to commit?

It probably doesn't matter on Linux, but in general it is better to
leave the headers in the same order when replacing <xxx.h> with
"gdb_xxx.h".

Mark

> ChangeLog entry:
> 
> 2007-10-08  Pierre Muller  <muller@ics.u-strasbg.fr>
> 
>         * linux-fork.c: ARI fix: include "gdb_dirent.h" instead of
> <dirent.h>.
>         Makefile.in (linux-fork.o): Add gdb_dirent.h dependency.
> 
> 
> 
> Index: linux-fork.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/linux-fork.c,v
> retrieving revision 1.13
> diff -u -p -r1.13 linux-fork.c
> --- linux-fork.c        8 Oct 2007 07:43:42 -0000       1.13
> +++ linux-fork.c        8 Oct 2007 12:27:45 -0000
> @@ -27,10 +27,10 @@
>  #include "linux-fork.h"
>  #include "linux-nat.h"
>  #include "gdb_wait.h"
> +#include "gdb_dirent.h"
> 
>  #include <sys/ptrace.h>
>  #include <sys/param.h>
> -#include <dirent.h>
>  #include <ctype.h>
> 
>  struct fork_info *fork_list;
> Index: Makefile.in
> ===================================================================
> RCS file: /cvs/src/src/gdb/Makefile.in,v
> retrieving revision 1.940
> diff -u -p -r1.940 Makefile.in
> --- Makefile.in 8 Oct 2007 07:43:42 -0000       1.940
> +++ Makefile.in 8 Oct 2007 12:27:46 -0000
> @@ -2236,7 +2236,7 @@ linespec.o: linespec.c $(defs_h) $(symta
>         $(objc_lang_h) $(linespec_h) $(exceptions_h) $(language_h)
>  linux-fork.o: linux-fork.c $(defs_h) $(inferior_h) $(regcache_h)
> $(gdbcmd_h) \
>         $(infcall_h) $(gdb_assert_h) $(gdb_string_h) $(linux_fork_h) \
> -       $(linux_nat_h) $(gdb_wait_h)
> +       $(linux_nat_h) $(gdb_wait_h) $(gdb_dirent_h)
>  linux-nat.o: linux-nat.c $(defs_h) $(inferior_h) $(target_h)
> $(gdb_string_h) \
>         $(gdb_wait_h) $(gdb_assert_h) $(linux_nat_h) $(gdbthread_h) \
>         $(gdbcmd_h) $(regcache_h) $(regset_h) $(inf_ptrace_h) $(auxv_h) \
> 
> 
>