* Re: mips-tdep.c: Fix a comment about new-ABI FP return values
@ 2007-09-25 16:03 Maciej W. Rozycki
2007-09-25 16:12 ` Daniel Jacobowitz
0 siblings, 1 reply; 2+ messages in thread
From: Maciej W. Rozycki @ 2007-09-25 16:03 UTC (permalink / raw)
To: gdb-patches; +Cc: David Ung, Maciej W. Rozycki
Hello,
The comment about single/double FP return values in
mips_n32n64_return_value() is obviously incorrect. There is no such thing
as the least significant part of FP0. [OK, the cp0.Status.FR bit lets you
truncate FP registers as seen by lwc1/swc1/mtc1/mfc1 to 32-bits, but the
new ABI assumes this compatibility mode is not used.]
2007-09-25 David Ung <davidu@mips.com>
Maciej W. Rozycki <macro@mips.com>
* mips-tdep.c (mips_n32n64_return_value): Fix a comment.
OK to apply?
Maciej
12695.diff
Index: binutils-quilt/src/gdb/mips-tdep.c
===================================================================
--- binutils-quilt.orig/src/gdb/mips-tdep.c 2007-09-25 16:29:10.000000000 +0100
+++ binutils-quilt/src/gdb/mips-tdep.c 2007-09-25 16:30:32.000000000 +0100
@@ -3127,8 +3127,7 @@
else if (TYPE_CODE (type) == TYPE_CODE_FLT
&& tdep->mips_fpu_type != MIPS_FPU_NONE)
{
- /* A floating-point value belongs in the least significant part
- of FP0. */
+ /* A single or double floating-point value that fits in FP0. */
if (mips_debug)
fprintf_unfiltered (gdb_stderr, "Return float in $fp0\n");
mips_xfer_register (regcache,
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: mips-tdep.c: Fix a comment about new-ABI FP return values
2007-09-25 16:03 mips-tdep.c: Fix a comment about new-ABI FP return values Maciej W. Rozycki
@ 2007-09-25 16:12 ` Daniel Jacobowitz
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Jacobowitz @ 2007-09-25 16:12 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: gdb-patches, David Ung, Maciej W. Rozycki
On Tue, Sep 25, 2007 at 05:03:10PM +0100, Maciej W. Rozycki wrote:
> Hello,
>
> The comment about single/double FP return values in
> mips_n32n64_return_value() is obviously incorrect. There is no such thing
> as the least significant part of FP0. [OK, the cp0.Status.FR bit lets you
> truncate FP registers as seen by lwc1/swc1/mtc1/mfc1 to 32-bits, but the
> new ABI assumes this compatibility mode is not used.]
>
> 2007-09-25 David Ung <davidu@mips.com>
> Maciej W. Rozycki <macro@mips.com>
>
> * mips-tdep.c (mips_n32n64_return_value): Fix a comment.
>
> OK to apply?
Yep, thank you.
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-09-25 16:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-09-25 16:03 mips-tdep.c: Fix a comment about new-ABI FP return values Maciej W. Rozycki
2007-09-25 16:12 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox