Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: gdb-patches@sourceware.org, David Ung <davidu@mips.com>,
		"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: mips-tdep.c: Fix a comment about new-ABI FP return values
Date: Tue, 25 Sep 2007 16:12:00 -0000	[thread overview]
Message-ID: <20070925161213.GA12515@caradoc.them.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0709251654230.6904@perivale.mips.com>

On Tue, Sep 25, 2007 at 05:03:10PM +0100, Maciej W. Rozycki wrote:
> Hello,
> 
>  The comment about single/double FP return values in 
> mips_n32n64_return_value() is obviously incorrect.  There is no such thing 
> as the least significant part of FP0.  [OK, the cp0.Status.FR bit lets you 
> truncate FP registers as seen by lwc1/swc1/mtc1/mfc1 to 32-bits, but the 
> new ABI assumes this compatibility mode is not used.]
> 
> 2007-09-25  David Ung  <davidu@mips.com>
>             Maciej W. Rozycki  <macro@mips.com>
> 
> 	* mips-tdep.c (mips_n32n64_return_value): Fix a comment.
> 
>  OK to apply?

Yep, thank you.

-- 
Daniel Jacobowitz
CodeSourcery


      reply	other threads:[~2007-09-25 16:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-25 16:03 Maciej W. Rozycki
2007-09-25 16:12 ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070925161213.GA12515@caradoc.them.org \
    --to=drow@false.org \
    --cc=davidu@mips.com \
    --cc=gdb-patches@sourceware.org \
    --cc=macro@linux-mips.org \
    --cc=macro@mips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox