From: "Maciej W. Rozycki" <macro@mips.com>
To: gdb-patches@sourceware.org
Cc: David Ung <davidu@mips.com>, "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: mips-tdep.c: Fix a comment about new-ABI FP return values
Date: Tue, 25 Sep 2007 16:03:00 -0000 [thread overview]
Message-ID: <Pine.LNX.4.61.0709251654230.6904@perivale.mips.com> (raw)
Hello,
The comment about single/double FP return values in
mips_n32n64_return_value() is obviously incorrect. There is no such thing
as the least significant part of FP0. [OK, the cp0.Status.FR bit lets you
truncate FP registers as seen by lwc1/swc1/mtc1/mfc1 to 32-bits, but the
new ABI assumes this compatibility mode is not used.]
2007-09-25 David Ung <davidu@mips.com>
Maciej W. Rozycki <macro@mips.com>
* mips-tdep.c (mips_n32n64_return_value): Fix a comment.
OK to apply?
Maciej
12695.diff
Index: binutils-quilt/src/gdb/mips-tdep.c
===================================================================
--- binutils-quilt.orig/src/gdb/mips-tdep.c 2007-09-25 16:29:10.000000000 +0100
+++ binutils-quilt/src/gdb/mips-tdep.c 2007-09-25 16:30:32.000000000 +0100
@@ -3127,8 +3127,7 @@
else if (TYPE_CODE (type) == TYPE_CODE_FLT
&& tdep->mips_fpu_type != MIPS_FPU_NONE)
{
- /* A floating-point value belongs in the least significant part
- of FP0. */
+ /* A single or double floating-point value that fits in FP0. */
if (mips_debug)
fprintf_unfiltered (gdb_stderr, "Return float in $fp0\n");
mips_xfer_register (regcache,
next reply other threads:[~2007-09-25 16:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 16:03 Maciej W. Rozycki [this message]
2007-09-25 16:12 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0709251654230.6904@perivale.mips.com \
--to=macro@mips.com \
--cc=davidu@mips.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox