From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14478 invoked by alias); 25 Sep 2007 16:03:18 -0000 Received: (qmail 14468 invoked by uid 22791); 25 Sep 2007 16:03:17 -0000 X-Spam-Check-By: sourceware.org Received: from dmz.mips-uk.com (HELO dmz.mips-uk.com) (194.74.144.194) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 25 Sep 2007 16:03:15 +0000 Received: from internal-mx1 ([192.168.192.240] helo=ukservices1.mips.com) by dmz.mips-uk.com with esmtp (Exim 3.35 #1 (Debian)) id 1IaCsS-0000OP-00; Tue, 25 Sep 2007 17:03:12 +0100 Received: from perivale.mips.com ([192.168.192.200]) by ukservices1.mips.com with esmtp (Exim 3.36 #1 (Debian)) id 1IaCsQ-0003FW-00; Tue, 25 Sep 2007 17:03:10 +0100 Received: from macro (helo=localhost) by perivale.mips.com with local-esmtp (Exim 4.63) (envelope-from ) id 1IaCsQ-0007on-GF; Tue, 25 Sep 2007 17:03:10 +0100 Date: Tue, 25 Sep 2007 16:03:00 -0000 From: "Maciej W. Rozycki" To: gdb-patches@sourceware.org cc: David Ung , "Maciej W. Rozycki" Subject: Re: mips-tdep.c: Fix a comment about new-ABI FP return values Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-MIPS-Technologies-UK-MailScanner: Found to be clean X-MIPS-Technologies-UK-MailScanner-From: macro@mips.com Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00353.txt.bz2 Hello, The comment about single/double FP return values in mips_n32n64_return_value() is obviously incorrect. There is no such thing as the least significant part of FP0. [OK, the cp0.Status.FR bit lets you truncate FP registers as seen by lwc1/swc1/mtc1/mfc1 to 32-bits, but the new ABI assumes this compatibility mode is not used.] 2007-09-25 David Ung Maciej W. Rozycki * mips-tdep.c (mips_n32n64_return_value): Fix a comment. OK to apply? Maciej 12695.diff Index: binutils-quilt/src/gdb/mips-tdep.c =================================================================== --- binutils-quilt.orig/src/gdb/mips-tdep.c 2007-09-25 16:29:10.000000000 +0100 +++ binutils-quilt/src/gdb/mips-tdep.c 2007-09-25 16:30:32.000000000 +0100 @@ -3127,8 +3127,7 @@ else if (TYPE_CODE (type) == TYPE_CODE_FLT && tdep->mips_fpu_type != MIPS_FPU_NONE) { - /* A floating-point value belongs in the least significant part - of FP0. */ + /* A single or double floating-point value that fits in FP0. */ if (mips_debug) fprintf_unfiltered (gdb_stderr, "Return float in $fp0\n"); mips_xfer_register (regcache,