* [RFA] mips, recognizing floating point args
@ 2006-05-31 23:41 Michael Snyder
2006-06-06 18:29 ` Joel Brobecker
0 siblings, 1 reply; 4+ messages in thread
From: Michael Snyder @ 2006-05-31 23:41 UTC (permalink / raw)
To: Joel Brobecker, GDB Patches, fnf
[-- Attachment #1: Type: text/plain, Size: 47 bytes --]
fp_register_arg_p should recognize a typedef.
[-- Attachment #2: d4 --]
[-- Type: text/plain, Size: 999 bytes --]
2006-05-31 Michael Snyder <msnyder@redhat.com>
* mips-tdep.c (fp_register_arg_p): Recognize floating point typedefs.
Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.393
diff -p -r1.393 mips-tdep.c
*** mips-tdep.c 31 May 2006 23:15:50 -0000 1.393
--- mips-tdep.c 31 May 2006 23:36:48 -0000
*************** fp_register_arg_p (enum type_code typeco
*** 2335,2341 ****
&& (typecode == TYPE_CODE_STRUCT
|| typecode == TYPE_CODE_UNION)
&& TYPE_NFIELDS (arg_type) == 1
! && TYPE_CODE (TYPE_FIELD_TYPE (arg_type, 0)) == TYPE_CODE_FLT))
&& MIPS_FPU_TYPE != MIPS_FPU_NONE);
}
--- 2335,2341 ----
&& (typecode == TYPE_CODE_STRUCT
|| typecode == TYPE_CODE_UNION)
&& TYPE_NFIELDS (arg_type) == 1
! && TYPE_CODE (check_typedef (TYPE_FIELD_TYPE (arg_type, 0))) == TYPE_CODE_FLT))
&& MIPS_FPU_TYPE != MIPS_FPU_NONE);
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] mips, recognizing floating point args
2006-05-31 23:41 [RFA] mips, recognizing floating point args Michael Snyder
@ 2006-06-06 18:29 ` Joel Brobecker
2006-06-06 18:34 ` Daniel Jacobowitz
2006-06-08 19:16 ` Michael Snyder
0 siblings, 2 replies; 4+ messages in thread
From: Joel Brobecker @ 2006-06-06 18:29 UTC (permalink / raw)
To: Michael Snyder; +Cc: GDB Patches, fnf
Hi Michael,
> fp_register_arg_p should recognize a typedef.
> 2006-05-31 Michael Snyder <msnyder@redhat.com>
>
> * mips-tdep.c (fp_register_arg_p): Recognize floating point typedefs.
For what is worth, this patch looks good to me.
>
> Index: mips-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/mips-tdep.c,v
> retrieving revision 1.393
> diff -p -r1.393 mips-tdep.c
> *** mips-tdep.c 31 May 2006 23:15:50 -0000 1.393
> --- mips-tdep.c 31 May 2006 23:36:48 -0000
> *************** fp_register_arg_p (enum type_code typeco
> *** 2335,2341 ****
> && (typecode == TYPE_CODE_STRUCT
> || typecode == TYPE_CODE_UNION)
> && TYPE_NFIELDS (arg_type) == 1
> ! && TYPE_CODE (TYPE_FIELD_TYPE (arg_type, 0)) == TYPE_CODE_FLT))
> && MIPS_FPU_TYPE != MIPS_FPU_NONE);
> }
>
> --- 2335,2341 ----
> && (typecode == TYPE_CODE_STRUCT
> || typecode == TYPE_CODE_UNION)
> && TYPE_NFIELDS (arg_type) == 1
> ! && TYPE_CODE (check_typedef (TYPE_FIELD_TYPE (arg_type, 0))) == TYPE_CODE_FLT))
> && MIPS_FPU_TYPE != MIPS_FPU_NONE);
> }
>
--
Joel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] mips, recognizing floating point args
2006-06-06 18:29 ` Joel Brobecker
@ 2006-06-06 18:34 ` Daniel Jacobowitz
2006-06-08 19:16 ` Michael Snyder
1 sibling, 0 replies; 4+ messages in thread
From: Daniel Jacobowitz @ 2006-06-06 18:34 UTC (permalink / raw)
To: Joel Brobecker; +Cc: Michael Snyder, GDB Patches, fnf
On Tue, Jun 06, 2006 at 11:29:28AM -0700, Joel Brobecker wrote:
> Hi Michael,
>
> > fp_register_arg_p should recognize a typedef.
>
> > 2006-05-31 Michael Snyder <msnyder@redhat.com>
> >
> > * mips-tdep.c (fp_register_arg_p): Recognize floating point typedefs.
>
> For what is worth, this patch looks good to me.
Yes, this is OK - but, Michael, please find some way to avoid the 95
character line :-)
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] mips, recognizing floating point args
2006-06-06 18:29 ` Joel Brobecker
2006-06-06 18:34 ` Daniel Jacobowitz
@ 2006-06-08 19:16 ` Michael Snyder
1 sibling, 0 replies; 4+ messages in thread
From: Michael Snyder @ 2006-06-08 19:16 UTC (permalink / raw)
To: Joel Brobecker; +Cc: GDB Patches, fnf
Joel Brobecker wrote:
> Hi Michael,
>
>
>>fp_register_arg_p should recognize a typedef.
>
>
>>2006-05-31 Michael Snyder <msnyder@redhat.com>
>>
>> * mips-tdep.c (fp_register_arg_p): Recognize floating point typedefs.
>
>
> For what is worth, this patch looks good to me.
It should be worth something, since you're the mips "authorized committer".
Committed. Daniel, I broke up the long line.
>
>>Index: mips-tdep.c
>>===================================================================
>>RCS file: /cvs/src/src/gdb/mips-tdep.c,v
>>retrieving revision 1.393
>>diff -p -r1.393 mips-tdep.c
>>*** mips-tdep.c 31 May 2006 23:15:50 -0000 1.393
>>--- mips-tdep.c 31 May 2006 23:36:48 -0000
>>*************** fp_register_arg_p (enum type_code typeco
>>*** 2335,2341 ****
>> && (typecode == TYPE_CODE_STRUCT
>> || typecode == TYPE_CODE_UNION)
>> && TYPE_NFIELDS (arg_type) == 1
>>! && TYPE_CODE (TYPE_FIELD_TYPE (arg_type, 0)) == TYPE_CODE_FLT))
>> && MIPS_FPU_TYPE != MIPS_FPU_NONE);
>> }
>>
>>--- 2335,2341 ----
>> && (typecode == TYPE_CODE_STRUCT
>> || typecode == TYPE_CODE_UNION)
>> && TYPE_NFIELDS (arg_type) == 1
>>! && TYPE_CODE (check_typedef (TYPE_FIELD_TYPE (arg_type, 0))) == TYPE_CODE_FLT))
>> && MIPS_FPU_TYPE != MIPS_FPU_NONE);
>> }
>>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-06-08 19:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-05-31 23:41 [RFA] mips, recognizing floating point args Michael Snyder
2006-06-06 18:29 ` Joel Brobecker
2006-06-06 18:34 ` Daniel Jacobowitz
2006-06-08 19:16 ` Michael Snyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox