From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16862 invoked by alias); 8 Jun 2006 19:16:06 -0000 Received: (qmail 16843 invoked by uid 22791); 8 Jun 2006 19:15:58 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 08 Jun 2006 19:15:55 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k58JFr9k014101; Thu, 8 Jun 2006 15:15:53 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k58JFqbo003638; Thu, 8 Jun 2006 15:15:52 -0400 Received: from [172.16.24.50] (bluegiant.sfbay.redhat.com [172.16.24.50]) by potter.sfbay.redhat.com (8.12.8/8.12.8) with ESMTP id k58JFo71001891; Thu, 8 Jun 2006 15:15:51 -0400 Message-ID: <44887766.6070108@redhat.com> Date: Thu, 08 Jun 2006 19:16:00 -0000 From: Michael Snyder User-Agent: Mozilla Thunderbird 1.0.7-1.4.1 (X11/20050929) MIME-Version: 1.0 To: Joel Brobecker CC: GDB Patches , fnf@specifix.com Subject: Re: [RFA] mips, recognizing floating point args References: <447E290F.5080307@redhat.com> <20060606182928.GF1056@adacore.com> In-Reply-To: <20060606182928.GF1056@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00076.txt.bz2 Joel Brobecker wrote: > Hi Michael, > > >>fp_register_arg_p should recognize a typedef. > > >>2006-05-31 Michael Snyder >> >> * mips-tdep.c (fp_register_arg_p): Recognize floating point typedefs. > > > For what is worth, this patch looks good to me. It should be worth something, since you're the mips "authorized committer". Committed. Daniel, I broke up the long line. > >>Index: mips-tdep.c >>=================================================================== >>RCS file: /cvs/src/src/gdb/mips-tdep.c,v >>retrieving revision 1.393 >>diff -p -r1.393 mips-tdep.c >>*** mips-tdep.c 31 May 2006 23:15:50 -0000 1.393 >>--- mips-tdep.c 31 May 2006 23:36:48 -0000 >>*************** fp_register_arg_p (enum type_code typeco >>*** 2335,2341 **** >> && (typecode == TYPE_CODE_STRUCT >> || typecode == TYPE_CODE_UNION) >> && TYPE_NFIELDS (arg_type) == 1 >>! && TYPE_CODE (TYPE_FIELD_TYPE (arg_type, 0)) == TYPE_CODE_FLT)) >> && MIPS_FPU_TYPE != MIPS_FPU_NONE); >> } >> >>--- 2335,2341 ---- >> && (typecode == TYPE_CODE_STRUCT >> || typecode == TYPE_CODE_UNION) >> && TYPE_NFIELDS (arg_type) == 1 >>! && TYPE_CODE (check_typedef (TYPE_FIELD_TYPE (arg_type, 0))) == TYPE_CODE_FLT)) >> && MIPS_FPU_TYPE != MIPS_FPU_NONE); >> } >> > > >