From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30180 invoked by alias); 6 Jun 2006 18:29:37 -0000 Received: (qmail 30171 invoked by uid 22791); 6 Jun 2006 18:29:36 -0000 X-Spam-Check-By: sourceware.org Received: from nile.gnat.com (HELO nile.gnat.com) (205.232.38.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 06 Jun 2006 18:29:32 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-nile.gnat.com (Postfix) with ESMTP id A73BF48CBD6; Tue, 6 Jun 2006 14:29:30 -0400 (EDT) Received: from nile.gnat.com ([127.0.0.1]) by localhost (nile.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 01831-01-4; Tue, 6 Jun 2006 14:29:30 -0400 (EDT) Received: from takamaka.act-europe.fr (s142-179-108-108.bc.hsia.telus.net [142.179.108.108]) by nile.gnat.com (Postfix) with ESMTP id 1DF2048CBD5; Tue, 6 Jun 2006 14:29:30 -0400 (EDT) Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 354A947E7F; Tue, 6 Jun 2006 11:29:28 -0700 (PDT) Date: Tue, 06 Jun 2006 18:29:00 -0000 From: Joel Brobecker To: Michael Snyder Cc: GDB Patches , fnf@specifix.com Subject: Re: [RFA] mips, recognizing floating point args Message-ID: <20060606182928.GF1056@adacore.com> References: <447E290F.5080307@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <447E290F.5080307@redhat.com> User-Agent: Mutt/1.4i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00069.txt.bz2 Hi Michael, > fp_register_arg_p should recognize a typedef. > 2006-05-31 Michael Snyder > > * mips-tdep.c (fp_register_arg_p): Recognize floating point typedefs. For what is worth, this patch looks good to me. > > Index: mips-tdep.c > =================================================================== > RCS file: /cvs/src/src/gdb/mips-tdep.c,v > retrieving revision 1.393 > diff -p -r1.393 mips-tdep.c > *** mips-tdep.c 31 May 2006 23:15:50 -0000 1.393 > --- mips-tdep.c 31 May 2006 23:36:48 -0000 > *************** fp_register_arg_p (enum type_code typeco > *** 2335,2341 **** > && (typecode == TYPE_CODE_STRUCT > || typecode == TYPE_CODE_UNION) > && TYPE_NFIELDS (arg_type) == 1 > ! && TYPE_CODE (TYPE_FIELD_TYPE (arg_type, 0)) == TYPE_CODE_FLT)) > && MIPS_FPU_TYPE != MIPS_FPU_NONE); > } > > --- 2335,2341 ---- > && (typecode == TYPE_CODE_STRUCT > || typecode == TYPE_CODE_UNION) > && TYPE_NFIELDS (arg_type) == 1 > ! && TYPE_CODE (check_typedef (TYPE_FIELD_TYPE (arg_type, 0))) == TYPE_CODE_FLT)) > && MIPS_FPU_TYPE != MIPS_FPU_NONE); > } > -- Joel