Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Michael Snyder <msnyder@redhat.com>
Cc: GDB Patches <gdb-patches@sources.redhat.com>, fnf@specifix.com
Subject: Re: [RFA] mips, recognizing floating point args
Date: Tue, 06 Jun 2006 18:29:00 -0000	[thread overview]
Message-ID: <20060606182928.GF1056@adacore.com> (raw)
In-Reply-To: <447E290F.5080307@redhat.com>

Hi Michael,

> fp_register_arg_p should recognize a typedef.

> 2006-05-31  Michael Snyder  <msnyder@redhat.com>
> 
> 	* mips-tdep.c (fp_register_arg_p): Recognize floating point typedefs.

For what is worth, this patch looks good to me.

> 
> Index: mips-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/mips-tdep.c,v
> retrieving revision 1.393
> diff -p -r1.393 mips-tdep.c
> *** mips-tdep.c	31 May 2006 23:15:50 -0000	1.393
> --- mips-tdep.c	31 May 2006 23:36:48 -0000
> *************** fp_register_arg_p (enum type_code typeco
> *** 2335,2341 ****
>   	       && (typecode == TYPE_CODE_STRUCT
>   		   || typecode == TYPE_CODE_UNION)
>   	       && TYPE_NFIELDS (arg_type) == 1
> ! 	       && TYPE_CODE (TYPE_FIELD_TYPE (arg_type, 0)) == TYPE_CODE_FLT))
>   	  && MIPS_FPU_TYPE != MIPS_FPU_NONE);
>   }
>   
> --- 2335,2341 ----
>   	       && (typecode == TYPE_CODE_STRUCT
>   		   || typecode == TYPE_CODE_UNION)
>   	       && TYPE_NFIELDS (arg_type) == 1
> ! 	       && TYPE_CODE (check_typedef (TYPE_FIELD_TYPE (arg_type, 0))) == TYPE_CODE_FLT))
>   	  && MIPS_FPU_TYPE != MIPS_FPU_NONE);
>   }
>   


-- 
Joel


  reply	other threads:[~2006-06-06 18:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-31 23:41 Michael Snyder
2006-06-06 18:29 ` Joel Brobecker [this message]
2006-06-06 18:34   ` Daniel Jacobowitz
2006-06-08 19:16   ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060606182928.GF1056@adacore.com \
    --to=brobecker@adacore.com \
    --cc=fnf@specifix.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=msnyder@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox