Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <ghost@cs.msu.su>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Remove type prefix for -var-evaluate-expression/functions
Date: Fri, 05 May 2006 20:47:00 -0000	[thread overview]
Message-ID: <20060505204746.GZ31029@nevyn.them.org> (raw)
In-Reply-To: <e0t6jb$700$1@sea.gmane.org>

On Tue, Apr 04, 2006 at 11:18:02AM +0400, Vladimir Prus wrote:
> The new version of the patch, with testsuite change, is attached.
> 
> Changelog:
> 2006-03-15 Vladimir Prus <ghost@cs.msu.su>
>         
>         * c-valprint.c 
>          (c_val_print): Don't print type prefix for functions.
>          (c_value_print): Print type prefix for functions here.
>         * testsuite/gdb.mi/mi-var-cmd.exp: Test for new behaviour.

Hi Vladimir (do you prefer Volodya?),

This patch is fine.  Please adjust the ChangeLog entry for GNU
formatting - I realize everyone else puts their asterisks in a
different place than we do:

	* c-valprint.c  (c_val_print): Don't print type prefix for functions.
	(c_value_print): Print type prefix for functions here.

	* gdb.mi/mi-var-cmd.exp: Test for printing functions.

Otherwise, feel free to check it in.

[You don't usually want to refer to "new behavior" in the testsuite
changelog entry, because it's tricky to go back and see what commit in
the gdb ChangeLog the test corresponds to.  Yes, this is just CVS's
fault really.]


-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-05-05 20:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-17 14:33 Nick Roberts
2006-03-17 15:03 ` Vladimir Prus
2006-03-18  1:26   ` Daniel Jacobowitz
2006-04-04  7:18     ` Vladimir Prus
2006-05-05 20:47       ` Daniel Jacobowitz [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-03-17 10:20 Nick Roberts
2006-03-17 10:42 ` Vladimir Prus
2006-03-15 16:27 Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060505204746.GZ31029@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=ghost@cs.msu.su \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox