From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <ghost@cs.msu.su>
Cc: Nick Roberts <nickrob@snap.net.nz>, gdb-patches@sources.redhat.com
Subject: Re: Remove type prefix for -var-evaluate-expression/functions
Date: Sat, 18 Mar 2006 01:26:00 -0000 [thread overview]
Message-ID: <20060317193702.GC19068@nevyn.them.org> (raw)
In-Reply-To: <200603171319.55381.ghost@cs.msu.su>
On Fri, Mar 17, 2006 at 01:19:54PM +0300, Vladimir Prus wrote:
> On Friday 17 March 2006 13:02, Nick Roberts wrote:
> > > > > the following patch removes 'type prefix' from output of
> > > > > -var-evaluate-expression applied to objects of function type (not
> > > > > pointers to functions, but functions).
> > > > >
> > > > > It causes no regression in the testsuite for me.
> > > >
> > > > But I guess a new test would help prevent a regression (in the code) in
> > > > the future.
> > >
> > > Yes, can you suggest which file should I add this new testcase too?
> >
> > Well I guess mi-var-cmd.exp. Please remember that I'm not the maintainer
> > but just an interested party. See what Daniel says. He might want
> > something for mi2-var-cmd.exp too.
>
> Ok, I'll wait for his comment.
mi-var-cmd.exp sounds good to me. I don't think we need it in
mi2-var-cmd.exp. I have the same question I asked a moment ago about
Nick's patch - is there any chance that someone relies on this
information?
Here I think the chance is pretty slim; for pointers it's a more
serious concern, but for functions this is a pretty rare case.
So not versioning this change makes sense to me.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-03-17 19:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-17 14:33 Nick Roberts
2006-03-17 15:03 ` Vladimir Prus
2006-03-18 1:26 ` Daniel Jacobowitz [this message]
2006-04-04 7:18 ` Vladimir Prus
2006-05-05 20:47 ` Daniel Jacobowitz
-- strict thread matches above, loose matches on Subject: below --
2006-03-17 10:20 Nick Roberts
2006-03-17 10:42 ` Vladimir Prus
2006-03-15 16:27 Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060317193702.GC19068@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=ghost@cs.msu.su \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox