Re: Remove type prefix for -var-evaluate-expression/functions

[Vladimir Prus <ghost@cs.msu.su>]

On Friday 17 March 2006 13:02, Nick Roberts wrote:
> > > > the following patch removes 'type prefix' from output of
> > > > -var-evaluate-expression applied to objects of function type (not
> > > > pointers to functions, but functions).
> > > >
> > > > It causes no regression in the testsuite for me.
> > >
> > > But I guess a new test would help prevent a regression (in the code) in
> > > the future.
> >
> > Yes, can you suggest which file should I add this new testcase too?
>
> Well I guess mi-var-cmd.exp.  Please remember that I'm not the maintainer
> but just an interested party.  See what Daniel says.  He might want
> something for mi2-var-cmd.exp too.

Ok, I'll wait for his comment.

>
> > > > +  if (TYPE_CODE (type) == TYPE_CODE_FUNC)
> > >
> > > This condition must always be true here (case TYPE_CODE_FUNC:).
> >
> > This chunk is in 'c_value_print', where there's no switch.
>
> Ah yes!  I misread the patch.
>
> > I guess I'd better send the patch with "-p". It's attached, hopefully
> > it's more clear.
> >
> > And thanks for the hint about -p!
>
> Hmm...yes, I guess I've proved my own point.

Indeed.

> PS I'm not subscribed to gdb-patches so please include me in your replies.
> I think its fairly standard to do this as its more inconvenient to get no
> reply, than get two and have to delete one.

Apologies. In fact, I regularly use NNTP interface to read/reply gdb-patches  
(gmane.comp.gdb.patches newsgroup at gmane.org), and NNTP reader does not 
allow to reply by email both to list and poster. I did not realize this can 
cause problems -- I'll try to reply via email client in future.

- Volodya