From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9535 invoked by alias); 17 Mar 2006 10:20:16 -0000 Received: (qmail 9526 invoked by uid 22791); 17 Mar 2006 10:20:15 -0000 X-Spam-Check-By: sourceware.org Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 17 Mar 2006 10:20:10 +0000 Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.50) id 1FKC3t-0005qa-G4 for gdb-patches@sources.redhat.com; Fri, 17 Mar 2006 13:20:06 +0300 Received: from zigzag.lvk.cs.msu.su ([158.250.17.23]) by zigzag.lvk.cs.msu.su with esmtp (Exim 4.50) id 1FKC3n-0005pC-UB; Fri, 17 Mar 2006 13:19:55 +0300 From: Vladimir Prus To: Nick Roberts Subject: Re: Remove type prefix for -var-evaluate-expression/functions Date: Fri, 17 Mar 2006 15:03:00 -0000 User-Agent: KMail/1.7.2 Cc: gdb-patches@sources.redhat.com References: <17434.35140.456146.649459@kahikatea.snap.net.nz> In-Reply-To: <17434.35140.456146.649459@kahikatea.snap.net.nz> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200603171319.55381.ghost@cs.msu.su> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00224.txt.bz2 On Friday 17 March 2006 13:02, Nick Roberts wrote: > > > > the following patch removes 'type prefix' from output of > > > > -var-evaluate-expression applied to objects of function type (not > > > > pointers to functions, but functions). > > > > > > > > It causes no regression in the testsuite for me. > > > > > > But I guess a new test would help prevent a regression (in the code) in > > > the future. > > > > Yes, can you suggest which file should I add this new testcase too? > > Well I guess mi-var-cmd.exp. Please remember that I'm not the maintainer > but just an interested party. See what Daniel says. He might want > something for mi2-var-cmd.exp too. Ok, I'll wait for his comment. > > > > > + if (TYPE_CODE (type) == TYPE_CODE_FUNC) > > > > > > This condition must always be true here (case TYPE_CODE_FUNC:). > > > > This chunk is in 'c_value_print', where there's no switch. > > Ah yes! I misread the patch. > > > I guess I'd better send the patch with "-p". It's attached, hopefully > > it's more clear. > > > > And thanks for the hint about -p! > > Hmm...yes, I guess I've proved my own point. Indeed. > PS I'm not subscribed to gdb-patches so please include me in your replies. > I think its fairly standard to do this as its more inconvenient to get no > reply, than get two and have to delete one. Apologies. In fact, I regularly use NNTP interface to read/reply gdb-patches (gmane.comp.gdb.patches newsgroup at gmane.org), and NNTP reader does not allow to reply by email both to list and poster. I did not realize this can cause problems -- I'll try to reply via email client in future. - Volodya