From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7687 invoked by alias); 5 May 2006 20:47:54 -0000 Received: (qmail 7677 invoked by uid 22791); 5 May 2006 20:47:52 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 05 May 2006 20:47:48 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1Fc7DG-0001Zz-Br; Fri, 05 May 2006 16:47:46 -0400 Date: Fri, 05 May 2006 20:47:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: Remove type prefix for -var-evaluate-expression/functions Message-ID: <20060505204746.GZ31029@nevyn.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <17434.35140.456146.649459@kahikatea.snap.net.nz> <200603171319.55381.ghost@cs.msu.su> <20060317193702.GC19068@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00106.txt.bz2 On Tue, Apr 04, 2006 at 11:18:02AM +0400, Vladimir Prus wrote: > The new version of the patch, with testsuite change, is attached. > > Changelog: > 2006-03-15 Vladimir Prus > > * c-valprint.c > (c_val_print): Don't print type prefix for functions. > (c_value_print): Print type prefix for functions here. > * testsuite/gdb.mi/mi-var-cmd.exp: Test for new behaviour. Hi Vladimir (do you prefer Volodya?), This patch is fine. Please adjust the ChangeLog entry for GNU formatting - I realize everyone else puts their asterisks in a different place than we do: * c-valprint.c (c_val_print): Don't print type prefix for functions. (c_value_print): Print type prefix for functions here. * gdb.mi/mi-var-cmd.exp: Test for printing functions. Otherwise, feel free to check it in. [You don't usually want to refer to "new behavior" in the testsuite changelog entry, because it's tricky to go back and see what commit in the gdb ChangeLog the test corresponds to. Yes, this is just CVS's fault really.] -- Daniel Jacobowitz CodeSourcery