Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: jimb@red-bean.com
Cc: brobecker@adacore.com, gdb-patches@sources.redhat.com
Subject: Re: [RFC/RFA/i386] pb reading insns if breakpoints still inserted
Date: Fri, 28 Apr 2006 21:09:00 -0000	[thread overview]
Message-ID: <200604282109.k3SL9Jwp020317@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <8f2776cb0604281358x2f667d00s90e03051f034b91c@mail.gmail.com> 	(jimb@red-bean.com)

> Date: Fri, 28 Apr 2006 13:58:39 -0700
> From: "Jim Blandy" <jimb@red-bean.com>
> 
> On 4/28/06, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
> > I don't completely disagree with you here, but, a different way to
> > view the problem is putting the blame with the fact that we (ab)use
> > the prologue analyzer for skipping the prologue when trying to place a
> > breakpoint at the start of a function, where we really should be able
> > to use the debug info for doing this.
> 
> I certainly agree that debug info is preferable to pig-nosing through
> machine code.  Perhaps there should be generic code that does what
> find_function_start_sal does, and everybody should be using that
> instead of calling SKIP_PROLOGUE directly.
> 
> But sometimes we don't have debugging information.  I had thought that
> prologue analysis was pretty much dead, given that .debug_frame does a
> much better job, and puts the problem in the hands of somebody who can
> solve it (the compiler).  But it still seems to come up fairly often.

But if we don't have debug information, what's the point in trying to
skip the prologue in order to put a breakpoint on ... eh what exactly?
Isn't it better to just punt prologue skipping in that case and place
the breakpoint on the first instruction of the code?

Mark


  reply	other threads:[~2006-04-28 21:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-28 17:12 Joel Brobecker
2006-04-28 17:54 ` Jim Blandy
2006-04-28 18:40   ` Mark Kettenis
2006-04-28 18:48     ` Joel Brobecker
2006-04-28 20:58     ` Jim Blandy
2006-04-28 21:09       ` Mark Kettenis [this message]
2006-04-28 21:13         ` Daniel Jacobowitz
2006-04-28 21:42           ` Jim Blandy
2006-04-28 21:54             ` Joel Brobecker
2006-04-28 21:49           ` Joel Brobecker
2006-04-28 22:00             ` Jim Blandy
2006-04-29 14:20 ` Eli Zaretskii
2006-04-29 14:28   ` Daniel Jacobowitz
2006-04-29 14:51     ` Eli Zaretskii
2006-04-29 15:06       ` Daniel Jacobowitz
2006-04-29 16:57         ` Eli Zaretskii
2006-04-29 23:14           ` Daniel Jacobowitz
2006-05-01 16:36 ` Mark Kettenis
2006-05-01 17:06   ` Joel Brobecker
2006-05-05 18:16   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200604282109.k3SL9Jwp020317@elgar.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@red-bean.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox