Re: [RFC/RFA/i386] pb reading insns if breakpoints still inserted

Daniel Jacobowitz
2006-04-29T15:06:02Z

On Sat, Apr 29, 2006 at 05:51:28PM +0300, Eli Zaretskii wrote:
> > Now, you could make a reasonable argument that the default when reading
> > memory ought to be to ignore breakpoints. But that would be a much
> > harder change to test; we'd need to catch all the places which do need
> > to see breakpoints
>
> We don't need to catch all of them at once, if that's hard. We can
> catch them one by one and fix them as we do.

Well, this one's been there for years. I'd rather have slightly more
confidence that we won't introduce a whole new set of such bugs...

> > I can only think of one off the top of my head, but I'm sure there
> > are more. So, I would suggest making it separately.
>
> It's fine with me, but I still don't understand why it has to be in an
> architecture-specific file, not in some more general place. Am I
> missing something?

Right now, there are many ways to read memory; two of them skip
inserted breakpoints, and the others don't. So, to fix this sort of
problem, you have to deliberately use the functions which do skip
breakpoints. Thus the change has to be at the site of the memory
read, which is in this case in a target-specific file. We don't want
to remove breakpoints before invoking the prologue analyzer; the
removal may be unnecessary if a "step" command is in progress and not
done yet.

--
Daniel Jacobowitz
CodeSourcery