From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: brobecker@adacore.com, gdb-patches@sources.redhat.com
Subject: Re: [RFC/RFA/i386] pb reading insns if breakpoints still inserted
Date: Fri, 05 May 2006 18:16:00 -0000 [thread overview]
Message-ID: <20060505181613.GJ31029@nevyn.them.org> (raw)
In-Reply-To: <200605011636.k41GaO8I027381@elgar.sibelius.xs4all.nl>
On Mon, May 01, 2006 at 06:36:24PM +0200, Mark Kettenis wrote:
> Hmm, I'm not entirely happy with the name, and I agree with jimb that
> using current_frame here doesn't make sense. I was planning to look
> into getting rid of the prologue skipper, but that isn't really going
> to solve the problems.
>
> After another day of thinking I came to the conclusion that jimb is
> probably right about the premature deprecation of memory_read_nobpt.
> If we undeprecate it, you wouldn't really need your new read_insn
> function, since it really would be the same as memory_read_nobpt.
>
> What do the other (global) maintainers think?
I see two choices.
1. Undeprecate deprecated_read_memory_nobpt. Use it.
2. Make all memory reads skip breakpoints by default, and provide a
different function which doesn't.
I think (1) is the best choice for now. (2) is going to require a lot
of poking around dark corners and testing on strange targets. I'd
recommend anyone interested start by cutting down on the number of
memory reading functions - there's quite a lot of them!
So, I'm in favor.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2006-05-05 18:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-28 17:12 Joel Brobecker
2006-04-28 17:54 ` Jim Blandy
2006-04-28 18:40 ` Mark Kettenis
2006-04-28 18:48 ` Joel Brobecker
2006-04-28 20:58 ` Jim Blandy
2006-04-28 21:09 ` Mark Kettenis
2006-04-28 21:13 ` Daniel Jacobowitz
2006-04-28 21:42 ` Jim Blandy
2006-04-28 21:54 ` Joel Brobecker
2006-04-28 21:49 ` Joel Brobecker
2006-04-28 22:00 ` Jim Blandy
2006-04-29 14:20 ` Eli Zaretskii
2006-04-29 14:28 ` Daniel Jacobowitz
2006-04-29 14:51 ` Eli Zaretskii
2006-04-29 15:06 ` Daniel Jacobowitz
2006-04-29 16:57 ` Eli Zaretskii
2006-04-29 23:14 ` Daniel Jacobowitz
2006-05-01 16:36 ` Mark Kettenis
2006-05-01 17:06 ` Joel Brobecker
2006-05-05 18:16 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060505181613.GJ31029@nevyn.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox