From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3365 invoked by alias); 5 May 2006 18:16:28 -0000 Received: (qmail 3355 invoked by uid 22791); 5 May 2006 18:16:27 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 05 May 2006 18:16:21 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1Fc4qb-0000a9-QZ; Fri, 05 May 2006 14:16:13 -0400 Date: Fri, 05 May 2006 18:16:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: brobecker@adacore.com, gdb-patches@sources.redhat.com Subject: Re: [RFC/RFA/i386] pb reading insns if breakpoints still inserted Message-ID: <20060505181613.GJ31029@nevyn.them.org> Mail-Followup-To: Mark Kettenis , brobecker@adacore.com, gdb-patches@sources.redhat.com References: <20060428171154.GP17613@adacore.com> <200605011636.k41GaO8I027381@elgar.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200605011636.k41GaO8I027381@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00076.txt.bz2 On Mon, May 01, 2006 at 06:36:24PM +0200, Mark Kettenis wrote: > Hmm, I'm not entirely happy with the name, and I agree with jimb that > using current_frame here doesn't make sense. I was planning to look > into getting rid of the prologue skipper, but that isn't really going > to solve the problems. > > After another day of thinking I came to the conclusion that jimb is > probably right about the premature deprecation of memory_read_nobpt. > If we undeprecate it, you wouldn't really need your new read_insn > function, since it really would be the same as memory_read_nobpt. > > What do the other (global) maintainers think? I see two choices. 1. Undeprecate deprecated_read_memory_nobpt. Use it. 2. Make all memory reads skip breakpoints by default, and provide a different function which doesn't. I think (1) is the best choice for now. (2) is going to require a lot of poking around dark corners and testing on strange targets. I'd recommend anyone interested start by cutting down on the number of memory reading functions - there's quite a lot of them! So, I'm in favor. -- Daniel Jacobowitz CodeSourcery