From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [RFC/RFA/i386] pb reading insns if breakpoints still inserted
Date: Sat, 29 Apr 2006 14:28:00 -0000 [thread overview]
Message-ID: <20060429142812.GA21067@nevyn.them.org> (raw)
In-Reply-To: <uejzgfop1.fsf@gnu.org>
On Sat, Apr 29, 2006 at 05:20:42PM +0300, Eli Zaretskii wrote:
> Isn't this a general problem, not limited to x86? That is, if there's
> a breakpoint inserted in the prologue, wouldn't other prologue
> analyzers be fooled?
>
> If this is indeed a general problem, I suggest we fix it in a general
> fashion, not for some specific platform.
That's why many prologue analyzers already use the memory reading
functions which ignore breakpoints; this just improves our consistency.
Now, you could make a reasonable argument that the default when reading
memory ought to be to ignore breakpoints. But that would be a much
harder change to test; we'd need to catch all the places which do need
to see breakpoints - I can only think of one off the top of my head,
but I'm sure there are more. So, I would suggest making it separately.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-04-29 14:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-28 17:12 Joel Brobecker
2006-04-28 17:54 ` Jim Blandy
2006-04-28 18:40 ` Mark Kettenis
2006-04-28 18:48 ` Joel Brobecker
2006-04-28 20:58 ` Jim Blandy
2006-04-28 21:09 ` Mark Kettenis
2006-04-28 21:13 ` Daniel Jacobowitz
2006-04-28 21:42 ` Jim Blandy
2006-04-28 21:54 ` Joel Brobecker
2006-04-28 21:49 ` Joel Brobecker
2006-04-28 22:00 ` Jim Blandy
2006-04-29 14:20 ` Eli Zaretskii
2006-04-29 14:28 ` Daniel Jacobowitz [this message]
2006-04-29 14:51 ` Eli Zaretskii
2006-04-29 15:06 ` Daniel Jacobowitz
2006-04-29 16:57 ` Eli Zaretskii
2006-04-29 23:14 ` Daniel Jacobowitz
2006-05-01 16:36 ` Mark Kettenis
2006-05-01 17:06 ` Joel Brobecker
2006-05-05 18:16 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060429142812.GA21067@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox