From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19766 invoked by alias); 29 Apr 2006 14:28:17 -0000 Received: (qmail 19753 invoked by uid 22791); 29 Apr 2006 14:28:15 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Sat, 29 Apr 2006 14:28:14 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FZqQe-0005Ua-Lm for gdb-patches@sourceware.org; Sat, 29 Apr 2006 10:28:12 -0400 Date: Sat, 29 Apr 2006 14:28:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [RFC/RFA/i386] pb reading insns if breakpoints still inserted Message-ID: <20060429142812.GA21067@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20060428171154.GP17613@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00388.txt.bz2 On Sat, Apr 29, 2006 at 05:20:42PM +0300, Eli Zaretskii wrote: > Isn't this a general problem, not limited to x86? That is, if there's > a breakpoint inserted in the prologue, wouldn't other prologue > analyzers be fooled? > > If this is indeed a general problem, I suggest we fix it in a general > fashion, not for some specific platform. That's why many prologue analyzers already use the memory reading functions which ignore breakpoints; this just improves our consistency. Now, you could make a reasonable argument that the default when reading memory ought to be to ignore breakpoints. But that would be a much harder change to test; we'd need to catch all the places which do need to see breakpoints - I can only think of one off the top of my head, but I'm sure there are more. So, I would suggest making it separately. -- Daniel Jacobowitz CodeSourcery