From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 970 invoked by alias); 28 Apr 2006 21:09:36 -0000 Received: (qmail 960 invoked by uid 22791); 28 Apr 2006 21:09:35 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 28 Apr 2006 21:09:33 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id k3SL9KHc008095; Fri, 28 Apr 2006 23:09:20 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6) with ESMTP id k3SL9JA2020210; Fri, 28 Apr 2006 23:09:19 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.6/8.13.6/Submit) id k3SL9Jwp020317; Fri, 28 Apr 2006 23:09:19 +0200 (CEST) Date: Fri, 28 Apr 2006 21:09:00 -0000 Message-Id: <200604282109.k3SL9Jwp020317@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: jimb@red-bean.com CC: brobecker@adacore.com, gdb-patches@sources.redhat.com In-reply-to: <8f2776cb0604281358x2f667d00s90e03051f034b91c@mail.gmail.com> (jimb@red-bean.com) Subject: Re: [RFC/RFA/i386] pb reading insns if breakpoints still inserted References: <20060428171154.GP17613@adacore.com> <8f2776cb0604281054y116acfdavc3649dd8198d80d0@mail.gmail.com> <200604281839.k3SIdfsq030892@elgar.sibelius.xs4all.nl> <8f2776cb0604281358x2f667d00s90e03051f034b91c@mail.gmail.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00374.txt.bz2 > Date: Fri, 28 Apr 2006 13:58:39 -0700 > From: "Jim Blandy" > > On 4/28/06, Mark Kettenis wrote: > > I don't completely disagree with you here, but, a different way to > > view the problem is putting the blame with the fact that we (ab)use > > the prologue analyzer for skipping the prologue when trying to place a > > breakpoint at the start of a function, where we really should be able > > to use the debug info for doing this. > > I certainly agree that debug info is preferable to pig-nosing through > machine code. Perhaps there should be generic code that does what > find_function_start_sal does, and everybody should be using that > instead of calling SKIP_PROLOGUE directly. > > But sometimes we don't have debugging information. I had thought that > prologue analysis was pretty much dead, given that .debug_frame does a > much better job, and puts the problem in the hands of somebody who can > solve it (the compiler). But it still seems to come up fairly often. But if we don't have debug information, what's the point in trying to skip the prologue in order to put a breakpoint on ... eh what exactly? Isn't it better to just punt prologue skipping in that case and place the breakpoint on the first instruction of the code? Mark