* [RFA] h8300-tdep.c: Rewrite frame code, de-deprecate, ...
@ 2005-04-28 15:33 Corinna Vinschen
2005-04-28 19:03 ` Daniel Jacobowitz
0 siblings, 1 reply; 7+ messages in thread
From: Corinna Vinschen @ 2005-04-28 15:33 UTC (permalink / raw)
To: gdb-patches
Hi,
the below patch is not exactly a rewrite of the h8300-tdep code, but it's
pretty similar to one. None of the deprecated stuff is left. I reworked
a lot of the code, especially the frame code and the prologue analysis.
The dwarf2 frame sniffer is also hooked in now.
I also took the freedom to add a h8300.inc to the gdb.asm testsuite.
Ok to apply?
ChangeLog:
* h8300-tdep.c: Undeprecate completely, rewrite frame code, rework
prologue analysis and prologue skipping, fix return value and
struct return handling.
testsuite/ChangeLog:
* gdb.asm/asm-source.exp: Add h8300 to supported targets.
* gdb.asm/h8300.inc: New file.
Index: h8300-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/h8300-tdep.c,v
retrieving revision 1.100
diff -u -p -r1.100 h8300-tdep.c
--- h8300-tdep.c 12 Feb 2005 10:38:50 -0000 1.100
+++ h8300-tdep.c 28 Apr 2005 15:28:18 -0000
@@ -1,7 +1,7 @@
/* Target-machine dependent code for Renesas H8/300, for GDB.
Copyright 1988, 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1998,
- 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
+ 1999, 2000, 2001, 2002, 2003, 2005 Free Software Foundation, Inc.
This file is part of GDB.
@@ -41,27 +41,6 @@
#include "frame-base.h"
#include "frame-unwind.h"
-/* Extra info which is saved in each frame_info. */
-struct frame_extra_info
-{
- CORE_ADDR from_pc;
-};
-
-enum
-{
- h8300_reg_size = 2,
- h8300h_reg_size = 4,
- h8300_max_reg_size = 4,
-};
-
-static int is_h8300hmode (struct gdbarch *gdbarch);
-static int is_h8300smode (struct gdbarch *gdbarch);
-static int is_h8300sxmode (struct gdbarch *gdbarch);
-static int is_h8300_normal_mode (struct gdbarch *gdbarch);
-
-#define BINWORD (is_h8300hmode (current_gdbarch) && \
- !is_h8300_normal_mode (current_gdbarch) ? h8300h_reg_size : h8300_reg_size)
-
enum gdb_regnum
{
E_R0_REGNUM, E_ER0_REGNUM = E_R0_REGNUM, E_ARG0_REGNUM = E_R0_REGNUM,
@@ -90,17 +69,105 @@ enum gdb_regnum
#define E_PSEUDO_CCR_REGNUM (NUM_REGS)
#define E_PSEUDO_EXR_REGNUM (NUM_REGS+1)
-#define UNSIGNED_SHORT(X) ((X) & 0xffff)
+struct h8300_frame_cache
+{
+ /* Base address. */
+ CORE_ADDR base;
+ CORE_ADDR sp_offset;
+ CORE_ADDR pc;
+
+ /* Flag showing that a frame has been created in the prologue code. */
+ int uses_fp;
+
+ /* Saved registers. */
+ CORE_ADDR saved_regs[H8300_MAX_NUM_REGS];
+ CORE_ADDR saved_sp;
+};
+
+enum
+{
+ h8300_reg_size = 2,
+ h8300h_reg_size = 4,
+ h8300_max_reg_size = 4,
+};
+
+static int is_h8300hmode (struct gdbarch *gdbarch);
+static int is_h8300smode (struct gdbarch *gdbarch);
+static int is_h8300sxmode (struct gdbarch *gdbarch);
+static int is_h8300_normal_mode (struct gdbarch *gdbarch);
+
+#define BINWORD (is_h8300hmode (current_gdbarch) && \
+ !is_h8300_normal_mode (current_gdbarch) ? h8300h_reg_size : h8300_reg_size)
+
+static CORE_ADDR
+h8300_unwind_pc (struct gdbarch *gdbarch, struct frame_info *next_frame)
+{
+ return frame_unwind_register_unsigned (next_frame, E_PC_REGNUM);
+}
-#define IS_PUSH(x) ((x & 0xfff0)==0x6df0)
-#define IS_PUSH_FP(x) (x == 0x6df6)
-#define IS_MOVE_FP(x) (x == 0x0d76 || x == 0x0ff6)
-#define IS_MOV_SP_FP(x) (x == 0x0d76 || x == 0x0ff6)
-#define IS_SUB2_SP(x) (x==0x1b87)
-#define IS_SUB4_SP(x) (x==0x1b97)
-#define IS_SUBL_SP(x) (x==0x7a37)
-#define IS_MOVK_R5(x) (x==0x7905)
-#define IS_SUB_R5SP(x) (x==0x1957)
+static CORE_ADDR
+h8300_unwind_sp (struct gdbarch *gdbarch, struct frame_info *next_frame)
+{
+ return frame_unwind_register_unsigned (next_frame, E_SP_REGNUM);
+}
+
+static struct frame_id
+h8300_unwind_dummy_id (struct gdbarch *gdbarch, struct frame_info *next_frame)
+{
+ return frame_id_build (h8300_unwind_sp (gdbarch, next_frame),
+ frame_pc_unwind (next_frame));
+}
+
+/* Normal frames. */
+
+/* Allocate and initialize a frame cache. */
+
+static void
+h8300_init_frame_cache (struct h8300_frame_cache *cache)
+{
+ int i;
+
+ /* Base address. */
+ cache->base = 0;
+ cache->sp_offset = 0;
+ cache->pc = 0;
+
+ /* Frameless until proven otherwise. */
+ cache->uses_fp = 0;
+
+ /* Saved registers. We initialize these to -1 since zero is a valid
+ offset (that's where %fp is supposed to be stored). */
+ for (i = 0; i < NUM_REGS; i++)
+ cache->saved_regs[i] = -1;
+}
+
+#define IS_MOVB_RnRm(x) (((x) & 0xff88) == 0x0c88)
+#define IS_MOVW_RnRm(x) (((x) & 0xff88) == 0x0d00)
+#define IS_MOVL_RnRm(x) (((x) & 0xff88) == 0x0f80)
+#define IS_MOVB_Rn16_SP(x) (((x) & 0xfff0) == 0x6ee0)
+#define IS_MOVB_EXT(x) ((x) == 0x7860)
+#define IS_MOVB_Rn24_SP(x) (((x) & 0xfff0) == 0x6aa0)
+#define IS_MOVW_Rn16_SP(x) (((x) & 0xfff0) == 0x6fe0)
+#define IS_MOVW_EXT(x) ((x) == 0x78e0)
+#define IS_MOVW_Rn24_SP(x) (((x) & 0xfff0) == 0x6ba0)
+/* Same instructions as mov.w, just prefixed with 0x0100 */
+#define IS_MOVL_PRE(x) ((x) == 0x0100)
+#define IS_MOVL_Rn16_SP(x) (((x) & 0xfff0) == 0x6fe0)
+#define IS_MOVL_EXT(x) ((x) == 0x78e0)
+#define IS_MOVL_Rn24_SP(x) (((x) & 0xfff0) == 0x6ba0)
+
+#define IS_PUSHFP_MOVESPFP(x) ((x) == 0x6df60d76)
+#define IS_PUSH_FP(x) ((x) == 0x01006df6)
+#define IS_MOV_SP_FP(x) ((x) == 0x0ff6)
+#define IS_SUB2_SP(x) ((x) == 0x1b87)
+#define IS_SUB4_SP(x) ((x) == 0x1b97)
+#define IS_ADD_IMM_SP(x) ((x) == 0x7a1f)
+#define IS_SUB_IMM_SP(x) ((x) == 0x7a3f)
+#define IS_SUBL4_SP(x) ((x) == 0x1acf)
+#define IS_MOV_IMM_Rn(x) (((x) & 0xfff0) == 0x7905)
+#define IS_SUB_RnSP(x) (((x) & 0xff0f) == 0x1907)
+#define IS_ADD_RnSP(x) (((x) & 0xff0f) == 0x0907)
+#define IS_PUSH(x) (((x) & 0xfff0) == 0x6df0)
/* If the instruction at PC is an argument register spill, return its
length. Otherwise, return zero.
@@ -118,27 +185,20 @@ h8300_is_argument_spill (CORE_ADDR pc)
{
int w = read_memory_unsigned_integer (pc, 2);
- if (((w & 0xff88) == 0x0c88 /* mov.b Rsl, Rdl */
- || (w & 0xff88) == 0x0d00 /* mov.w Rs, Rd */
- || (w & 0xff88) == 0x0f80) /* mov.l Rs, Rd */
+ if ((IS_MOVB_RnRm (w) || IS_MOVW_RnRm (w) || IS_MOVL_RnRm (w))
&& (w & 0x70) <= 0x20 /* Rs is R0, R1 or R2 */
&& (w & 0x7) >= 0x3 && (w & 0x7) <= 0x5) /* Rd is R3, R4 or R5 */
return 2;
- if ((w & 0xfff0) == 0x6ee0 /* mov.b Rs,@(d:16,er6) */
+ if (IS_MOVB_Rn16_SP (w)
&& 8 <= (w & 0xf) && (w & 0xf) <= 10) /* Rs is R0L, R1L, or R2L */
{
- int w2 = read_memory_integer (pc + 2, 2);
-
- /* ... and d:16 is negative. */
- if (w2 < 0)
+ if (read_memory_integer (pc + 2, 2) < 0) /* ... and d:16 is negative. */
return 4;
}
- else if (w == 0x7860)
+ else if (IS_MOVB_EXT (w))
{
- int w2 = read_memory_integer (pc + 2, 2);
-
- if ((w2 & 0xfff0) == 0x6aa0) /* mov.b Rs, @(d:24,er6) */
+ if (IS_MOVB_Rn24_SP (read_memory_unsigned_integer (pc + 2, 2)))
{
LONGEST disp = read_memory_integer (pc + 4, 4);
@@ -147,20 +207,16 @@ h8300_is_argument_spill (CORE_ADDR pc)
return 8;
}
}
- else if ((w & 0xfff0) == 0x6fe0 /* mov.w Rs,@(d:16,er6) */
+ else if (IS_MOVW_Rn16_SP (w)
&& (w & 0xf) <= 2) /* Rs is R0, R1, or R2 */
{
- int w2 = read_memory_integer (pc + 2, 2);
-
/* ... and d:16 is negative. */
- if (w2 < 0)
+ if (read_memory_integer (pc + 2, 2) < 0)
return 4;
}
- else if (w == 0x78e0)
+ else if (IS_MOVW_EXT (w))
{
- int w2 = read_memory_integer (pc + 2, 2);
-
- if ((w2 & 0xfff0) == 0x6ba0) /* mov.b Rs, @(d:24,er6) */
+ if (IS_MOVW_Rn24_SP (read_memory_unsigned_integer (pc + 2, 2)))
{
LONGEST disp = read_memory_integer (pc + 4, 4);
@@ -169,24 +225,22 @@ h8300_is_argument_spill (CORE_ADDR pc)
return 8;
}
}
- else if (w == 0x0100)
+ else if (IS_MOVL_PRE (w))
{
int w2 = read_memory_integer (pc + 2, 2);
- if ((w2 & 0xfff0) == 0x6fe0 /* mov.l Rs,@(d:16,er6) */
+ if (IS_MOVL_Rn16_SP (w2)
&& (w2 & 0xf) <= 2) /* Rs is ER0, ER1, or ER2 */
{
- int w3 = read_memory_integer (pc + 4, 2);
-
/* ... and d:16 is negative. */
- if (w3 < 0)
+ if (read_memory_integer (pc + 4, 2) < 0)
return 6;
}
- else if (w2 == 0x78e0)
+ else if (IS_MOVL_EXT (w2))
{
int w3 = read_memory_integer (pc + 4, 2);
- if ((w3 & 0xfff0) == 0x6ba0) /* mov.l Rs, @(d:24,er6) */
+ if (IS_MOVL_Rn24_SP (read_memory_integer (pc + 4, 2)))
{
LONGEST disp = read_memory_integer (pc + 6, 4);
@@ -200,297 +254,6 @@ h8300_is_argument_spill (CORE_ADDR pc)
return 0;
}
-static CORE_ADDR
-h8300_skip_prologue (CORE_ADDR start_pc)
-{
- short int w;
- int adjust = 0;
-
- /* Skip past all push and stm insns. */
- while (1)
- {
- w = read_memory_unsigned_integer (start_pc, 2);
- /* First look for push insns. */
- if (w == 0x0100 || w == 0x0110 || w == 0x0120 || w == 0x0130)
- {
- w = read_memory_unsigned_integer (start_pc + 2, 2);
- adjust = 2;
- }
-
- if (IS_PUSH (w))
- {
- start_pc += 2 + adjust;
- w = read_memory_unsigned_integer (start_pc, 2);
- continue;
- }
- adjust = 0;
- break;
- }
-
- /* Skip past a move to FP, either word or long sized */
- w = read_memory_unsigned_integer (start_pc, 2);
- if (w == 0x0100)
- {
- w = read_memory_unsigned_integer (start_pc + 2, 2);
- adjust += 2;
- }
-
- if (IS_MOVE_FP (w))
- {
- start_pc += 2 + adjust;
- w = read_memory_unsigned_integer (start_pc, 2);
- }
-
- /* Check for loading either a word constant into r5;
- long versions are handled by the SUBL_SP below. */
- if (IS_MOVK_R5 (w))
- {
- start_pc += 2;
- w = read_memory_unsigned_integer (start_pc, 2);
- }
-
- /* Now check for subtracting r5 from sp, word sized only. */
- if (IS_SUB_R5SP (w))
- {
- start_pc += 2 + adjust;
- w = read_memory_unsigned_integer (start_pc, 2);
- }
-
- /* Check for subs #2 and subs #4. */
- while (IS_SUB2_SP (w) || IS_SUB4_SP (w))
- {
- start_pc += 2 + adjust;
- w = read_memory_unsigned_integer (start_pc, 2);
- }
-
- /* Check for a 32bit subtract. */
- if (IS_SUBL_SP (w))
- start_pc += 6 + adjust;
-
- /* Skip past another possible stm insn for registers R3 to R5 (possibly used
- for register qualified arguments. */
- w = read_memory_unsigned_integer (start_pc, 2);
- /* First look for push insns. */
- if (w == 0x0110 || w == 0x0120 || w == 0x0130)
- {
- w = read_memory_unsigned_integer (start_pc + 2, 2);
- if (IS_PUSH (w) && (w & 0xf) >= 0x3 && (w & 0xf) <= 0x5)
- start_pc += 4;
- }
-
- /* Check for spilling an argument register to the stack frame.
- This could also be an initializing store from non-prologue code,
- but I don't think there's any harm in skipping that. */
- for (;;)
- {
- int spill_size = h8300_is_argument_spill (start_pc);
- if (spill_size == 0)
- break;
- start_pc += spill_size;
- }
-
- return start_pc;
-}
-
-static CORE_ADDR
-h8300_unwind_pc (struct gdbarch *gdbarch, struct frame_info *next_frame)
-{
- char buf[8];
-
- frame_unwind_register (next_frame, E_PC_REGNUM, buf);
- return extract_typed_address (buf, builtin_type_void_func_ptr);
-}
-
-static struct frame_id
-h8300_unwind_dummy_id (struct gdbarch *gdbarch, struct frame_info *next_frame)
-{
- char buf[4];
- CORE_ADDR fp;
-
- frame_unwind_register (next_frame, E_FP_REGNUM, buf);
- fp = extract_unsigned_integer (buf, 4);
-
- return frame_id_build (fp, frame_pc_unwind (next_frame));
-}
-
-struct h8300_frame_cache
-{
- /* Base address. */
- CORE_ADDR base;
- CORE_ADDR sp_offset;
- CORE_ADDR pc;
-
- /* Saved registers. */
- CORE_ADDR saved_regs[H8300_MAX_NUM_REGS];
- CORE_ADDR saved_sp;
-
- /* Stack space reserved for local variables. */
- long locals;
-};
-
-/* Normal frames. */
-
-/* Allocate and initialize a frame cache. */
-
-static struct h8300_frame_cache *
-h8300_alloc_frame_cache (void)
-{
- struct h8300_frame_cache *cache;
- int i;
-
- cache = FRAME_OBSTACK_ZALLOC (struct h8300_frame_cache);
-
- /* Base address. */
- cache->base = 0;
- cache->sp_offset = -4;
- cache->pc = 0;
-
- /* Saved registers. We initialize these to -1 since zero is a valid
- offset (that's where %fp is supposed to be stored). */
- for (i = 0; i < NUM_REGS; i++)
- cache->saved_regs[i] = -1;
-
- /* Frameless until proven otherwise. */
- cache->locals = -1;
-
- return cache;
-}
-
-/* Check whether PC points at a code that sets up a new stack frame.
- If so, it updates CACHE and returns the address of the first
- instruction after the sequence that sets removes the "hidden"
- argument from the stack or CURRENT_PC, whichever is smaller.
- Otherwise, return PC. */
-
-static CORE_ADDR
-h8300_analyze_frame_setup (CORE_ADDR pc, CORE_ADDR current_pc,
- struct h8300_frame_cache *cache)
-{
- unsigned int op;
- int subs_count;
-
- if (pc >= current_pc)
- return current_pc;
-
- op = read_memory_unsigned_integer (pc, 4);
-
- if (op == 0x6df60d76)
- {
- /* mov.w r6,@-sp; mov.w sp,r6 */
- cache->saved_regs[E_FP_REGNUM] = 0;
- cache->sp_offset += 2;
- op = read_memory_unsigned_integer (pc + 4, 4);
- if (((op >> 16) & 0xfff0) == 0x7900)
- {
- /* mov.w #imm,rN */
- cache->locals = -(short) (op & 0xffff);
- return pc + 8;
- }
- else if ((op >> 16) == 0x1b87)
- {
- /* subs #2,sp */
- for (cache->locals = 0, pc += 4;
- read_memory_unsigned_integer (pc, 2) == 0x1b87;
- pc += 2, cache->locals += 2);
- return pc;
- }
- }
- else if (op == 0x01006df6)
- {
- /* mov.l er6,@-sp */
- op = read_memory_unsigned_integer (pc + 4, 2);
- if (op == 0x0ff6)
- {
- /* mov.l sp,er6 */
- op = read_memory_unsigned_integer (pc + 6, 2);
- if (op == 0x7a17)
- {
- /* add.l #-n,sp */
- cache->locals = -read_memory_unsigned_integer (pc + 8, 4);
- return pc + 12;
- }
- else if (op == 0x1b97)
- {
- /* subs #4,sp */
- for (cache->locals = 0, pc += 6;
- read_memory_unsigned_integer (pc, 2) == 0x1b97;
- pc += 2, cache->locals += 2);
- return pc;
- }
- }
- }
-
- return pc;
-}
-
-/* Check whether PC points at code that saves registers on the stack.
- If so, it updates CACHE and returns the address of the first
- instruction after the register saves or CURRENT_PC, whichever is
- smaller. Otherwise, return PC. */
-
-static CORE_ADDR
-h8300_analyze_register_saves (CORE_ADDR pc, CORE_ADDR current_pc,
- struct h8300_frame_cache *cache)
-{
- if (cache->locals >= 0)
- {
- CORE_ADDR offset;
- int op;
- int i, regno;
-
- offset = -cache->locals;
- while (pc < current_pc)
- {
- op = read_memory_unsigned_integer (pc, 2);
- if ((op & 0xfff0) == 0x6df0)
- {
- /* mov.w rN,@-sp */
- regno = op & 0x000f;
- cache->saved_regs[regno] = offset;
- offset -= 2;
- pc += 2;
- }
- else if (op == 0x0100)
- {
- op = read_memory_unsigned_integer (pc + 2, 2);
- if ((op & 0xfff0) == 0x6df0)
- {
- /* mov.l erN,@-sp */
- regno = op & 0x000f;
- cache->saved_regs[regno] = offset;
- offset -= 4;
- pc += 4;
- }
- else
- break;
- }
- else if ((op & 0xffcf) == 0x0100)
- {
- int op1;
- op1 = read_memory_unsigned_integer (pc + 2, 2);
- if ((op1 & 0xfff0) == 0x6df0)
- {
- /* stm.l reglist,@-sp */
- i = ((op & 0x0030) >> 4) + 1;
- regno = op1 & 0x000f;
- for (; i > 0; regno++, --i)
- {
- cache->saved_regs[regno] = offset;
- offset -= 4;
- }
- pc += 4;
- }
- else
- break;
- }
- else
- break;
- }
- }
- return pc;
-}
-
-
/* Do a full analysis of the prologue at PC and update CACHE
accordingly. Bail out early if CURRENT_PC is reached. Return the
address where the analysis stopped.
@@ -524,10 +287,6 @@ h8300_analyze_register_saves (CORE_ADDR
mov.l erN,@-sp
stm.l reglist,@-sp
- For setting up the PIC register:
-
- Future equivalence...
-
*/
static CORE_ADDR
@@ -535,13 +294,135 @@ h8300_analyze_prologue (CORE_ADDR pc, CO
struct h8300_frame_cache *cache)
{
unsigned int op;
+ int regno, i, spill_size;
+
+ /* For frameless frames, %pc is stored at 0(%fp). */
+ //cache->saved_regs[E_PC_REGNUM] = 0;
+ cache->sp_offset = 0;
- pc = h8300_analyze_frame_setup (pc, current_pc, cache);
- pc = h8300_analyze_register_saves (pc, current_pc, cache);
if (pc >= current_pc)
return current_pc;
- /* PIC support */
+ op = read_memory_unsigned_integer (pc, 4);
+
+ if (IS_PUSHFP_MOVESPFP (op))
+ {
+ cache->saved_regs[E_FP_REGNUM] = 0;
+ //cache->saved_regs[E_PC_REGNUM] = -2;
+ cache->uses_fp = 1;
+ pc += 4;
+ }
+ else if (IS_PUSH_FP (op))
+ {
+ cache->saved_regs[E_FP_REGNUM] = 0;
+ pc += 4;
+ if (pc >= current_pc)
+ return current_pc;
+ op = read_memory_unsigned_integer (pc, 2);
+ if (IS_MOV_SP_FP (op))
+ {
+ //cache->saved_regs[E_PC_REGNUM] = -4;
+ cache->uses_fp = 1;
+ pc += 2;
+ }
+ }
+
+ while (pc < current_pc)
+ {
+ op = read_memory_unsigned_integer (pc, 2);
+ if (IS_SUB2_SP (op))
+ {
+ cache->sp_offset += 2;
+ pc += 2;
+ }
+ else if (IS_SUB4_SP (op))
+ {
+ cache->sp_offset += 4;
+ pc += 2;
+ }
+ else if (IS_ADD_IMM_SP (op))
+ {
+ cache->sp_offset += -read_memory_integer (pc + 2, 2);
+ pc += 4;
+ }
+ else if (IS_SUB_IMM_SP (op))
+ {
+ cache->sp_offset += read_memory_integer (pc + 2, 2);
+ pc += 4;
+ }
+ else if (IS_SUBL4_SP (op))
+ {
+ cache->sp_offset += 4;
+ pc += 2;
+ }
+ else if (IS_MOV_IMM_Rn (op))
+ {
+ int offset = read_memory_integer (pc + 2, 2);
+ regno = op & 0x000f;
+ op = read_memory_unsigned_integer (pc + 4, 2);
+ if (IS_ADD_RnSP (op) && (op & 0x00f0) == regno)
+ {
+ cache->sp_offset -= offset;
+ pc += 6;
+ }
+ else if (IS_SUB_RnSP (op) && (op & 0x00f0) == regno)
+ {
+ cache->sp_offset += offset;
+ pc += 6;
+ }
+ else
+ break;
+ }
+ else if (IS_PUSH (op))
+ {
+ regno = op & 0x000f;
+ cache->sp_offset += 2;
+ cache->saved_regs[regno] = cache->sp_offset;
+ pc += 2;
+ }
+ else if (op == 0x0100)
+ {
+ op = read_memory_unsigned_integer (pc + 2, 2);
+ if (IS_PUSH (op))
+ {
+ regno = op & 0x000f;
+ cache->sp_offset += 4;
+ cache->saved_regs[regno] = cache->sp_offset;
+ pc += 4;
+ }
+ else
+ break;
+ }
+ else if ((op & 0xffcf) == 0x0100)
+ {
+ int op1;
+ op1 = read_memory_unsigned_integer (pc + 2, 2);
+ if (IS_PUSH (op1))
+ {
+ /* Since the prefix is 0x01x0, this is not a simple pushm but a
+ stm.l reglist,@-sp */
+ i = ((op & 0x0030) >> 4) + 1;
+ regno = op1 & 0x000f;
+ for (; i > 0; regno++, --i)
+ {
+ cache->sp_offset += 4;
+ cache->saved_regs[regno] = cache->sp_offset;
+ }
+ pc += 4;
+ }
+ else
+ break;
+ }
+ else
+ break;
+ }
+
+ /* Check for spilling an argument register to the stack frame.
+ This could also be an initializing store from non-prologue code,
+ but I don't think there's any harm in skipping that. */
+ while ((spill_size = h8300_is_argument_spill (pc)) > 0
+ && pc + spill_size <= current_pc)
+ pc += spill_size;
return pc;
}
@@ -552,35 +433,33 @@ h8300_frame_cache (struct frame_info *ne
struct h8300_frame_cache *cache;
char buf[4];
int i;
+ CORE_ADDR current_pc;
if (*this_cache)
return *this_cache;
- cache = h8300_alloc_frame_cache ();
+ cache = FRAME_OBSTACK_ZALLOC (struct h8300_frame_cache);
+ h8300_init_frame_cache (cache);
*this_cache = cache;
/* In principle, for normal frames, %fp holds the frame pointer,
which holds the base address for the current stack frame.
However, for functions that don't need it, the frame pointer is
optional. For these "frameless" functions the frame pointer is
- actually the frame pointer of the calling frame. Signal
- trampolines are just a special case of a "frameless" function.
- They (usually) share their frame pointer with the frame that was
- in progress when the signal occurred. */
+ actually the frame pointer of the calling frame. */
- frame_unwind_register (next_frame, E_FP_REGNUM, buf);
- cache->base = extract_unsigned_integer (buf, 4);
+ cache->base = frame_unwind_register_unsigned (next_frame, E_FP_REGNUM);
if (cache->base == 0)
return cache;
- /* For normal frames, %pc is stored at 4(%fp). */
- cache->saved_regs[E_PC_REGNUM] = 4;
+ cache->saved_regs[E_PC_REGNUM] = -BINWORD;
cache->pc = frame_func_unwind (next_frame);
+ current_pc = frame_pc_unwind (next_frame);
if (cache->pc != 0)
- h8300_analyze_prologue (cache->pc, frame_pc_unwind (next_frame), cache);
+ h8300_analyze_prologue (cache->pc, current_pc, cache);
- if (cache->locals < 0)
+ if (!cache->uses_fp)
{
/* We didn't find a valid frame, which means that CACHE->base
currently holds the frame pointer for our calling frame. If
@@ -590,19 +469,22 @@ h8300_frame_cache (struct frame_info *ne
frame by looking at the stack pointer. For truly "frameless"
functions this might work too. */
- frame_unwind_register (next_frame, E_SP_REGNUM, buf);
- cache->base = extract_unsigned_integer (buf, 4) + cache->sp_offset;
+ cache->base = frame_unwind_register_unsigned (next_frame, E_SP_REGNUM)
+ + cache->sp_offset;
+ cache->saved_sp = cache->base + BINWORD;
+ cache->saved_regs[E_PC_REGNUM] = 0;
+ }
+ else
+ {
+ cache->saved_sp = cache->base + 2 * BINWORD;
+ cache->saved_regs[E_PC_REGNUM] = -BINWORD;
}
-
- /* Now that we have the base address for the stack frame we can
- calculate the value of %sp in the calling frame. */
- cache->saved_sp = cache->base;
/* Adjust all the saved registers such that they contain addresses
instead of offsets. */
for (i = 0; i < NUM_REGS; i++)
if (cache->saved_regs[i] != -1)
- cache->saved_regs[i] += cache->base;
+ cache->saved_regs[i] = cache->base - cache->saved_regs[i];
return cache;
}
@@ -618,8 +500,7 @@ h8300_frame_this_id (struct frame_info *
if (cache->base == 0)
return;
- /* See the end of m68k_push_dummy_call. */
- *this_id = frame_id_build (cache->base, cache->pc);
+ *this_id = frame_id_build (cache->saved_sp, cache->pc);
}
static void
@@ -640,10 +521,7 @@ h8300_frame_prev_register (struct frame_
*addrp = 0;
*realnump = -1;
if (valuep)
- {
- /* Store the value. */
- store_unsigned_integer (valuep, 4, cache->saved_sp);
- }
+ store_unsigned_integer (valuep, BINWORD, cache->saved_sp);
return;
}
@@ -654,11 +532,7 @@ h8300_frame_prev_register (struct frame_
*addrp = cache->saved_regs[regnum];
*realnump = -1;
if (valuep)
- {
- /* Read the value in from memory. */
- read_memory (*addrp, valuep,
- register_size (current_gdbarch, regnum));
- }
+ read_memory (*addrp, valuep, register_size (current_gdbarch, regnum));
return;
}
@@ -678,6 +552,45 @@ h8300_frame_sniffer (struct frame_info *
return &h8300_frame_unwind;
}
+static CORE_ADDR
+h8300_frame_base_address (struct frame_info *next_frame, void **this_cache)
+{
+ struct h8300_frame_cache *cache = h8300_frame_cache (next_frame, this_cache);
+ return cache->base;
+}
+
+static const struct frame_base h8300_frame_base = {
+ &h8300_frame_unwind,
+ h8300_frame_base_address,
+ h8300_frame_base_address,
+ h8300_frame_base_address
+};
+
+static CORE_ADDR
+h8300_skip_prologue (CORE_ADDR pc)
+{
+ CORE_ADDR func_addr = 0 , func_end = 0;
+
+ if (find_pc_partial_function (pc, NULL, &func_addr, &func_end))
+ {
+ struct symtab_and_line sal;
+ struct h8300_frame_cache cache;
+
+ /* Found a function. */
+ sal = find_pc_line (func_addr, 0);
+ if (sal.end && sal.end < func_end)
+ /* Found a line number, use it as end of prologue. */
+ return sal.end;
+
+ /* No useable line symbol. Use prologue parsing method. */
+ h8300_init_frame_cache (&cache);
+ return h8300_analyze_prologue (func_addr, func_end, &cache);
+ }
+
+ /* No function symbol -- just return the PC. */
+ return (CORE_ADDR) pc;
+}
+
/* Function: push_dummy_call
Setup the function arguments for calling a function in the inferior.
In this discussion, a `word' is 16 bits on the H8/300s, and 32 bits
@@ -748,6 +661,7 @@ h8300_push_dummy_call (struct gdbarch *g
int nargs, struct value **args, CORE_ADDR sp,
int struct_return, CORE_ADDR struct_addr)
{
+ CORE_ADDR old_sp = sp;
int stack_alloc = 0, stack_offset = 0;
int wordsize = BINWORD;
int reg = E_ARG0_REGNUM;
@@ -836,7 +750,9 @@ h8300_push_dummy_call (struct gdbarch *g
/* Update stack pointer. */
regcache_cooked_write_unsigned (regcache, E_SP_REGNUM, sp);
- return sp;
+ /* Return the new stack pointer minus the return address slot since
+ that's what DWARF2/GCC uses as the frame's CFA. */
+ return sp + wordsize;
}
/* Function: extract_return_value
@@ -896,9 +812,10 @@ h8300h_extract_return_value (struct type
case 8: /* long long is now 8 bytes. */
if (TYPE_CODE (type) == TYPE_CODE_INT)
{
- regcache_cooked_read_unsigned (regcache, E_RET0_REGNUM, &addr);
- c = read_memory_unsigned_integer ((CORE_ADDR) addr, len);
- store_unsigned_integer (valbuf, len, c);
+ regcache_cooked_read_unsigned (regcache, E_RET0_REGNUM, &c);
+ store_unsigned_integer (valbuf, 4, c);
+ regcache_cooked_read_unsigned (regcache, E_RET1_REGNUM, &c);
+ store_unsigned_integer ((void *) ((char *) valbuf + 4), 4, c);
}
else
{
@@ -908,6 +825,34 @@ h8300h_extract_return_value (struct type
}
}
+int
+h8300_use_struct_convention (struct type *value_type)
+{
+ /* Types of 1, 2 or 4 bytes are returned in R0/R1, everything else on the
+ stack. */
+
+ if (TYPE_CODE (value_type) == TYPE_CODE_STRUCT
+ || TYPE_CODE (value_type) == TYPE_CODE_UNION)
+ return 1;
+ return !(TYPE_LENGTH (value_type) == 1
+ || TYPE_LENGTH (value_type) == 2
+ || TYPE_LENGTH (value_type) == 4);
+}
+
+int
+h8300h_use_struct_convention (struct type *value_type)
+{
+ /* Types of 1, 2 or 4 bytes are returned in R0, INT types of 8 bytes are
+ returned in R0/R1, everything else on the stack. */
+ if (TYPE_CODE (value_type) == TYPE_CODE_STRUCT
+ || TYPE_CODE (value_type) == TYPE_CODE_UNION)
+ return 1;
+ return !(TYPE_LENGTH (value_type) == 1
+ || TYPE_LENGTH (value_type) == 2
+ || TYPE_LENGTH (value_type) == 4
+ || (TYPE_LENGTH (value_type) == 8
+ && TYPE_CODE (value_type) == TYPE_CODE_INT));
+}
/* Function: store_return_value
Place the appropriate value in the appropriate registers.
@@ -955,11 +900,52 @@ h8300h_store_return_value (struct type *
val = extract_unsigned_integer (valbuf, len);
regcache_cooked_write_unsigned (regcache, E_RET0_REGNUM, val);
break;
- case 8: /* long long, double and long double are all defined
- as 4 byte types so far so this shouldn't happen. */
- error ("I don't know how to return an 8 byte value.");
+ case 8:
+ val = extract_unsigned_integer (valbuf, len);
+ regcache_cooked_write_unsigned (regcache, E_RET0_REGNUM,
+ (val >> 32) & 0xffffffff);
+ regcache_cooked_write_unsigned (regcache, E_RET1_REGNUM, val & 0xffffffff);
break;
+ break;
+ }
+}
+
+static enum return_value_convention
+h8300_return_value (struct gdbarch *gdbarch, struct type *type,
+ struct regcache *regcache,
+ void *readbuf, const void *writebuf)
+{
+ if (h8300_use_struct_convention (type))
+ return RETURN_VALUE_STRUCT_CONVENTION;
+ if (writebuf)
+ h8300_store_return_value (type, regcache, writebuf);
+ else if (readbuf)
+ h8300_extract_return_value (type, regcache, readbuf);
+ return RETURN_VALUE_REGISTER_CONVENTION;
+}
+
+static enum return_value_convention
+h8300h_return_value (struct gdbarch *gdbarch, struct type *type,
+ struct regcache *regcache,
+ void *readbuf, const void *writebuf)
+{
+ if (h8300h_use_struct_convention (type))
+ {
+ if (readbuf)
+ {
+ ULONGEST addr;
+
+ regcache_raw_read_unsigned (regcache, E_R0_REGNUM, &addr);
+ read_memory (addr, readbuf, TYPE_LENGTH (type));
+ }
+
+ return RETURN_VALUE_ABI_RETURNS_ADDRESS;
}
+ if (writebuf)
+ h8300h_store_return_value (type, regcache, writebuf);
+ else if (readbuf)
+ h8300h_extract_return_value (type, regcache, readbuf);
+ return RETURN_VALUE_REGISTER_CONVENTION;
}
static struct cmd_list_element *setmachinelist;
@@ -1208,14 +1194,6 @@ h8300s_dbg_reg_to_regnum (int regno)
return regno;
}
-static CORE_ADDR
-h8300_extract_struct_value_address (struct regcache *regcache)
-{
- ULONGEST addr;
- regcache_cooked_read_unsigned (regcache, E_RET0_REGNUM, &addr);
- return addr;
-}
-
const static unsigned char *
h8300_breakpoint_from_pc (CORE_ADDR *pcptr, int *lenptr)
{
@@ -1226,22 +1204,6 @@ h8300_breakpoint_from_pc (CORE_ADDR *pcp
return breakpoint;
}
-static CORE_ADDR
-h8300_push_dummy_code (struct gdbarch *gdbarch,
- CORE_ADDR sp, CORE_ADDR funaddr, int using_gcc,
- struct value **args, int nargs,
- struct type *value_type,
- CORE_ADDR *real_pc, CORE_ADDR *bp_addr)
-{
- /* Allocate space sufficient for a breakpoint. */
- sp = (sp - 2) & ~1;
- /* Store the address of that breakpoint */
- *bp_addr = sp;
- /* h8300 always starts the call at the callee's entry point. */
- *real_pc = funaddr;
- return sp;
-}
-
static void
h8300_print_float_info (struct gdbarch *gdbarch, struct ui_file *file,
struct frame_info *frame, const char *args)
@@ -1281,8 +1243,7 @@ h8300_gdbarch_init (struct gdbarch_info
set_gdbarch_register_name (gdbarch, h8300_register_name);
set_gdbarch_ptr_bit (gdbarch, 2 * TARGET_CHAR_BIT);
set_gdbarch_addr_bit (gdbarch, 2 * TARGET_CHAR_BIT);
- set_gdbarch_extract_return_value (gdbarch, h8300_extract_return_value);
- set_gdbarch_store_return_value (gdbarch, h8300_store_return_value);
+ set_gdbarch_return_value (gdbarch, h8300_return_value);
set_gdbarch_print_insn (gdbarch, print_insn_h8300);
break;
case bfd_mach_h8300h:
@@ -1304,8 +1265,7 @@ h8300_gdbarch_init (struct gdbarch_info
set_gdbarch_ptr_bit (gdbarch, 2 * TARGET_CHAR_BIT);
set_gdbarch_addr_bit (gdbarch, 2 * TARGET_CHAR_BIT);
}
- set_gdbarch_extract_return_value (gdbarch, h8300h_extract_return_value);
- set_gdbarch_store_return_value (gdbarch, h8300h_store_return_value);
+ set_gdbarch_return_value (gdbarch, h8300h_return_value);
set_gdbarch_print_insn (gdbarch, print_insn_h8300h);
break;
case bfd_mach_h8300s:
@@ -1327,8 +1287,7 @@ h8300_gdbarch_init (struct gdbarch_info
set_gdbarch_ptr_bit (gdbarch, 2 * TARGET_CHAR_BIT);
set_gdbarch_addr_bit (gdbarch, 2 * TARGET_CHAR_BIT);
}
- set_gdbarch_extract_return_value (gdbarch, h8300h_extract_return_value);
- set_gdbarch_store_return_value (gdbarch, h8300h_store_return_value);
+ set_gdbarch_return_value (gdbarch, h8300h_return_value);
set_gdbarch_print_insn (gdbarch, print_insn_h8300s);
break;
case bfd_mach_h8300sx:
@@ -1350,8 +1309,7 @@ h8300_gdbarch_init (struct gdbarch_info
set_gdbarch_ptr_bit (gdbarch, 2 * TARGET_CHAR_BIT);
set_gdbarch_addr_bit (gdbarch, 2 * TARGET_CHAR_BIT);
}
- set_gdbarch_extract_return_value (gdbarch, h8300h_extract_return_value);
- set_gdbarch_store_return_value (gdbarch, h8300h_store_return_value);
+ set_gdbarch_return_value (gdbarch, h8300h_return_value);
set_gdbarch_print_insn (gdbarch, print_insn_h8300s);
break;
}
@@ -1364,7 +1322,6 @@ h8300_gdbarch_init (struct gdbarch_info
*/
set_gdbarch_sp_regnum (gdbarch, E_SP_REGNUM);
- set_gdbarch_deprecated_fp_regnum (gdbarch, E_FP_REGNUM);
set_gdbarch_pc_regnum (gdbarch, E_PC_REGNUM);
set_gdbarch_register_type (gdbarch, h8300_register_type);
set_gdbarch_print_registers_info (gdbarch, h8300_print_registers_info);
@@ -1376,11 +1333,10 @@ h8300_gdbarch_init (struct gdbarch_info
set_gdbarch_skip_prologue (gdbarch, h8300_skip_prologue);
/* Frame unwinder. */
- set_gdbarch_unwind_dummy_id (gdbarch, h8300_unwind_dummy_id);
set_gdbarch_unwind_pc (gdbarch, h8300_unwind_pc);
-
- /* Hook in the DWARF CFI frame unwinder. */
- frame_unwind_append_sniffer (gdbarch, dwarf2_frame_sniffer);
+ set_gdbarch_unwind_sp (gdbarch, h8300_unwind_sp);
+ set_gdbarch_unwind_dummy_id (gdbarch, h8300_unwind_dummy_id);
+ frame_base_set_default (gdbarch, &h8300_frame_base);
/*
* Miscelany
@@ -1388,14 +1344,10 @@ h8300_gdbarch_init (struct gdbarch_info
/* Stack grows up. */
set_gdbarch_inner_than (gdbarch, core_addr_lessthan);
- set_gdbarch_deprecated_extract_struct_value_address (gdbarch,
- h8300_extract_struct_value_address);
- set_gdbarch_deprecated_use_struct_convention (gdbarch,
- always_use_struct_convention);
set_gdbarch_breakpoint_from_pc (gdbarch, h8300_breakpoint_from_pc);
- set_gdbarch_push_dummy_code (gdbarch, h8300_push_dummy_code);
set_gdbarch_push_dummy_call (gdbarch, h8300_push_dummy_call);
+ set_gdbarch_char_signed (gdbarch, 0);
set_gdbarch_int_bit (gdbarch, 2 * TARGET_CHAR_BIT);
set_gdbarch_long_bit (gdbarch, 4 * TARGET_CHAR_BIT);
set_gdbarch_long_long_bit (gdbarch, 8 * TARGET_CHAR_BIT);
@@ -1404,9 +1356,8 @@ h8300_gdbarch_init (struct gdbarch_info
set_gdbarch_believe_pcc_promotion (gdbarch, 1);
- /* Char is unsigned. */
- set_gdbarch_char_signed (gdbarch, 0);
-
+ /* Hook in the DWARF CFI frame unwinder. */
+ frame_unwind_append_sniffer (gdbarch, dwarf2_frame_sniffer);
frame_unwind_append_sniffer (gdbarch, h8300_frame_sniffer);
return gdbarch;
Index: testsuite/gdb.asm/asm-source.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
retrieving revision 1.55
diff -u -p -r1.55 asm-source.exp
--- testsuite/gdb.asm/asm-source.exp 8 Mar 2005 08:59:16 -0000 1.55
+++ testsuite/gdb.asm/asm-source.exp 28 Apr 2005 15:28:18 -0000
@@ -92,7 +92,12 @@ switch -glob -- [istarget] {
"powerpc*-*" {
set asm-arch powerpc
}
- "sh*-*-*" {
+ "sh64-*-*" {
+ set asm-arch sh64
+ set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}"
+ set debug-flags "-gdwarf-2"
+ }
+ "sh-*-*" {
set asm-arch sh
set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}"
set debug-flags "-gdwarf-2"
@@ -130,6 +135,10 @@ switch -glob -- [istarget] {
set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}"
set debug-flags "-gdwarf-2"
}
+ "h83*-*" {
+ set asm-arch h8300
+ set asm-flags "-gdwarf2 -I${srcdir}/${subdir} -I${objdir}/${subdir}"
+ }
}
if { "${asm-arch}" == "" } {
Index: testsuite/gdb.asm/h8300.inc
===================================================================
RCS file: testsuite/gdb.asm/h8300.inc
diff -N testsuite/gdb.asm/h8300.inc
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ testsuite/gdb.asm/h8300.inc 28 Apr 2005 15:28:18 -0000
@@ -0,0 +1,50 @@
+ comment "subroutine prologue"
+ .macro gdbasm_enter
+ mov.w r6,@-r7
+ mov.w r7,r6
+ subs #2,r7
+ .endm
+
+ comment "subroutine epilogue"
+ .macro gdbasm_leave
+ adds #2,r7
+ mov.w @r7+,r6
+ rts
+ .endm
+
+ .macro gdbasm_call subr
+ jsr @\subr
+ .endm
+
+ .macro gdbasm_several_nops
+ nop
+ nop
+ nop
+ nop
+ .endm
+
+ comment "exit (0)"
+ .macro gdbasm_exit0
+ mov.w #0xdead,r1
+ mov.w #0xbeef,r2
+ mov.w #0,r0
+ sleep
+ .endm
+
+ comment "crt0 startup"
+ .macro gdbasm_startup
+ .section .stack
+_stack: .long 1
+ .section .text
+ .global _start
+_start:
+ mov.w #0,r6
+ mov.w #_stack,sp ; or mov.l #_stack,sp
+ mov.w #_edata,r0
+ mov.w #_end,r1
+ sub.w r2,r2
+.loop: mov.w r2,@r0
+ adds #2,r0
+ cmp r1,r0
+ blo .loop
+ .endm
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat, Inc.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFA] h8300-tdep.c: Rewrite frame code, de-deprecate, ...
2005-04-28 15:33 [RFA] h8300-tdep.c: Rewrite frame code, de-deprecate, Corinna Vinschen
@ 2005-04-28 19:03 ` Daniel Jacobowitz
2005-04-29 9:11 ` Corinna Vinschen
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Jacobowitz @ 2005-04-28 19:03 UTC (permalink / raw)
To: gdb-patches
On Thu, Apr 28, 2005 at 05:32:32PM +0200, Corinna Vinschen wrote:
> Hi,
>
> the below patch is not exactly a rewrite of the h8300-tdep code, but it's
> pretty similar to one. None of the deprecated stuff is left. I reworked
> a lot of the code, especially the frame code and the prologue analysis.
> The dwarf2 frame sniffer is also hooked in now.
>
> I also took the freedom to add a h8300.inc to the gdb.asm testsuite.
>
>
> Ok to apply?
It looks generally sane, but there are a couple of minor issues.
> ChangeLog:
>
> * h8300-tdep.c: Undeprecate completely, rewrite frame code, rework
> prologue analysis and prologue skipping, fix return value and
> struct return handling.
I know it's a pain, but please write a real changelog entry.
> @@ -90,17 +69,105 @@ enum gdb_regnum
> #define E_PSEUDO_CCR_REGNUM (NUM_REGS)
> #define E_PSEUDO_EXR_REGNUM (NUM_REGS+1)
>
> -#define UNSIGNED_SHORT(X) ((X) & 0xffff)
> +struct h8300_frame_cache
> +{
> + /* Base address. */
> + CORE_ADDR base;
> + CORE_ADDR sp_offset;
> + CORE_ADDR pc;
> +
> + /* Flag showing that a frame has been created in the prologue code. */
> + int uses_fp;
> +
> + /* Saved registers. */
> + CORE_ADDR saved_regs[H8300_MAX_NUM_REGS];
> + CORE_ADDR saved_sp;
> +};
Can you use trad-frame.h instead of an array of CORE_ADDRs?
> +#define BINWORD (is_h8300hmode (current_gdbarch) && \
> + !is_h8300_normal_mode (current_gdbarch) ? h8300h_reg_size : h8300_reg_size)
You're just moving this around in the file, but while you're touching
it, please fix the formatting. && on the new line.
> @@ -535,13 +294,135 @@ h8300_analyze_prologue (CORE_ADDR pc, CO
> struct h8300_frame_cache *cache)
> {
> unsigned int op;
> + int regno, i, spill_size;
> +
> + /* For frameless frames, %pc is stored at 0(%fp). */
> + //cache->saved_regs[E_PC_REGNUM] = 0;
> + cache->sp_offset = 0;
Probably meant to delete the comment and commented out line?
> +static CORE_ADDR
> +h8300_skip_prologue (CORE_ADDR pc)
> +{
> + CORE_ADDR func_addr = 0 , func_end = 0;
> +
> + if (find_pc_partial_function (pc, NULL, &func_addr, &func_end))
> + {
> + struct symtab_and_line sal;
> + struct h8300_frame_cache cache;
> +
> + /* Found a function. */
> + sal = find_pc_line (func_addr, 0);
> + if (sal.end && sal.end < func_end)
> + /* Found a line number, use it as end of prologue. */
> + return sal.end;
> +
> + /* No useable line symbol. Use prologue parsing method. */
> + h8300_init_frame_cache (&cache);
> + return h8300_analyze_prologue (func_addr, func_end, &cache);
> + }
> +
> + /* No function symbol -- just return the PC. */
> + return (CORE_ADDR) pc;
> +}
> +
Hmm, exactly the same as the iq2000's. At least it's consistent if I
ever get around to fixing the other one :-)
> @@ -955,11 +900,52 @@ h8300h_store_return_value (struct type *
> val = extract_unsigned_integer (valbuf, len);
> regcache_cooked_write_unsigned (regcache, E_RET0_REGNUM, val);
> break;
> - case 8: /* long long, double and long double are all defined
> - as 4 byte types so far so this shouldn't happen. */
> - error ("I don't know how to return an 8 byte value.");
> + case 8:
> + val = extract_unsigned_integer (valbuf, len);
> + regcache_cooked_write_unsigned (regcache, E_RET0_REGNUM,
> + (val >> 32) & 0xffffffff);
> + regcache_cooked_write_unsigned (regcache, E_RET1_REGNUM, val & 0xffffffff);
> break;
> + break;
> + }
> +}
Spare "break" there.
> Index: testsuite/gdb.asm/asm-source.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
> retrieving revision 1.55
> diff -u -p -r1.55 asm-source.exp
> --- testsuite/gdb.asm/asm-source.exp 8 Mar 2005 08:59:16 -0000 1.55
> +++ testsuite/gdb.asm/asm-source.exp 28 Apr 2005 15:28:18 -0000
> @@ -92,7 +92,12 @@ switch -glob -- [istarget] {
> "powerpc*-*" {
> set asm-arch powerpc
> }
> - "sh*-*-*" {
> + "sh64-*-*" {
> + set asm-arch sh64
> + set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}"
> + set debug-flags "-gdwarf-2"
> + }
> + "sh-*-*" {
> set asm-arch sh
> set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}"
> set debug-flags "-gdwarf-2"
That looks like a different patch.
--
Daniel Jacobowitz
CodeSourcery, LLC
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFA] h8300-tdep.c: Rewrite frame code, de-deprecate, ...
2005-04-28 19:03 ` Daniel Jacobowitz
@ 2005-04-29 9:11 ` Corinna Vinschen
2005-04-29 13:35 ` Daniel Jacobowitz
0 siblings, 1 reply; 7+ messages in thread
From: Corinna Vinschen @ 2005-04-29 9:11 UTC (permalink / raw)
To: gdb-patches
On Apr 28 15:03, Daniel Jacobowitz wrote:
> On Thu, Apr 28, 2005 at 05:32:32PM +0200, Corinna Vinschen wrote:
>
> I know it's a pain, but please write a real changelog entry.
Sigh, ok, see below.
> > + /* Saved registers. */
> > + CORE_ADDR saved_regs[H8300_MAX_NUM_REGS];
> > + CORE_ADDR saved_sp;
> > +};
>
> Can you use trad-frame.h instead of an array of CORE_ADDRs?
I rather would not. Using the saved_regs technique is used throughout
GDB in a couple of targets and I really don't see any advantage in using
trad-frame.h. Actually IMHO using saved_regs directly is a lot easier
to read for people examining the code.
> > +#define BINWORD (is_h8300hmode (current_gdbarch) && \
> > + !is_h8300_normal_mode (current_gdbarch) ? h8300h_reg_size : h8300_reg_size)
>
> You're just moving this around in the file, but while you're touching
> it, please fix the formatting. && on the new line.
Right you are. I fixed formatting in the below patch.
> > + /* For frameless frames, %pc is stored at 0(%fp). */
> > + //cache->saved_regs[E_PC_REGNUM] = 0;
> > + cache->sp_offset = 0;
>
> Probably meant to delete the comment and commented out line?
Urgh, not only this one. I've deleted two or three more of them.
> > +h8300_skip_prologue (CORE_ADDR pc)
>
> Hmm, exactly the same as the iq2000's. At least it's consistent if I
> ever get around to fixing the other one :-)
Actually this skip_prologue code seems to turn out to be rather general.
What's actually making the code *not* general is the necessary call to
TARGET_analyze_prologue, or TARGET_scan_prologue or whatever the name
of that function is for the target in question. It might be worthwhile
to think about a generalized skip_prologue with a call to a yet to be
defined gdbarch_analyze_prologue or gdbarch_scan_prologue function.
> > break;
> > + break;
> > + }
> > +}
>
> Spare "break" there.
Thanks for catching this.
> > Index: testsuite/gdb.asm/asm-source.exp
>
> That looks like a different patch.
Oh yes! That's an oversight, sorry 'bout that.
Fixed patch below with a *sigh* new ChangeLog.
Corinna
ChangeLog:
* h8300-tdep.c: Slightly rearrange type definitions and functions.
(struct frame_extra_info): Remove.
(struct h8300_frame_cache): Replace locals with differently defined
uses_fp member.
(h8300_unwind_pc): Simplify.
(h8300_unwind_sp): New function.
(h8300_unwind_dummy_id): Simplify.
(h8300_init_frame_cache): New function.
(h8300_is_argument_spill): Use reworked defines for opcode scanning.
(h8300_skip_prologue): Rewrite.
(h8300_alloc_frame_cache): Remove.
(h8300_analyze_frame_setup): Remove.
(h8300_analyze_register_saves): Remove.
(h8300_analyze_prologue): Rewrite.
(h8300_frame_cache): Use h8300_init_frame_cache instead of
h8300_alloc_frame_cache. Use BINWORD instead of constant 4 to
accomodate 16 bit mode. Fix saved_sp and register offset evaluation.
(h8300_frame_this_id): Correctly calculate this_id using saved stack
pointer instead of base.
(h8300_frame_prev_register): Drop needless braces.
(h8300_frame_base_address): New function.
(h8300_frame_base): New frame_base.
(h8300_push_dummy_call): Return correct CFA value.
(h8300h_extract_return_value): Fix 8 byte value handling.
(h8300_use_struct_convention): New function.
(h8300h_use_struct_convention): New function.
(h8300h_store_return_value): Fix 8 byte value handling.
(h8300_return_value): New function.
(h8300h_return_value): New function.
(h8300_extract_struct_value_address): Remove deprecated functionality.
(h8300_push_dummy_code): Remove.
(h8300_gdbarch_init): Replace set_gdbarch_extract_return_value and
set_gdbarch_store_return_value calls by set_gdbarch_return_value.
Remove calls to set_gdbarch_deprecated_fp_regnum,
set_gdbarch_deprecated_extract_struct_value_address,
set_gdbarch_deprecated_use_struct_convention and
set_gdbarch_push_dummy_code.
Add calls to set_gdbarch_unwind_sp and frame_base_set_default.
Slightly rearrange code.
testsuite/ChangeLog:
* gdb.asm/asm-source.exp: Add h8300 to supported targets.
* gdb.asm/h8300.inc: New file.
Index: h8300-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/h8300-tdep.c,v
retrieving revision 1.100
diff -u -p -r1.100 h8300-tdep.c
--- h8300-tdep.c 12 Feb 2005 10:38:50 -0000 1.100
+++ h8300-tdep.c 29 Apr 2005 09:07:39 -0000
@@ -1,7 +1,7 @@
/* Target-machine dependent code for Renesas H8/300, for GDB.
Copyright 1988, 1990, 1991, 1992, 1993, 1994, 1995, 1996, 1998,
- 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
+ 1999, 2000, 2001, 2002, 2003, 2005 Free Software Foundation, Inc.
This file is part of GDB.
@@ -41,27 +41,6 @@
#include "frame-base.h"
#include "frame-unwind.h"
-/* Extra info which is saved in each frame_info. */
-struct frame_extra_info
-{
- CORE_ADDR from_pc;
-};
-
-enum
-{
- h8300_reg_size = 2,
- h8300h_reg_size = 4,
- h8300_max_reg_size = 4,
-};
-
-static int is_h8300hmode (struct gdbarch *gdbarch);
-static int is_h8300smode (struct gdbarch *gdbarch);
-static int is_h8300sxmode (struct gdbarch *gdbarch);
-static int is_h8300_normal_mode (struct gdbarch *gdbarch);
-
-#define BINWORD (is_h8300hmode (current_gdbarch) && \
- !is_h8300_normal_mode (current_gdbarch) ? h8300h_reg_size : h8300_reg_size)
-
enum gdb_regnum
{
E_R0_REGNUM, E_ER0_REGNUM = E_R0_REGNUM, E_ARG0_REGNUM = E_R0_REGNUM,
@@ -90,17 +69,106 @@ enum gdb_regnum
#define E_PSEUDO_CCR_REGNUM (NUM_REGS)
#define E_PSEUDO_EXR_REGNUM (NUM_REGS+1)
-#define UNSIGNED_SHORT(X) ((X) & 0xffff)
+struct h8300_frame_cache
+{
+ /* Base address. */
+ CORE_ADDR base;
+ CORE_ADDR sp_offset;
+ CORE_ADDR pc;
+
+ /* Flag showing that a frame has been created in the prologue code. */
+ int uses_fp;
-#define IS_PUSH(x) ((x & 0xfff0)==0x6df0)
-#define IS_PUSH_FP(x) (x == 0x6df6)
-#define IS_MOVE_FP(x) (x == 0x0d76 || x == 0x0ff6)
-#define IS_MOV_SP_FP(x) (x == 0x0d76 || x == 0x0ff6)
-#define IS_SUB2_SP(x) (x==0x1b87)
-#define IS_SUB4_SP(x) (x==0x1b97)
-#define IS_SUBL_SP(x) (x==0x7a37)
-#define IS_MOVK_R5(x) (x==0x7905)
-#define IS_SUB_R5SP(x) (x==0x1957)
+ /* Saved registers. */
+ CORE_ADDR saved_regs[H8300_MAX_NUM_REGS];
+ CORE_ADDR saved_sp;
+};
+
+enum
+{
+ h8300_reg_size = 2,
+ h8300h_reg_size = 4,
+ h8300_max_reg_size = 4,
+};
+
+static int is_h8300hmode (struct gdbarch *gdbarch);
+static int is_h8300smode (struct gdbarch *gdbarch);
+static int is_h8300sxmode (struct gdbarch *gdbarch);
+static int is_h8300_normal_mode (struct gdbarch *gdbarch);
+
+#define BINWORD ((is_h8300hmode (current_gdbarch) \
+ && !is_h8300_normal_mode (current_gdbarch)) \
+ ? h8300h_reg_size : h8300_reg_size)
+
+static CORE_ADDR
+h8300_unwind_pc (struct gdbarch *gdbarch, struct frame_info *next_frame)
+{
+ return frame_unwind_register_unsigned (next_frame, E_PC_REGNUM);
+}
+
+static CORE_ADDR
+h8300_unwind_sp (struct gdbarch *gdbarch, struct frame_info *next_frame)
+{
+ return frame_unwind_register_unsigned (next_frame, E_SP_REGNUM);
+}
+
+static struct frame_id
+h8300_unwind_dummy_id (struct gdbarch *gdbarch, struct frame_info *next_frame)
+{
+ return frame_id_build (h8300_unwind_sp (gdbarch, next_frame),
+ frame_pc_unwind (next_frame));
+}
+
+/* Normal frames. */
+
+/* Allocate and initialize a frame cache. */
+
+static void
+h8300_init_frame_cache (struct h8300_frame_cache *cache)
+{
+ int i;
+
+ /* Base address. */
+ cache->base = 0;
+ cache->sp_offset = 0;
+ cache->pc = 0;
+
+ /* Frameless until proven otherwise. */
+ cache->uses_fp = 0;
+
+ /* Saved registers. We initialize these to -1 since zero is a valid
+ offset (that's where %fp is supposed to be stored). */
+ for (i = 0; i < NUM_REGS; i++)
+ cache->saved_regs[i] = -1;
+}
+
+#define IS_MOVB_RnRm(x) (((x) & 0xff88) == 0x0c88)
+#define IS_MOVW_RnRm(x) (((x) & 0xff88) == 0x0d00)
+#define IS_MOVL_RnRm(x) (((x) & 0xff88) == 0x0f80)
+#define IS_MOVB_Rn16_SP(x) (((x) & 0xfff0) == 0x6ee0)
+#define IS_MOVB_EXT(x) ((x) == 0x7860)
+#define IS_MOVB_Rn24_SP(x) (((x) & 0xfff0) == 0x6aa0)
+#define IS_MOVW_Rn16_SP(x) (((x) & 0xfff0) == 0x6fe0)
+#define IS_MOVW_EXT(x) ((x) == 0x78e0)
+#define IS_MOVW_Rn24_SP(x) (((x) & 0xfff0) == 0x6ba0)
+/* Same instructions as mov.w, just prefixed with 0x0100 */
+#define IS_MOVL_PRE(x) ((x) == 0x0100)
+#define IS_MOVL_Rn16_SP(x) (((x) & 0xfff0) == 0x6fe0)
+#define IS_MOVL_EXT(x) ((x) == 0x78e0)
+#define IS_MOVL_Rn24_SP(x) (((x) & 0xfff0) == 0x6ba0)
+
+#define IS_PUSHFP_MOVESPFP(x) ((x) == 0x6df60d76)
+#define IS_PUSH_FP(x) ((x) == 0x01006df6)
+#define IS_MOV_SP_FP(x) ((x) == 0x0ff6)
+#define IS_SUB2_SP(x) ((x) == 0x1b87)
+#define IS_SUB4_SP(x) ((x) == 0x1b97)
+#define IS_ADD_IMM_SP(x) ((x) == 0x7a1f)
+#define IS_SUB_IMM_SP(x) ((x) == 0x7a3f)
+#define IS_SUBL4_SP(x) ((x) == 0x1acf)
+#define IS_MOV_IMM_Rn(x) (((x) & 0xfff0) == 0x7905)
+#define IS_SUB_RnSP(x) (((x) & 0xff0f) == 0x1907)
+#define IS_ADD_RnSP(x) (((x) & 0xff0f) == 0x0907)
+#define IS_PUSH(x) (((x) & 0xfff0) == 0x6df0)
/* If the instruction at PC is an argument register spill, return its
length. Otherwise, return zero.
@@ -118,27 +186,20 @@ h8300_is_argument_spill (CORE_ADDR pc)
{
int w = read_memory_unsigned_integer (pc, 2);
- if (((w & 0xff88) == 0x0c88 /* mov.b Rsl, Rdl */
- || (w & 0xff88) == 0x0d00 /* mov.w Rs, Rd */
- || (w & 0xff88) == 0x0f80) /* mov.l Rs, Rd */
+ if ((IS_MOVB_RnRm (w) || IS_MOVW_RnRm (w) || IS_MOVL_RnRm (w))
&& (w & 0x70) <= 0x20 /* Rs is R0, R1 or R2 */
&& (w & 0x7) >= 0x3 && (w & 0x7) <= 0x5) /* Rd is R3, R4 or R5 */
return 2;
- if ((w & 0xfff0) == 0x6ee0 /* mov.b Rs,@(d:16,er6) */
+ if (IS_MOVB_Rn16_SP (w)
&& 8 <= (w & 0xf) && (w & 0xf) <= 10) /* Rs is R0L, R1L, or R2L */
{
- int w2 = read_memory_integer (pc + 2, 2);
-
- /* ... and d:16 is negative. */
- if (w2 < 0)
+ if (read_memory_integer (pc + 2, 2) < 0) /* ... and d:16 is negative. */
return 4;
}
- else if (w == 0x7860)
+ else if (IS_MOVB_EXT (w))
{
- int w2 = read_memory_integer (pc + 2, 2);
-
- if ((w2 & 0xfff0) == 0x6aa0) /* mov.b Rs, @(d:24,er6) */
+ if (IS_MOVB_Rn24_SP (read_memory_unsigned_integer (pc + 2, 2)))
{
LONGEST disp = read_memory_integer (pc + 4, 4);
@@ -147,20 +208,16 @@ h8300_is_argument_spill (CORE_ADDR pc)
return 8;
}
}
- else if ((w & 0xfff0) == 0x6fe0 /* mov.w Rs,@(d:16,er6) */
+ else if (IS_MOVW_Rn16_SP (w)
&& (w & 0xf) <= 2) /* Rs is R0, R1, or R2 */
{
- int w2 = read_memory_integer (pc + 2, 2);
-
/* ... and d:16 is negative. */
- if (w2 < 0)
+ if (read_memory_integer (pc + 2, 2) < 0)
return 4;
}
- else if (w == 0x78e0)
+ else if (IS_MOVW_EXT (w))
{
- int w2 = read_memory_integer (pc + 2, 2);
-
- if ((w2 & 0xfff0) == 0x6ba0) /* mov.b Rs, @(d:24,er6) */
+ if (IS_MOVW_Rn24_SP (read_memory_unsigned_integer (pc + 2, 2)))
{
LONGEST disp = read_memory_integer (pc + 4, 4);
@@ -169,24 +226,22 @@ h8300_is_argument_spill (CORE_ADDR pc)
return 8;
}
}
- else if (w == 0x0100)
+ else if (IS_MOVL_PRE (w))
{
int w2 = read_memory_integer (pc + 2, 2);
- if ((w2 & 0xfff0) == 0x6fe0 /* mov.l Rs,@(d:16,er6) */
+ if (IS_MOVL_Rn16_SP (w2)
&& (w2 & 0xf) <= 2) /* Rs is ER0, ER1, or ER2 */
{
- int w3 = read_memory_integer (pc + 4, 2);
-
/* ... and d:16 is negative. */
- if (w3 < 0)
+ if (read_memory_integer (pc + 4, 2) < 0)
return 6;
}
- else if (w2 == 0x78e0)
+ else if (IS_MOVL_EXT (w2))
{
int w3 = read_memory_integer (pc + 4, 2);
- if ((w3 & 0xfff0) == 0x6ba0) /* mov.l Rs, @(d:24,er6) */
+ if (IS_MOVL_Rn24_SP (read_memory_integer (pc + 4, 2)))
{
LONGEST disp = read_memory_integer (pc + 6, 4);
@@ -200,297 +255,6 @@ h8300_is_argument_spill (CORE_ADDR pc)
return 0;
}
-static CORE_ADDR
-h8300_skip_prologue (CORE_ADDR start_pc)
-{
- short int w;
- int adjust = 0;
-
- /* Skip past all push and stm insns. */
- while (1)
- {
- w = read_memory_unsigned_integer (start_pc, 2);
- /* First look for push insns. */
- if (w == 0x0100 || w == 0x0110 || w == 0x0120 || w == 0x0130)
- {
- w = read_memory_unsigned_integer (start_pc + 2, 2);
- adjust = 2;
- }
-
- if (IS_PUSH (w))
- {
- start_pc += 2 + adjust;
- w = read_memory_unsigned_integer (start_pc, 2);
- continue;
- }
- adjust = 0;
- break;
- }
-
- /* Skip past a move to FP, either word or long sized */
- w = read_memory_unsigned_integer (start_pc, 2);
- if (w == 0x0100)
- {
- w = read_memory_unsigned_integer (start_pc + 2, 2);
- adjust += 2;
- }
-
- if (IS_MOVE_FP (w))
- {
- start_pc += 2 + adjust;
- w = read_memory_unsigned_integer (start_pc, 2);
- }
-
- /* Check for loading either a word constant into r5;
- long versions are handled by the SUBL_SP below. */
- if (IS_MOVK_R5 (w))
- {
- start_pc += 2;
- w = read_memory_unsigned_integer (start_pc, 2);
- }
-
- /* Now check for subtracting r5 from sp, word sized only. */
- if (IS_SUB_R5SP (w))
- {
- start_pc += 2 + adjust;
- w = read_memory_unsigned_integer (start_pc, 2);
- }
-
- /* Check for subs #2 and subs #4. */
- while (IS_SUB2_SP (w) || IS_SUB4_SP (w))
- {
- start_pc += 2 + adjust;
- w = read_memory_unsigned_integer (start_pc, 2);
- }
-
- /* Check for a 32bit subtract. */
- if (IS_SUBL_SP (w))
- start_pc += 6 + adjust;
-
- /* Skip past another possible stm insn for registers R3 to R5 (possibly used
- for register qualified arguments. */
- w = read_memory_unsigned_integer (start_pc, 2);
- /* First look for push insns. */
- if (w == 0x0110 || w == 0x0120 || w == 0x0130)
- {
- w = read_memory_unsigned_integer (start_pc + 2, 2);
- if (IS_PUSH (w) && (w & 0xf) >= 0x3 && (w & 0xf) <= 0x5)
- start_pc += 4;
- }
-
- /* Check for spilling an argument register to the stack frame.
- This could also be an initializing store from non-prologue code,
- but I don't think there's any harm in skipping that. */
- for (;;)
- {
- int spill_size = h8300_is_argument_spill (start_pc);
- if (spill_size == 0)
- break;
- start_pc += spill_size;
- }
-
- return start_pc;
-}
-
-static CORE_ADDR
-h8300_unwind_pc (struct gdbarch *gdbarch, struct frame_info *next_frame)
-{
- char buf[8];
-
- frame_unwind_register (next_frame, E_PC_REGNUM, buf);
- return extract_typed_address (buf, builtin_type_void_func_ptr);
-}
-
-static struct frame_id
-h8300_unwind_dummy_id (struct gdbarch *gdbarch, struct frame_info *next_frame)
-{
- char buf[4];
- CORE_ADDR fp;
-
- frame_unwind_register (next_frame, E_FP_REGNUM, buf);
- fp = extract_unsigned_integer (buf, 4);
-
- return frame_id_build (fp, frame_pc_unwind (next_frame));
-}
-
-struct h8300_frame_cache
-{
- /* Base address. */
- CORE_ADDR base;
- CORE_ADDR sp_offset;
- CORE_ADDR pc;
-
- /* Saved registers. */
- CORE_ADDR saved_regs[H8300_MAX_NUM_REGS];
- CORE_ADDR saved_sp;
-
- /* Stack space reserved for local variables. */
- long locals;
-};
-
-/* Normal frames. */
-
-/* Allocate and initialize a frame cache. */
-
-static struct h8300_frame_cache *
-h8300_alloc_frame_cache (void)
-{
- struct h8300_frame_cache *cache;
- int i;
-
- cache = FRAME_OBSTACK_ZALLOC (struct h8300_frame_cache);
-
- /* Base address. */
- cache->base = 0;
- cache->sp_offset = -4;
- cache->pc = 0;
-
- /* Saved registers. We initialize these to -1 since zero is a valid
- offset (that's where %fp is supposed to be stored). */
- for (i = 0; i < NUM_REGS; i++)
- cache->saved_regs[i] = -1;
-
- /* Frameless until proven otherwise. */
- cache->locals = -1;
-
- return cache;
-}
-
-/* Check whether PC points at a code that sets up a new stack frame.
- If so, it updates CACHE and returns the address of the first
- instruction after the sequence that sets removes the "hidden"
- argument from the stack or CURRENT_PC, whichever is smaller.
- Otherwise, return PC. */
-
-static CORE_ADDR
-h8300_analyze_frame_setup (CORE_ADDR pc, CORE_ADDR current_pc,
- struct h8300_frame_cache *cache)
-{
- unsigned int op;
- int subs_count;
-
- if (pc >= current_pc)
- return current_pc;
-
- op = read_memory_unsigned_integer (pc, 4);
-
- if (op == 0x6df60d76)
- {
- /* mov.w r6,@-sp; mov.w sp,r6 */
- cache->saved_regs[E_FP_REGNUM] = 0;
- cache->sp_offset += 2;
- op = read_memory_unsigned_integer (pc + 4, 4);
- if (((op >> 16) & 0xfff0) == 0x7900)
- {
- /* mov.w #imm,rN */
- cache->locals = -(short) (op & 0xffff);
- return pc + 8;
- }
- else if ((op >> 16) == 0x1b87)
- {
- /* subs #2,sp */
- for (cache->locals = 0, pc += 4;
- read_memory_unsigned_integer (pc, 2) == 0x1b87;
- pc += 2, cache->locals += 2);
- return pc;
- }
- }
- else if (op == 0x01006df6)
- {
- /* mov.l er6,@-sp */
- op = read_memory_unsigned_integer (pc + 4, 2);
- if (op == 0x0ff6)
- {
- /* mov.l sp,er6 */
- op = read_memory_unsigned_integer (pc + 6, 2);
- if (op == 0x7a17)
- {
- /* add.l #-n,sp */
- cache->locals = -read_memory_unsigned_integer (pc + 8, 4);
- return pc + 12;
- }
- else if (op == 0x1b97)
- {
- /* subs #4,sp */
- for (cache->locals = 0, pc += 6;
- read_memory_unsigned_integer (pc, 2) == 0x1b97;
- pc += 2, cache->locals += 2);
- return pc;
- }
- }
- }
-
- return pc;
-}
-
-/* Check whether PC points at code that saves registers on the stack.
- If so, it updates CACHE and returns the address of the first
- instruction after the register saves or CURRENT_PC, whichever is
- smaller. Otherwise, return PC. */
-
-static CORE_ADDR
-h8300_analyze_register_saves (CORE_ADDR pc, CORE_ADDR current_pc,
- struct h8300_frame_cache *cache)
-{
- if (cache->locals >= 0)
- {
- CORE_ADDR offset;
- int op;
- int i, regno;
-
- offset = -cache->locals;
- while (pc < current_pc)
- {
- op = read_memory_unsigned_integer (pc, 2);
- if ((op & 0xfff0) == 0x6df0)
- {
- /* mov.w rN,@-sp */
- regno = op & 0x000f;
- cache->saved_regs[regno] = offset;
- offset -= 2;
- pc += 2;
- }
- else if (op == 0x0100)
- {
- op = read_memory_unsigned_integer (pc + 2, 2);
- if ((op & 0xfff0) == 0x6df0)
- {
- /* mov.l erN,@-sp */
- regno = op & 0x000f;
- cache->saved_regs[regno] = offset;
- offset -= 4;
- pc += 4;
- }
- else
- break;
- }
- else if ((op & 0xffcf) == 0x0100)
- {
- int op1;
- op1 = read_memory_unsigned_integer (pc + 2, 2);
- if ((op1 & 0xfff0) == 0x6df0)
- {
- /* stm.l reglist,@-sp */
- i = ((op & 0x0030) >> 4) + 1;
- regno = op1 & 0x000f;
- for (; i > 0; regno++, --i)
- {
- cache->saved_regs[regno] = offset;
- offset -= 4;
- }
- pc += 4;
- }
- else
- break;
- }
- else
- break;
- }
- }
- return pc;
-}
-
-
/* Do a full analysis of the prologue at PC and update CACHE
accordingly. Bail out early if CURRENT_PC is reached. Return the
address where the analysis stopped.
@@ -524,10 +288,6 @@ h8300_analyze_register_saves (CORE_ADDR
mov.l erN,@-sp
stm.l reglist,@-sp
- For setting up the PIC register:
-
- Future equivalence...
-
*/
static CORE_ADDR
@@ -535,13 +295,131 @@ h8300_analyze_prologue (CORE_ADDR pc, CO
struct h8300_frame_cache *cache)
{
unsigned int op;
+ int regno, i, spill_size;
+
+ cache->sp_offset = 0;
- pc = h8300_analyze_frame_setup (pc, current_pc, cache);
- pc = h8300_analyze_register_saves (pc, current_pc, cache);
if (pc >= current_pc)
return current_pc;
- /* PIC support */
+ op = read_memory_unsigned_integer (pc, 4);
+
+ if (IS_PUSHFP_MOVESPFP (op))
+ {
+ cache->saved_regs[E_FP_REGNUM] = 0;
+ cache->uses_fp = 1;
+ pc += 4;
+ }
+ else if (IS_PUSH_FP (op))
+ {
+ cache->saved_regs[E_FP_REGNUM] = 0;
+ pc += 4;
+ if (pc >= current_pc)
+ return current_pc;
+ op = read_memory_unsigned_integer (pc, 2);
+ if (IS_MOV_SP_FP (op))
+ {
+ cache->uses_fp = 1;
+ pc += 2;
+ }
+ }
+
+ while (pc < current_pc)
+ {
+ op = read_memory_unsigned_integer (pc, 2);
+ if (IS_SUB2_SP (op))
+ {
+ cache->sp_offset += 2;
+ pc += 2;
+ }
+ else if (IS_SUB4_SP (op))
+ {
+ cache->sp_offset += 4;
+ pc += 2;
+ }
+ else if (IS_ADD_IMM_SP (op))
+ {
+ cache->sp_offset += -read_memory_integer (pc + 2, 2);
+ pc += 4;
+ }
+ else if (IS_SUB_IMM_SP (op))
+ {
+ cache->sp_offset += read_memory_integer (pc + 2, 2);
+ pc += 4;
+ }
+ else if (IS_SUBL4_SP (op))
+ {
+ cache->sp_offset += 4;
+ pc += 2;
+ }
+ else if (IS_MOV_IMM_Rn (op))
+ {
+ int offset = read_memory_integer (pc + 2, 2);
+ regno = op & 0x000f;
+ op = read_memory_unsigned_integer (pc + 4, 2);
+ if (IS_ADD_RnSP (op) && (op & 0x00f0) == regno)
+ {
+ cache->sp_offset -= offset;
+ pc += 6;
+ }
+ else if (IS_SUB_RnSP (op) && (op & 0x00f0) == regno)
+ {
+ cache->sp_offset += offset;
+ pc += 6;
+ }
+ else
+ break;
+ }
+ else if (IS_PUSH (op))
+ {
+ regno = op & 0x000f;
+ cache->sp_offset += 2;
+ cache->saved_regs[regno] = cache->sp_offset;
+ pc += 2;
+ }
+ else if (op == 0x0100)
+ {
+ op = read_memory_unsigned_integer (pc + 2, 2);
+ if (IS_PUSH (op))
+ {
+ regno = op & 0x000f;
+ cache->sp_offset += 4;
+ cache->saved_regs[regno] = cache->sp_offset;
+ pc += 4;
+ }
+ else
+ break;
+ }
+ else if ((op & 0xffcf) == 0x0100)
+ {
+ int op1;
+ op1 = read_memory_unsigned_integer (pc + 2, 2);
+ if (IS_PUSH (op1))
+ {
+ /* Since the prefix is 0x01x0, this is not a simple pushm but a
+ stm.l reglist,@-sp */
+ i = ((op & 0x0030) >> 4) + 1;
+ regno = op1 & 0x000f;
+ for (; i > 0; regno++, --i)
+ {
+ cache->sp_offset += 4;
+ cache->saved_regs[regno] = cache->sp_offset;
+ }
+ pc += 4;
+ }
+ else
+ break;
+ }
+ else
+ break;
+ }
+
+ /* Check for spilling an argument register to the stack frame.
+ This could also be an initializing store from non-prologue code,
+ but I don't think there's any harm in skipping that. */
+ while ((spill_size = h8300_is_argument_spill (pc)) > 0
+ && pc + spill_size <= current_pc)
+ pc += spill_size;
return pc;
}
@@ -552,35 +430,33 @@ h8300_frame_cache (struct frame_info *ne
struct h8300_frame_cache *cache;
char buf[4];
int i;
+ CORE_ADDR current_pc;
if (*this_cache)
return *this_cache;
- cache = h8300_alloc_frame_cache ();
+ cache = FRAME_OBSTACK_ZALLOC (struct h8300_frame_cache);
+ h8300_init_frame_cache (cache);
*this_cache = cache;
/* In principle, for normal frames, %fp holds the frame pointer,
which holds the base address for the current stack frame.
However, for functions that don't need it, the frame pointer is
optional. For these "frameless" functions the frame pointer is
- actually the frame pointer of the calling frame. Signal
- trampolines are just a special case of a "frameless" function.
- They (usually) share their frame pointer with the frame that was
- in progress when the signal occurred. */
+ actually the frame pointer of the calling frame. */
- frame_unwind_register (next_frame, E_FP_REGNUM, buf);
- cache->base = extract_unsigned_integer (buf, 4);
+ cache->base = frame_unwind_register_unsigned (next_frame, E_FP_REGNUM);
if (cache->base == 0)
return cache;
- /* For normal frames, %pc is stored at 4(%fp). */
- cache->saved_regs[E_PC_REGNUM] = 4;
+ cache->saved_regs[E_PC_REGNUM] = -BINWORD;
cache->pc = frame_func_unwind (next_frame);
+ current_pc = frame_pc_unwind (next_frame);
if (cache->pc != 0)
- h8300_analyze_prologue (cache->pc, frame_pc_unwind (next_frame), cache);
+ h8300_analyze_prologue (cache->pc, current_pc, cache);
- if (cache->locals < 0)
+ if (!cache->uses_fp)
{
/* We didn't find a valid frame, which means that CACHE->base
currently holds the frame pointer for our calling frame. If
@@ -590,19 +466,22 @@ h8300_frame_cache (struct frame_info *ne
frame by looking at the stack pointer. For truly "frameless"
functions this might work too. */
- frame_unwind_register (next_frame, E_SP_REGNUM, buf);
- cache->base = extract_unsigned_integer (buf, 4) + cache->sp_offset;
+ cache->base = frame_unwind_register_unsigned (next_frame, E_SP_REGNUM)
+ + cache->sp_offset;
+ cache->saved_sp = cache->base + BINWORD;
+ cache->saved_regs[E_PC_REGNUM] = 0;
+ }
+ else
+ {
+ cache->saved_sp = cache->base + 2 * BINWORD;
+ cache->saved_regs[E_PC_REGNUM] = -BINWORD;
}
-
- /* Now that we have the base address for the stack frame we can
- calculate the value of %sp in the calling frame. */
- cache->saved_sp = cache->base;
/* Adjust all the saved registers such that they contain addresses
instead of offsets. */
for (i = 0; i < NUM_REGS; i++)
if (cache->saved_regs[i] != -1)
- cache->saved_regs[i] += cache->base;
+ cache->saved_regs[i] = cache->base - cache->saved_regs[i];
return cache;
}
@@ -618,8 +497,7 @@ h8300_frame_this_id (struct frame_info *
if (cache->base == 0)
return;
- /* See the end of m68k_push_dummy_call. */
- *this_id = frame_id_build (cache->base, cache->pc);
+ *this_id = frame_id_build (cache->saved_sp, cache->pc);
}
static void
@@ -640,10 +518,7 @@ h8300_frame_prev_register (struct frame_
*addrp = 0;
*realnump = -1;
if (valuep)
- {
- /* Store the value. */
- store_unsigned_integer (valuep, 4, cache->saved_sp);
- }
+ store_unsigned_integer (valuep, BINWORD, cache->saved_sp);
return;
}
@@ -654,11 +529,7 @@ h8300_frame_prev_register (struct frame_
*addrp = cache->saved_regs[regnum];
*realnump = -1;
if (valuep)
- {
- /* Read the value in from memory. */
- read_memory (*addrp, valuep,
- register_size (current_gdbarch, regnum));
- }
+ read_memory (*addrp, valuep, register_size (current_gdbarch, regnum));
return;
}
@@ -678,6 +549,45 @@ h8300_frame_sniffer (struct frame_info *
return &h8300_frame_unwind;
}
+static CORE_ADDR
+h8300_frame_base_address (struct frame_info *next_frame, void **this_cache)
+{
+ struct h8300_frame_cache *cache = h8300_frame_cache (next_frame, this_cache);
+ return cache->base;
+}
+
+static const struct frame_base h8300_frame_base = {
+ &h8300_frame_unwind,
+ h8300_frame_base_address,
+ h8300_frame_base_address,
+ h8300_frame_base_address
+};
+
+static CORE_ADDR
+h8300_skip_prologue (CORE_ADDR pc)
+{
+ CORE_ADDR func_addr = 0 , func_end = 0;
+
+ if (find_pc_partial_function (pc, NULL, &func_addr, &func_end))
+ {
+ struct symtab_and_line sal;
+ struct h8300_frame_cache cache;
+
+ /* Found a function. */
+ sal = find_pc_line (func_addr, 0);
+ if (sal.end && sal.end < func_end)
+ /* Found a line number, use it as end of prologue. */
+ return sal.end;
+
+ /* No useable line symbol. Use prologue parsing method. */
+ h8300_init_frame_cache (&cache);
+ return h8300_analyze_prologue (func_addr, func_end, &cache);
+ }
+
+ /* No function symbol -- just return the PC. */
+ return (CORE_ADDR) pc;
+}
+
/* Function: push_dummy_call
Setup the function arguments for calling a function in the inferior.
In this discussion, a `word' is 16 bits on the H8/300s, and 32 bits
@@ -836,7 +746,9 @@ h8300_push_dummy_call (struct gdbarch *g
/* Update stack pointer. */
regcache_cooked_write_unsigned (regcache, E_SP_REGNUM, sp);
- return sp;
+ /* Return the new stack pointer minus the return address slot since
+ that's what DWARF2/GCC uses as the frame's CFA. */
+ return sp + wordsize;
}
/* Function: extract_return_value
@@ -896,9 +808,10 @@ h8300h_extract_return_value (struct type
case 8: /* long long is now 8 bytes. */
if (TYPE_CODE (type) == TYPE_CODE_INT)
{
- regcache_cooked_read_unsigned (regcache, E_RET0_REGNUM, &addr);
- c = read_memory_unsigned_integer ((CORE_ADDR) addr, len);
- store_unsigned_integer (valbuf, len, c);
+ regcache_cooked_read_unsigned (regcache, E_RET0_REGNUM, &c);
+ store_unsigned_integer (valbuf, 4, c);
+ regcache_cooked_read_unsigned (regcache, E_RET1_REGNUM, &c);
+ store_unsigned_integer ((void *) ((char *) valbuf + 4), 4, c);
}
else
{
@@ -908,6 +821,34 @@ h8300h_extract_return_value (struct type
}
}
+int
+h8300_use_struct_convention (struct type *value_type)
+{
+ /* Types of 1, 2 or 4 bytes are returned in R0/R1, everything else on the
+ stack. */
+
+ if (TYPE_CODE (value_type) == TYPE_CODE_STRUCT
+ || TYPE_CODE (value_type) == TYPE_CODE_UNION)
+ return 1;
+ return !(TYPE_LENGTH (value_type) == 1
+ || TYPE_LENGTH (value_type) == 2
+ || TYPE_LENGTH (value_type) == 4);
+}
+
+int
+h8300h_use_struct_convention (struct type *value_type)
+{
+ /* Types of 1, 2 or 4 bytes are returned in R0, INT types of 8 bytes are
+ returned in R0/R1, everything else on the stack. */
+ if (TYPE_CODE (value_type) == TYPE_CODE_STRUCT
+ || TYPE_CODE (value_type) == TYPE_CODE_UNION)
+ return 1;
+ return !(TYPE_LENGTH (value_type) == 1
+ || TYPE_LENGTH (value_type) == 2
+ || TYPE_LENGTH (value_type) == 4
+ || (TYPE_LENGTH (value_type) == 8
+ && TYPE_CODE (value_type) == TYPE_CODE_INT));
+}
/* Function: store_return_value
Place the appropriate value in the appropriate registers.
@@ -955,13 +896,54 @@ h8300h_store_return_value (struct type *
val = extract_unsigned_integer (valbuf, len);
regcache_cooked_write_unsigned (regcache, E_RET0_REGNUM, val);
break;
- case 8: /* long long, double and long double are all defined
- as 4 byte types so far so this shouldn't happen. */
- error ("I don't know how to return an 8 byte value.");
+ case 8:
+ val = extract_unsigned_integer (valbuf, len);
+ regcache_cooked_write_unsigned (regcache, E_RET0_REGNUM,
+ (val >> 32) & 0xffffffff);
+ regcache_cooked_write_unsigned (regcache, E_RET1_REGNUM,
+ val & 0xffffffff);
break;
}
}
+static enum return_value_convention
+h8300_return_value (struct gdbarch *gdbarch, struct type *type,
+ struct regcache *regcache,
+ void *readbuf, const void *writebuf)
+{
+ if (h8300_use_struct_convention (type))
+ return RETURN_VALUE_STRUCT_CONVENTION;
+ if (writebuf)
+ h8300_store_return_value (type, regcache, writebuf);
+ else if (readbuf)
+ h8300_extract_return_value (type, regcache, readbuf);
+ return RETURN_VALUE_REGISTER_CONVENTION;
+}
+
+static enum return_value_convention
+h8300h_return_value (struct gdbarch *gdbarch, struct type *type,
+ struct regcache *regcache,
+ void *readbuf, const void *writebuf)
+{
+ if (h8300h_use_struct_convention (type))
+ {
+ if (readbuf)
+ {
+ ULONGEST addr;
+
+ regcache_raw_read_unsigned (regcache, E_R0_REGNUM, &addr);
+ read_memory (addr, readbuf, TYPE_LENGTH (type));
+ }
+
+ return RETURN_VALUE_ABI_RETURNS_ADDRESS;
+ }
+ if (writebuf)
+ h8300h_store_return_value (type, regcache, writebuf);
+ else if (readbuf)
+ h8300h_extract_return_value (type, regcache, readbuf);
+ return RETURN_VALUE_REGISTER_CONVENTION;
+}
+
static struct cmd_list_element *setmachinelist;
static const char *
@@ -1208,14 +1190,6 @@ h8300s_dbg_reg_to_regnum (int regno)
return regno;
}
-static CORE_ADDR
-h8300_extract_struct_value_address (struct regcache *regcache)
-{
- ULONGEST addr;
- regcache_cooked_read_unsigned (regcache, E_RET0_REGNUM, &addr);
- return addr;
-}
-
const static unsigned char *
h8300_breakpoint_from_pc (CORE_ADDR *pcptr, int *lenptr)
{
@@ -1226,22 +1200,6 @@ h8300_breakpoint_from_pc (CORE_ADDR *pcp
return breakpoint;
}
-static CORE_ADDR
-h8300_push_dummy_code (struct gdbarch *gdbarch,
- CORE_ADDR sp, CORE_ADDR funaddr, int using_gcc,
- struct value **args, int nargs,
- struct type *value_type,
- CORE_ADDR *real_pc, CORE_ADDR *bp_addr)
-{
- /* Allocate space sufficient for a breakpoint. */
- sp = (sp - 2) & ~1;
- /* Store the address of that breakpoint */
- *bp_addr = sp;
- /* h8300 always starts the call at the callee's entry point. */
- *real_pc = funaddr;
- return sp;
-}
-
static void
h8300_print_float_info (struct gdbarch *gdbarch, struct ui_file *file,
struct frame_info *frame, const char *args)
@@ -1281,8 +1239,7 @@ h8300_gdbarch_init (struct gdbarch_info
set_gdbarch_register_name (gdbarch, h8300_register_name);
set_gdbarch_ptr_bit (gdbarch, 2 * TARGET_CHAR_BIT);
set_gdbarch_addr_bit (gdbarch, 2 * TARGET_CHAR_BIT);
- set_gdbarch_extract_return_value (gdbarch, h8300_extract_return_value);
- set_gdbarch_store_return_value (gdbarch, h8300_store_return_value);
+ set_gdbarch_return_value (gdbarch, h8300_return_value);
set_gdbarch_print_insn (gdbarch, print_insn_h8300);
break;
case bfd_mach_h8300h:
@@ -1304,8 +1261,7 @@ h8300_gdbarch_init (struct gdbarch_info
set_gdbarch_ptr_bit (gdbarch, 2 * TARGET_CHAR_BIT);
set_gdbarch_addr_bit (gdbarch, 2 * TARGET_CHAR_BIT);
}
- set_gdbarch_extract_return_value (gdbarch, h8300h_extract_return_value);
- set_gdbarch_store_return_value (gdbarch, h8300h_store_return_value);
+ set_gdbarch_return_value (gdbarch, h8300h_return_value);
set_gdbarch_print_insn (gdbarch, print_insn_h8300h);
break;
case bfd_mach_h8300s:
@@ -1327,8 +1283,7 @@ h8300_gdbarch_init (struct gdbarch_info
set_gdbarch_ptr_bit (gdbarch, 2 * TARGET_CHAR_BIT);
set_gdbarch_addr_bit (gdbarch, 2 * TARGET_CHAR_BIT);
}
- set_gdbarch_extract_return_value (gdbarch, h8300h_extract_return_value);
- set_gdbarch_store_return_value (gdbarch, h8300h_store_return_value);
+ set_gdbarch_return_value (gdbarch, h8300h_return_value);
set_gdbarch_print_insn (gdbarch, print_insn_h8300s);
break;
case bfd_mach_h8300sx:
@@ -1350,8 +1305,7 @@ h8300_gdbarch_init (struct gdbarch_info
set_gdbarch_ptr_bit (gdbarch, 2 * TARGET_CHAR_BIT);
set_gdbarch_addr_bit (gdbarch, 2 * TARGET_CHAR_BIT);
}
- set_gdbarch_extract_return_value (gdbarch, h8300h_extract_return_value);
- set_gdbarch_store_return_value (gdbarch, h8300h_store_return_value);
+ set_gdbarch_return_value (gdbarch, h8300h_return_value);
set_gdbarch_print_insn (gdbarch, print_insn_h8300s);
break;
}
@@ -1364,7 +1318,6 @@ h8300_gdbarch_init (struct gdbarch_info
*/
set_gdbarch_sp_regnum (gdbarch, E_SP_REGNUM);
- set_gdbarch_deprecated_fp_regnum (gdbarch, E_FP_REGNUM);
set_gdbarch_pc_regnum (gdbarch, E_PC_REGNUM);
set_gdbarch_register_type (gdbarch, h8300_register_type);
set_gdbarch_print_registers_info (gdbarch, h8300_print_registers_info);
@@ -1376,11 +1329,10 @@ h8300_gdbarch_init (struct gdbarch_info
set_gdbarch_skip_prologue (gdbarch, h8300_skip_prologue);
/* Frame unwinder. */
- set_gdbarch_unwind_dummy_id (gdbarch, h8300_unwind_dummy_id);
set_gdbarch_unwind_pc (gdbarch, h8300_unwind_pc);
-
- /* Hook in the DWARF CFI frame unwinder. */
- frame_unwind_append_sniffer (gdbarch, dwarf2_frame_sniffer);
+ set_gdbarch_unwind_sp (gdbarch, h8300_unwind_sp);
+ set_gdbarch_unwind_dummy_id (gdbarch, h8300_unwind_dummy_id);
+ frame_base_set_default (gdbarch, &h8300_frame_base);
/*
* Miscelany
@@ -1388,14 +1340,10 @@ h8300_gdbarch_init (struct gdbarch_info
/* Stack grows up. */
set_gdbarch_inner_than (gdbarch, core_addr_lessthan);
- set_gdbarch_deprecated_extract_struct_value_address (gdbarch,
- h8300_extract_struct_value_address);
- set_gdbarch_deprecated_use_struct_convention (gdbarch,
- always_use_struct_convention);
set_gdbarch_breakpoint_from_pc (gdbarch, h8300_breakpoint_from_pc);
- set_gdbarch_push_dummy_code (gdbarch, h8300_push_dummy_code);
set_gdbarch_push_dummy_call (gdbarch, h8300_push_dummy_call);
+ set_gdbarch_char_signed (gdbarch, 0);
set_gdbarch_int_bit (gdbarch, 2 * TARGET_CHAR_BIT);
set_gdbarch_long_bit (gdbarch, 4 * TARGET_CHAR_BIT);
set_gdbarch_long_long_bit (gdbarch, 8 * TARGET_CHAR_BIT);
@@ -1404,9 +1352,8 @@ h8300_gdbarch_init (struct gdbarch_info
set_gdbarch_believe_pcc_promotion (gdbarch, 1);
- /* Char is unsigned. */
- set_gdbarch_char_signed (gdbarch, 0);
-
+ /* Hook in the DWARF CFI frame unwinder. */
+ frame_unwind_append_sniffer (gdbarch, dwarf2_frame_sniffer);
frame_unwind_append_sniffer (gdbarch, h8300_frame_sniffer);
return gdbarch;
Index: testsuite/gdb.asm/asm-source.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/asm-source.exp,v
retrieving revision 1.55
diff -u -p -r1.55 asm-source.exp
--- testsuite/gdb.asm/asm-source.exp 8 Mar 2005 08:59:16 -0000 1.55
+++ testsuite/gdb.asm/asm-source.exp 29 Apr 2005 09:07:39 -0000
@@ -130,6 +130,10 @@ switch -glob -- [istarget] {
set asm-flags "-I${srcdir}/${subdir} -I${objdir}/${subdir}"
set debug-flags "-gdwarf-2"
}
+ "h83*-*" {
+ set asm-arch h8300
+ set asm-flags "-gdwarf2 -I${srcdir}/${subdir} -I${objdir}/${subdir}"
+ }
}
if { "${asm-arch}" == "" } {
Index: testsuite/gdb.asm/h8300.inc
===================================================================
RCS file: testsuite/gdb.asm/h8300.inc
diff -N testsuite/gdb.asm/h8300.inc
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ testsuite/gdb.asm/h8300.inc 29 Apr 2005 09:07:39 -0000
@@ -0,0 +1,50 @@
+ comment "subroutine prologue"
+ .macro gdbasm_enter
+ mov.w r6,@-r7
+ mov.w r7,r6
+ subs #2,r7
+ .endm
+
+ comment "subroutine epilogue"
+ .macro gdbasm_leave
+ adds #2,r7
+ mov.w @r7+,r6
+ rts
+ .endm
+
+ .macro gdbasm_call subr
+ jsr @\subr
+ .endm
+
+ .macro gdbasm_several_nops
+ nop
+ nop
+ nop
+ nop
+ .endm
+
+ comment "exit (0)"
+ .macro gdbasm_exit0
+ mov.w #0xdead,r1
+ mov.w #0xbeef,r2
+ mov.w #0,r0
+ sleep
+ .endm
+
+ comment "crt0 startup"
+ .macro gdbasm_startup
+ .section .stack
+_stack: .long 1
+ .section .text
+ .global _start
+_start:
+ mov.w #0,r6
+ mov.w #_stack,sp ; or mov.l #_stack,sp
+ mov.w #_edata,r0
+ mov.w #_end,r1
+ sub.w r2,r2
+.loop: mov.w r2,@r0
+ adds #2,r0
+ cmp r1,r0
+ blo .loop
+ .endm
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat, Inc.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFA] h8300-tdep.c: Rewrite frame code, de-deprecate, ...
2005-04-29 9:11 ` Corinna Vinschen
@ 2005-04-29 13:35 ` Daniel Jacobowitz
2005-04-29 14:25 ` Corinna Vinschen
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Jacobowitz @ 2005-04-29 13:35 UTC (permalink / raw)
To: gdb-patches
On Fri, Apr 29, 2005 at 11:10:18AM +0200, Corinna Vinschen wrote:
> On Apr 28 15:03, Daniel Jacobowitz wrote:
> > On Thu, Apr 28, 2005 at 05:32:32PM +0200, Corinna Vinschen wrote:
> >
> > I know it's a pain, but please write a real changelog entry.
>
> Sigh, ok, see below.
Thank you.
> > > + /* Saved registers. */
> > > + CORE_ADDR saved_regs[H8300_MAX_NUM_REGS];
> > > + CORE_ADDR saved_sp;
> > > +};
> >
> > Can you use trad-frame.h instead of an array of CORE_ADDRs?
>
> I rather would not. Using the saved_regs technique is used throughout
> GDB in a couple of targets and I really don't see any advantage in using
> trad-frame.h. Actually IMHO using saved_regs directly is a lot easier
> to read for people examining the code.
It's not that it is "used throughout GDB", it's that it's a
pre-existing technique. We've been trying to migrate away from it.
Nine targets do use it, fifteen have been updated not to. Using it
improves consistency and reduces duplicated code - it would eliminate
the entire contents of h8300_frame_prev_register, for instance. If
there is something about the trad_frame interface that you find hard to
read, could you be more specific, so that we can improve the interface?
In any case, I am not interested in an argument, I've got enough of
those already :-) The patch is OK.
As followups, you should probably:
- Re-add the h8300-tdep.o to Makefile.in.
- Update the h8300 entry in MAINTAINERS to say
"--target=h8300-elf ,-Werror".
These should have been done when the target was restored, but they
were missed.
--
Daniel Jacobowitz
CodeSourcery, LLC
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFA] h8300-tdep.c: Rewrite frame code, de-deprecate, ...
2005-04-29 13:35 ` Daniel Jacobowitz
@ 2005-04-29 14:25 ` Corinna Vinschen
2005-04-29 14:35 ` Mark Kettenis
0 siblings, 1 reply; 7+ messages in thread
From: Corinna Vinschen @ 2005-04-29 14:25 UTC (permalink / raw)
To: gdb-patches
On Apr 29 09:35, Daniel Jacobowitz wrote:
> It's not that it is "used throughout GDB", it's that it's a
> pre-existing technique. We've been trying to migrate away from it.
> Nine targets do use it, fifteen have been updated not to. Using it
> improves consistency and reduces duplicated code - it would eliminate
> the entire contents of h8300_frame_prev_register, for instance.
I've checked in h8300-tdep.c as is, plus the changes to Makefile.in
and MAINTAINERS. But I promise to use trad-frame for the next target
I'm working on resurrecting, which is v850.
Thanks,
Corinna
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat, Inc.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFA] h8300-tdep.c: Rewrite frame code, de-deprecate, ...
2005-04-29 14:25 ` Corinna Vinschen
@ 2005-04-29 14:35 ` Mark Kettenis
2005-05-02 15:25 ` Corinna Vinschen
0 siblings, 1 reply; 7+ messages in thread
From: Mark Kettenis @ 2005-04-29 14:35 UTC (permalink / raw)
To: gdb-patches
Date: Fri, 29 Apr 2005 16:25:03 +0200
From: Corinna Vinschen <vinschen@redhat.com>
On Apr 29 09:35, Daniel Jacobowitz wrote:
> It's not that it is "used throughout GDB", it's that it's a
> pre-existing technique. We've been trying to migrate away from it.
> Nine targets do use it, fifteen have been updated not to. Using it
> improves consistency and reduces duplicated code - it would eliminate
> the entire contents of h8300_frame_prev_register, for instance.
I've checked in h8300-tdep.c as is, plus the changes to Makefile.in
and MAINTAINERS. But I promise to use trad-frame for the next target
I'm working on resurrecting, which is v850.
But who's going to do this for h8300?
Mark
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RFA] h8300-tdep.c: Rewrite frame code, de-deprecate, ...
2005-04-29 14:35 ` Mark Kettenis
@ 2005-05-02 15:25 ` Corinna Vinschen
0 siblings, 0 replies; 7+ messages in thread
From: Corinna Vinschen @ 2005-05-02 15:25 UTC (permalink / raw)
To: gdb-patches
On Apr 29 16:35, Mark Kettenis wrote:
> From: Corinna Vinschen <vinschen@redhat.com>
> I promise to use trad-frame for the next target
> I'm working on resurrecting, which is v850.
>
> But who's going to do this for h8300?
No worries. Probably I at one point.
Corinna
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat, Inc.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2005-05-02 15:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-04-28 15:33 [RFA] h8300-tdep.c: Rewrite frame code, de-deprecate, Corinna Vinschen
2005-04-28 19:03 ` Daniel Jacobowitz
2005-04-29 9:11 ` Corinna Vinschen
2005-04-29 13:35 ` Daniel Jacobowitz
2005-04-29 14:25 ` Corinna Vinschen
2005-04-29 14:35 ` Mark Kettenis
2005-05-02 15:25 ` Corinna Vinschen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox