From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 969 invoked by alias); 29 Apr 2005 13:35:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 899 invoked from network); 29 Apr 2005 13:35:35 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 29 Apr 2005 13:35:35 -0000 Received: from drow by nevyn.them.org with local (Exim 4.50 #1 (Debian)) id 1DRVeZ-0005Qw-5z for ; Fri, 29 Apr 2005 09:35:35 -0400 Date: Fri, 29 Apr 2005 13:35:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [RFA] h8300-tdep.c: Rewrite frame code, de-deprecate, ... Message-ID: <20050429133535.GB19942@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20050428153232.GD2572@calimero.vinschen.de> <20050428190307.GA11632@nevyn.them.org> <20050429091018.GN2572@calimero.vinschen.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050429091018.GN2572@calimero.vinschen.de> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-04/txt/msg00422.txt.bz2 On Fri, Apr 29, 2005 at 11:10:18AM +0200, Corinna Vinschen wrote: > On Apr 28 15:03, Daniel Jacobowitz wrote: > > On Thu, Apr 28, 2005 at 05:32:32PM +0200, Corinna Vinschen wrote: > > > > I know it's a pain, but please write a real changelog entry. > > Sigh, ok, see below. Thank you. > > > + /* Saved registers. */ > > > + CORE_ADDR saved_regs[H8300_MAX_NUM_REGS]; > > > + CORE_ADDR saved_sp; > > > +}; > > > > Can you use trad-frame.h instead of an array of CORE_ADDRs? > > I rather would not. Using the saved_regs technique is used throughout > GDB in a couple of targets and I really don't see any advantage in using > trad-frame.h. Actually IMHO using saved_regs directly is a lot easier > to read for people examining the code. It's not that it is "used throughout GDB", it's that it's a pre-existing technique. We've been trying to migrate away from it. Nine targets do use it, fifteen have been updated not to. Using it improves consistency and reduces duplicated code - it would eliminate the entire contents of h8300_frame_prev_register, for instance. If there is something about the trad_frame interface that you find hard to read, could you be more specific, so that we can improve the interface? In any case, I am not interested in an argument, I've got enough of those already :-) The patch is OK. As followups, you should probably: - Re-add the h8300-tdep.o to Makefile.in. - Update the h8300 entry in MAINTAINERS to say "--target=h8300-elf ,-Werror". These should have been done when the target was restored, but they were missed. -- Daniel Jacobowitz CodeSourcery, LLC