Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Andrew Cagney <cagney@gnu.org>
Cc: Baurjan Ismagulov <ibr@ata.cs.hun.edu.tr>,
	gdb-patches@sources.redhat.com
Subject: Re: an i18n sample
Date: Sun, 12 Dec 2004 18:42:00 -0000	[thread overview]
Message-ID: <20041212183458.GA14438@nevyn.them.org> (raw)
In-Reply-To: <41BC7887.3050701@gnu.org>

On Sun, Dec 12, 2004 at 11:57:43AM -0500, Andrew Cagney wrote:
> Baurjan Ismagulov wrote:
> >On Sat, Dec 04, 2004 at 08:41:02PM +0100, Baurjan Ismagulov wrote:
> >
> >>On Sun, Nov 28, 2004 at 12:14:59AM +0200, Eli Zaretskii wrote:
> >>
> >>>Very good, thanks.
> >>
> >>Would you like to apply this?
> >
> >
> >Corrected the concatenation style.
> 
> Baurjan, I really appologise here, but people should have known better 
> than to request that you also make cosmetic changes such as switching 
> from this:

Andrew, thank you so much for _apologizing profusely_ for me, and then
_approving_ and _committing_ a patch containing style changes that I
_objected_ to.  Do you begin to see why I dislike working with you?
Do you at least acknowledge that you are being rude to me?

Baurjan did not preserve the existing style of concatenation; he
changed it to be uniform, to the one I object to (for the reasons I
gave).  If you disagree with my reasons, then let's discuss that
instead of you executively overriding them.  Neither the GNU nor GDB
coding style expresses a preference here.  Baurjan and I both prefer
the concatenation style for aesthetic reasons and no one else chose to
express an opinion.

> The former style is used for for a clear and simple reason - it greatly 
> simplifies the challenge of ensuring that the lines are <80 characters. 

It also makes the source code much harder to skim through, because it
masks the indentation of the containing statement.  And it makes diff
-p less useful.

-- 
Daniel Jacobowitz


  reply	other threads:[~2004-12-12 18:35 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-24 10:45 Baurjan Ismagulov
2004-10-24 19:28 ` Eli Zaretskii
2004-10-24 19:57   ` Baurjan Ismagulov
2004-10-24 20:18   ` Daniel Jacobowitz
2004-10-25 20:10     ` Eli Zaretskii
2004-10-25 20:20       ` Daniel Jacobowitz
2004-10-26  4:47         ` Eli Zaretskii
2004-10-26 20:02           ` Daniel Jacobowitz
2004-10-27  5:03             ` Eli Zaretskii
2004-10-25 21:59   ` Andrew Cagney
2004-10-26  5:02     ` Eli Zaretskii
2004-10-26  7:54       ` Baurjan Ismagulov
2004-10-26 19:56         ` Eli Zaretskii
2004-10-27 17:28           ` Andrew Cagney
2004-11-27 20:54 ` Baurjan Ismagulov
2004-11-27 22:18   ` Eli Zaretskii
2004-11-27 22:54     ` Baurjan Ismagulov
2004-12-04 19:55     ` Baurjan Ismagulov
2004-12-04 22:31       ` Baurjan Ismagulov
2004-12-12 17:12         ` Andrew Cagney
2004-12-12 18:42           ` Daniel Jacobowitz [this message]
2004-12-12 21:07             ` Andrew Cagney
2004-12-13  3:37               ` Eli Zaretskii
2004-12-04 23:04       ` Eli Zaretskii
2004-12-05 23:46     ` Baurjan Ismagulov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041212183458.GA14438@nevyn.them.org \
    --to=drow@false.org \
    --cc=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=ibr@ata.cs.hun.edu.tr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox