From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19494 invoked by alias); 12 Dec 2004 18:35:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19453 invoked from network); 12 Dec 2004 18:35:09 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sourceware.org with SMTP; 12 Dec 2004 18:35:09 -0000 Received: from drow by nevyn.them.org with local (Exim 4.34 #1 (Debian)) id 1CdYYd-0003pX-4W; Sun, 12 Dec 2004 13:34:59 -0500 Date: Sun, 12 Dec 2004 18:42:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: Baurjan Ismagulov , gdb-patches@sources.redhat.com Subject: Re: an i18n sample Message-ID: <20041212183458.GA14438@nevyn.them.org> Mail-Followup-To: Andrew Cagney , Baurjan Ismagulov , gdb-patches@sources.redhat.com References: <20041024104805.GA2369@ata.cs.hun.edu.tr> <20041127205606.GF12080@ata.cs.hun.edu.tr> <01c4d4ce$Blat.v2.2.2$adeda280@zahav.net.il> <20041204194102.GB8003@ata.cs.hun.edu.tr> <20041204221947.GA3433@ata.cs.hun.edu.tr> <41BC7887.3050701@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <41BC7887.3050701@gnu.org> User-Agent: Mutt/1.5.5.1+cvs20040105i X-SW-Source: 2004-12/txt/msg00344.txt.bz2 On Sun, Dec 12, 2004 at 11:57:43AM -0500, Andrew Cagney wrote: > Baurjan Ismagulov wrote: > >On Sat, Dec 04, 2004 at 08:41:02PM +0100, Baurjan Ismagulov wrote: > > > >>On Sun, Nov 28, 2004 at 12:14:59AM +0200, Eli Zaretskii wrote: > >> > >>>Very good, thanks. > >> > >>Would you like to apply this? > > > > > >Corrected the concatenation style. > > Baurjan, I really appologise here, but people should have known better > than to request that you also make cosmetic changes such as switching > from this: Andrew, thank you so much for _apologizing profusely_ for me, and then _approving_ and _committing_ a patch containing style changes that I _objected_ to. Do you begin to see why I dislike working with you? Do you at least acknowledge that you are being rude to me? Baurjan did not preserve the existing style of concatenation; he changed it to be uniform, to the one I object to (for the reasons I gave). If you disagree with my reasons, then let's discuss that instead of you executively overriding them. Neither the GNU nor GDB coding style expresses a preference here. Baurjan and I both prefer the concatenation style for aesthetic reasons and no one else chose to express an opinion. > The former style is used for for a clear and simple reason - it greatly > simplifies the challenge of ensuring that the lines are <80 characters. It also makes the source code much harder to skim through, because it masks the indentation of the containing statement. And it makes diff -p less useful. -- Daniel Jacobowitz