From: Andrew Cagney <cagney@gnu.org>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com,
Michael Elizabeth Chastain <mec.gnu@mindspring.com>,
vinschen@redhat.com
Subject: Re: [RFC/RFA] gdb.cp/classes.exp: Don't try to print local variable out of scope
Date: Fri, 19 Mar 2004 00:09:00 -0000 [thread overview]
Message-ID: <404F4BB6.4010207@gnu.org> (raw)
Message-ID: <20040319000900.ZG5rkx3JpNlf1RrtVEANkfplbVPGt4k_Qzwd2l3CqXo@z> (raw)
In-Reply-To: <20040310032351.GA16933@nevyn.them.org>
> On Tue, Mar 09, 2004 at 10:05:29PM -0500, Daniel Jacobowitz wrote:
>
>>> Think about this for a moment. I'm going to give addresses so that I
>>> can be more precise.
>>>
>>> 0x10 <stuff>: ret stuff(int) { }
>>> 0x20 <main>: push main() {
>>> 0x21 <main+1>: push {
>>> 0x22 <main+2>: move arg1, i stuff(i)
>>> 0x23 <main+3>: call stuff "
>>> 0x24 <main+4>: pop }
>>> 0x25 <main+5>: pop }
>>> 0x26 <main+6>: ret "
>>>
>>> The inner scope is probably <main+2> to <main+3> inclusive.
It is "pc in [<main+2>,<main+4>]" -- only after executing the
instuction at <main+4> is the inner most scope destroyed.
>>>
>>> Suppose PC == 0x10. We backtrace. Look at main; saved PC is 0x24. We
>>> want an address in the block. We subtract 1. OK, saved addr-in-block
>>> is 0x23. 'i' is in scope.
In your example there isn't a need to substract one -- the return
address <main+4> is still inside the correct block (it does no harm though).
>>> Suppose PC == 0x24. Shouldn't this be the same? For the purposes of
>>> looking at local variables, aren't we still in the the block?
PC=24 (that "<main+4>)" edge case) is also in the correct block.
>>> Suppose PC was 0x24 and we got a signal. Ditto.
>>>
>>> Suppose PC == 0x20 and we get a signal. Obviously we don't want to
>>> change the behavior of this.
Now consider this example:
>>> 10 0x10 <stuff>: ret stuff(int) { }
>>> 11 0x20 <main>: push main() {
>>> 12 0x21 <main+1>: push {
>>> 13 0x22 <main+2>: move arg1, i stuff(i)
>>> 14 0x23 <main+3>: call stuff "
>>> 15 }
>>> 16 0x25 <main+5>: pop 2; ret }
Note how that closing brace @15 doesn't have code associated with it.
Its possible to breakpoint @14 or @16 only. Consequently:
- the return address will be @16 and is _out_ of scope
hence "@16 - 1" is needed to find the correct block when doing a backtrace
- once returned from stuff(), the pc is clearly @16 which, to the user,
will visibly reflect the departure from the inner scope
> BTW, my proposed replacement is woefully inaccurate, which I should
> have realized before posting. I do not have a good solution to this
> problem without actually turning back time :)
I'm wondering what the 3.4 wierdness MichaelC's refering to is.
Andrew
next prev parent reply other threads:[~2004-03-10 22:21 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-19 0:09 Michael Elizabeth Chastain
2004-03-09 16:15 ` Michael Elizabeth Chastain
2004-03-19 0:09 ` Andrew Cagney
2004-03-09 20:38 ` Andrew Cagney
2004-03-09 21:27 ` Daniel Jacobowitz
2004-03-09 22:32 ` Andrew Cagney
2004-03-19 0:09 ` Andrew Cagney
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-10 0:56 ` Daniel Jacobowitz
2004-03-19 0:09 ` Andrew Cagney
2004-03-10 1:51 ` Andrew Cagney
2004-03-10 3:05 ` Daniel Jacobowitz
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-10 3:23 ` Daniel Jacobowitz
2004-03-10 22:21 ` Andrew Cagney [this message]
2004-03-10 22:29 ` Daniel Jacobowitz
2004-03-15 18:47 ` Andrew Cagney
2004-03-19 0:09 ` Andrew Cagney
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-19 0:09 ` Andrew Cagney
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-19 0:09 Michael Elizabeth Chastain
2004-03-10 2:06 ` Michael Elizabeth Chastain
2004-03-19 0:09 Corinna Vinschen
2004-03-09 13:00 ` Corinna Vinschen
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-09 14:17 ` Daniel Jacobowitz
2004-03-19 0:09 Michael Elizabeth Chastain
2004-03-10 23:58 ` Michael Elizabeth Chastain
2004-03-19 0:09 Michael Elizabeth Chastain
2004-03-09 15:27 ` Michael Elizabeth Chastain
2004-03-19 0:09 Michael Elizabeth Chastain
2004-03-09 15:11 ` Michael Elizabeth Chastain
2004-03-09 15:40 ` Corinna Vinschen
2004-03-19 0:09 ` Corinna Vinschen
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-09 15:20 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=404F4BB6.4010207@gnu.org \
--to=cagney@gnu.org \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=mec.gnu@mindspring.com \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox