From: Daniel Jacobowitz <drow@false.org>
To: Andrew Cagney <cagney@gnu.org>
Cc: Michael Elizabeth Chastain <mec.gnu@mindspring.com>,
gdb-patches@sources.redhat.com, vinschen@redhat.com
Subject: Re: [RFC/RFA] gdb.cp/classes.exp: Don't try to print local variable out of scope
Date: Fri, 19 Mar 2004 00:09:00 -0000 [thread overview]
Message-ID: <20040310030528.GB16230@nevyn.them.org> (raw)
Message-ID: <20040319000900.UK4ahQLN-pFQsxd0sjSPRr9Fm-UyH7I4Z3VAbDyDZPI@z> (raw)
In-Reply-To: <404E7489.4010209@gnu.org>
On Tue, Mar 09, 2004 at 08:51:05PM -0500, Andrew Cagney wrote:
>
> >BTW, I think the NORMAL_FRAME check is wrong too:
> >
> > {
> > int i;
> > stuff (i);
> >-> }
> >
> >get signal
>
> Er, hold on. The intent of address-in-block is:
>
> /* An address (not necessarily alligned to an instruction boundary)
> that falls within THIS frame's code block.
>
> When a function call is the last statement in a block, the return
> address for the call may land at the start of the next block.
> Similarly, if a no-return function call is the last statement in
> the function, the return address may end up pointing beyond the
> function, and possibly at the start of the next function.
> The only way to get a PC pointing at the first instruction of a function
> is for that function to have been interrupted just as that first
> instruction was about to be executed -- thats the very case where the
> existing address_in_block correctly leaves the PC as is.
>
> In the example in question:
>
> >
> > {
> > int i;
> > stuff (i);
> > -> }
>
> the existing code correctly puts the PC at the instruction about to
> destroy the prologue.
Think about this for a moment. I'm going to give addresses so that I
can be more precise.
0x10 <stuff>: ret stuff(int) { }
0x20 <main>: push main() {
0x21 <main+1>: push {
0x22 <main+2>: move arg1, i stuff(i)
0x23 <main+3>: call stuff "
0x24 <main+4>: pop }
0x25 <main+5>: pop }
0x26 <main+6>: ret "
The inner scope is probably <main+2> to <main+3> inclusive.
Suppose PC == 0x10. We backtrace. Look at main; saved PC is 0x24. We
want an address in the block. We subtract 1. OK, saved addr-in-block
is 0x23. 'i' is in scope.
Suppose PC == 0x24. Shouldn't this be the same? For the purposes of
looking at local variables, aren't we still in the the block?
Suppose PC was 0x24 and we got a signal. Ditto.
Suppose PC == 0x20 and we get a signal. Obviously we don't want to
change the behavior of this.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2004-03-10 3:05 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-19 0:09 Michael Elizabeth Chastain
2004-03-09 16:15 ` Michael Elizabeth Chastain
2004-03-19 0:09 ` Andrew Cagney
2004-03-09 20:38 ` Andrew Cagney
2004-03-09 21:27 ` Daniel Jacobowitz
2004-03-09 22:32 ` Andrew Cagney
2004-03-19 0:09 ` Andrew Cagney
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-10 0:56 ` Daniel Jacobowitz
2004-03-19 0:09 ` Andrew Cagney
2004-03-10 1:51 ` Andrew Cagney
2004-03-10 3:05 ` Daniel Jacobowitz [this message]
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-10 3:23 ` Daniel Jacobowitz
2004-03-10 22:21 ` Andrew Cagney
2004-03-10 22:29 ` Daniel Jacobowitz
2004-03-15 18:47 ` Andrew Cagney
2004-03-19 0:09 ` Andrew Cagney
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-19 0:09 ` Andrew Cagney
2004-03-19 0:09 ` Daniel Jacobowitz
-- strict thread matches above, loose matches on Subject: below --
2004-03-19 0:09 Michael Elizabeth Chastain
2004-03-10 2:06 ` Michael Elizabeth Chastain
2004-03-19 0:09 Michael Elizabeth Chastain
2004-03-09 15:27 ` Michael Elizabeth Chastain
2004-03-19 0:09 Michael Elizabeth Chastain
2004-03-09 15:11 ` Michael Elizabeth Chastain
2004-03-09 15:40 ` Corinna Vinschen
2004-03-19 0:09 ` Corinna Vinschen
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-09 15:20 ` Daniel Jacobowitz
2004-03-19 0:09 Corinna Vinschen
2004-03-09 13:00 ` Corinna Vinschen
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-09 14:17 ` Daniel Jacobowitz
2004-03-19 0:09 Michael Elizabeth Chastain
2004-03-10 23:58 ` Michael Elizabeth Chastain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040310030528.GB16230@nevyn.them.org \
--to=drow@false.org \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=mec.gnu@mindspring.com \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox