* [RFA] Fix apparent typo in pc-fp.exp
@ 2004-03-02 21:43 Fred Fish
2004-03-05 5:15 ` Andrew Cagney
2004-03-19 0:09 ` Fred Fish
0 siblings, 2 replies; 4+ messages in thread
From: Fred Fish @ 2004-03-02 21:43 UTC (permalink / raw)
To: gdb-patches; +Cc: fnf
I ran into a case where gdb was timing out in the get_valueofx proc,
resulting in an expect error:
FAIL: gdb.base/pc-fp.exp: get value of $pc (timeout)
ERROR: tcl error sourcing pc-fp.exp.
ERROR: can't read "val": no such variable
This looks like the obvious fix to me; probably a simple typo that has
gone unnoticed/unexercised until now.
-Fred
2004-03-02 Fred Fish <fnf@redhat.com>
* gdb.base/pc-fp.exp (get_valueofx): Fix apparent typo to now set
"val" instead of unused "size".
Index: gdb.base/pc-fp.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/pc-fp.exp,v
retrieving revision 1.1
diff -c -p -r1.1 pc-fp.exp
*** gdb.base/pc-fp.exp 25 Sep 2002 20:30:38 -0000 1.1
--- gdb.base/pc-fp.exp 2 Mar 2004 21:37:22 -0000
*************** proc get_valueofx { fmt exp default } {
*** 65,71 ****
pass "get value of ${exp} ($val)"
}
timeout {
! set size ${default}
fail "get value of ${exp} (timeout)"
}
}
--- 65,71 ----
pass "get value of ${exp} ($val)"
}
timeout {
! set val ${default}
fail "get value of ${exp} (timeout)"
}
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] Fix apparent typo in pc-fp.exp
2004-03-02 21:43 [RFA] Fix apparent typo in pc-fp.exp Fred Fish
@ 2004-03-05 5:15 ` Andrew Cagney
2004-03-19 0:09 ` Andrew Cagney
2004-03-19 0:09 ` Fred Fish
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Cagney @ 2004-03-05 5:15 UTC (permalink / raw)
To: fnf; +Cc: gdb-patches
> I ran into a case where gdb was timing out in the get_valueofx proc,
> resulting in an expect error:
>
> FAIL: gdb.base/pc-fp.exp: get value of $pc (timeout)
> ERROR: tcl error sourcing pc-fp.exp.
> ERROR: can't read "val": no such variable
>
> This looks like the obvious fix to me; probably a simple typo that has
> gone unnoticed/unexercised until now.
>
> -Fred
>
>
> 2004-03-02 Fred Fish <fnf@redhat.com>
>
> * gdb.base/pc-fp.exp (get_valueofx): Fix apparent typo to now set
> "val" instead of unused "size".
Yes, "oops". Probably also for 6.1.
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* [RFA] Fix apparent typo in pc-fp.exp
2004-03-02 21:43 [RFA] Fix apparent typo in pc-fp.exp Fred Fish
2004-03-05 5:15 ` Andrew Cagney
@ 2004-03-19 0:09 ` Fred Fish
1 sibling, 0 replies; 4+ messages in thread
From: Fred Fish @ 2004-03-19 0:09 UTC (permalink / raw)
To: gdb-patches; +Cc: fnf
I ran into a case where gdb was timing out in the get_valueofx proc,
resulting in an expect error:
FAIL: gdb.base/pc-fp.exp: get value of $pc (timeout)
ERROR: tcl error sourcing pc-fp.exp.
ERROR: can't read "val": no such variable
This looks like the obvious fix to me; probably a simple typo that has
gone unnoticed/unexercised until now.
-Fred
2004-03-02 Fred Fish <fnf@redhat.com>
* gdb.base/pc-fp.exp (get_valueofx): Fix apparent typo to now set
"val" instead of unused "size".
Index: gdb.base/pc-fp.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/pc-fp.exp,v
retrieving revision 1.1
diff -c -p -r1.1 pc-fp.exp
*** gdb.base/pc-fp.exp 25 Sep 2002 20:30:38 -0000 1.1
--- gdb.base/pc-fp.exp 2 Mar 2004 21:37:22 -0000
*************** proc get_valueofx { fmt exp default } {
*** 65,71 ****
pass "get value of ${exp} ($val)"
}
timeout {
! set size ${default}
fail "get value of ${exp} (timeout)"
}
}
--- 65,71 ----
pass "get value of ${exp} ($val)"
}
timeout {
! set val ${default}
fail "get value of ${exp} (timeout)"
}
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] Fix apparent typo in pc-fp.exp
2004-03-05 5:15 ` Andrew Cagney
@ 2004-03-19 0:09 ` Andrew Cagney
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Cagney @ 2004-03-19 0:09 UTC (permalink / raw)
To: fnf; +Cc: gdb-patches
> I ran into a case where gdb was timing out in the get_valueofx proc,
> resulting in an expect error:
>
> FAIL: gdb.base/pc-fp.exp: get value of $pc (timeout)
> ERROR: tcl error sourcing pc-fp.exp.
> ERROR: can't read "val": no such variable
>
> This looks like the obvious fix to me; probably a simple typo that has
> gone unnoticed/unexercised until now.
>
> -Fred
>
>
> 2004-03-02 Fred Fish <fnf@redhat.com>
>
> * gdb.base/pc-fp.exp (get_valueofx): Fix apparent typo to now set
> "val" instead of unused "size".
Yes, "oops". Probably also for 6.1.
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-03-05 5:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-03-02 21:43 [RFA] Fix apparent typo in pc-fp.exp Fred Fish
2004-03-05 5:15 ` Andrew Cagney
2004-03-19 0:09 ` Andrew Cagney
2004-03-19 0:09 ` Fred Fish
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox