From: Fred Fish <fnf@ninemoons.com>
To: gdb-patches@sources.redhat.com
Cc: fnf@redhat.com
Subject: [RFA] Fix apparent typo in pc-fp.exp
Date: Tue, 02 Mar 2004 21:43:00 -0000 [thread overview]
Message-ID: <200403021442.43462.fnf@ninemoons.com> (raw)
I ran into a case where gdb was timing out in the get_valueofx proc,
resulting in an expect error:
FAIL: gdb.base/pc-fp.exp: get value of $pc (timeout)
ERROR: tcl error sourcing pc-fp.exp.
ERROR: can't read "val": no such variable
This looks like the obvious fix to me; probably a simple typo that has
gone unnoticed/unexercised until now.
-Fred
2004-03-02 Fred Fish <fnf@redhat.com>
* gdb.base/pc-fp.exp (get_valueofx): Fix apparent typo to now set
"val" instead of unused "size".
Index: gdb.base/pc-fp.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/pc-fp.exp,v
retrieving revision 1.1
diff -c -p -r1.1 pc-fp.exp
*** gdb.base/pc-fp.exp 25 Sep 2002 20:30:38 -0000 1.1
--- gdb.base/pc-fp.exp 2 Mar 2004 21:37:22 -0000
*************** proc get_valueofx { fmt exp default } {
*** 65,71 ****
pass "get value of ${exp} ($val)"
}
timeout {
! set size ${default}
fail "get value of ${exp} (timeout)"
}
}
--- 65,71 ----
pass "get value of ${exp} ($val)"
}
timeout {
! set val ${default}
fail "get value of ${exp} (timeout)"
}
}
WARNING: multiple messages have this Message-ID
From: Fred Fish <fnf@ninemoons.com>
To: gdb-patches@sources.redhat.com
Cc: fnf@redhat.com
Subject: [RFA] Fix apparent typo in pc-fp.exp
Date: Fri, 19 Mar 2004 00:09:00 -0000 [thread overview]
Message-ID: <200403021442.43462.fnf@ninemoons.com> (raw)
Message-ID: <20040319000900.k_d3ru3tebUh0OK-rnuTBW_mx5oBBHZSrVA-dpbbgzw@z> (raw)
I ran into a case where gdb was timing out in the get_valueofx proc,
resulting in an expect error:
FAIL: gdb.base/pc-fp.exp: get value of $pc (timeout)
ERROR: tcl error sourcing pc-fp.exp.
ERROR: can't read "val": no such variable
This looks like the obvious fix to me; probably a simple typo that has
gone unnoticed/unexercised until now.
-Fred
2004-03-02 Fred Fish <fnf@redhat.com>
* gdb.base/pc-fp.exp (get_valueofx): Fix apparent typo to now set
"val" instead of unused "size".
Index: gdb.base/pc-fp.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/pc-fp.exp,v
retrieving revision 1.1
diff -c -p -r1.1 pc-fp.exp
*** gdb.base/pc-fp.exp 25 Sep 2002 20:30:38 -0000 1.1
--- gdb.base/pc-fp.exp 2 Mar 2004 21:37:22 -0000
*************** proc get_valueofx { fmt exp default } {
*** 65,71 ****
pass "get value of ${exp} ($val)"
}
timeout {
! set size ${default}
fail "get value of ${exp} (timeout)"
}
}
--- 65,71 ----
pass "get value of ${exp} ($val)"
}
timeout {
! set val ${default}
fail "get value of ${exp} (timeout)"
}
}
next reply other threads:[~2004-03-02 21:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-02 21:43 Fred Fish [this message]
2004-03-05 5:15 ` Andrew Cagney
2004-03-19 0:09 ` Andrew Cagney
2004-03-19 0:09 ` Fred Fish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200403021442.43462.fnf@ninemoons.com \
--to=fnf@ninemoons.com \
--cc=fnf@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox