From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2471 invoked by alias); 2 Mar 2004 21:43:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2457 invoked from network); 2 Mar 2004 21:43:19 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 2 Mar 2004 21:43:19 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id i22Lh8b18066 for ; Tue, 2 Mar 2004 16:43:18 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i22LglM10023 for ; Tue, 2 Mar 2004 16:43:07 -0500 Received: from 192.168.1.129 (vpn50-52.rdu.redhat.com [172.16.50.52]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i22LgjX12602; Tue, 2 Mar 2004 13:42:46 -0800 From: Fred Fish Reply-To: fnf@redhat.com To: gdb-patches@sources.redhat.com Subject: [RFA] Fix apparent typo in pc-fp.exp Date: Tue, 02 Mar 2004 21:43:00 -0000 User-Agent: KMail/1.5.4 Cc: fnf@redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200403021442.43462.fnf@ninemoons.com> X-SW-Source: 2004-03.o/txt/msg00030.txt I ran into a case where gdb was timing out in the get_valueofx proc, resulting in an expect error: FAIL: gdb.base/pc-fp.exp: get value of $pc (timeout) ERROR: tcl error sourcing pc-fp.exp. ERROR: can't read "val": no such variable This looks like the obvious fix to me; probably a simple typo that has gone unnoticed/unexercised until now. -Fred 2004-03-02 Fred Fish * gdb.base/pc-fp.exp (get_valueofx): Fix apparent typo to now set "val" instead of unused "size". Index: gdb.base/pc-fp.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/pc-fp.exp,v retrieving revision 1.1 diff -c -p -r1.1 pc-fp.exp *** gdb.base/pc-fp.exp 25 Sep 2002 20:30:38 -0000 1.1 --- gdb.base/pc-fp.exp 2 Mar 2004 21:37:22 -0000 *************** proc get_valueofx { fmt exp default } { *** 65,71 **** pass "get value of ${exp} ($val)" } timeout { ! set size ${default} fail "get value of ${exp} (timeout)" } } --- 65,71 ---- pass "get value of ${exp} ($val)" } timeout { ! set val ${default} fail "get value of ${exp} (timeout)" } } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2471 invoked by alias); 2 Mar 2004 21:43:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2457 invoked from network); 2 Mar 2004 21:43:19 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 2 Mar 2004 21:43:19 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id i22Lh8b18066 for ; Tue, 2 Mar 2004 16:43:18 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i22LglM10023 for ; Tue, 2 Mar 2004 16:43:07 -0500 Received: from 192.168.1.129 (vpn50-52.rdu.redhat.com [172.16.50.52]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i22LgjX12602; Tue, 2 Mar 2004 13:42:46 -0800 From: Fred Fish Reply-To: fnf@redhat.com To: gdb-patches@sources.redhat.com Subject: [RFA] Fix apparent typo in pc-fp.exp Date: Fri, 19 Mar 2004 00:09:00 -0000 User-Agent: KMail/1.5.4 Cc: fnf@redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-ID: <200403021442.43462.fnf@ninemoons.com> X-SW-Source: 2004-03/txt/msg00030.txt.bz2 Message-ID: <20040319000900.k_d3ru3tebUh0OK-rnuTBW_mx5oBBHZSrVA-dpbbgzw@z> I ran into a case where gdb was timing out in the get_valueofx proc, resulting in an expect error: FAIL: gdb.base/pc-fp.exp: get value of $pc (timeout) ERROR: tcl error sourcing pc-fp.exp. ERROR: can't read "val": no such variable This looks like the obvious fix to me; probably a simple typo that has gone unnoticed/unexercised until now. -Fred 2004-03-02 Fred Fish * gdb.base/pc-fp.exp (get_valueofx): Fix apparent typo to now set "val" instead of unused "size". Index: gdb.base/pc-fp.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/pc-fp.exp,v retrieving revision 1.1 diff -c -p -r1.1 pc-fp.exp *** gdb.base/pc-fp.exp 25 Sep 2002 20:30:38 -0000 1.1 --- gdb.base/pc-fp.exp 2 Mar 2004 21:37:22 -0000 *************** proc get_valueofx { fmt exp default } { *** 65,71 **** pass "get value of ${exp} ($val)" } timeout { ! set size ${default} fail "get value of ${exp} (timeout)" } } --- 65,71 ---- pass "get value of ${exp} ($val)" } timeout { ! set val ${default} fail "get value of ${exp} (timeout)" } }