From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12009 invoked by alias); 5 Mar 2004 05:15:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11989 invoked from network); 5 Mar 2004 05:15:07 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.170.238) by sources.redhat.com with SMTP; 5 Mar 2004 05:15:07 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id B6AC52B92; Fri, 5 Mar 2004 00:14:48 -0500 (EST) Message-ID: <40480CC8.8090801@gnu.org> Date: Fri, 05 Mar 2004 05:15:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: fnf@redhat.com Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Fix apparent typo in pc-fp.exp References: <200403021442.43462.fnf@ninemoons.com> In-Reply-To: <200403021442.43462.fnf@ninemoons.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-03.o/txt/msg00095.txt > I ran into a case where gdb was timing out in the get_valueofx proc, > resulting in an expect error: > > FAIL: gdb.base/pc-fp.exp: get value of $pc (timeout) > ERROR: tcl error sourcing pc-fp.exp. > ERROR: can't read "val": no such variable > > This looks like the obvious fix to me; probably a simple typo that has > gone unnoticed/unexercised until now. > > -Fred > > > 2004-03-02 Fred Fish > > * gdb.base/pc-fp.exp (get_valueofx): Fix apparent typo to now set > "val" instead of unused "size". Yes, "oops". Probably also for 6.1. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12009 invoked by alias); 5 Mar 2004 05:15:09 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11989 invoked from network); 5 Mar 2004 05:15:07 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.170.238) by sources.redhat.com with SMTP; 5 Mar 2004 05:15:07 -0000 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id B6AC52B92; Fri, 5 Mar 2004 00:14:48 -0500 (EST) Message-ID: <40480CC8.8090801@gnu.org> Date: Fri, 19 Mar 2004 00:09:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: fnf@redhat.com Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Fix apparent typo in pc-fp.exp References: <200403021442.43462.fnf@ninemoons.com> In-Reply-To: <200403021442.43462.fnf@ninemoons.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-03/txt/msg00095.txt.bz2 Message-ID: <20040319000900.F4psKT7p_2QvSvaFvOxusC82pe1Q1jbIUyp1LmADYmg@z> > I ran into a case where gdb was timing out in the get_valueofx proc, > resulting in an expect error: > > FAIL: gdb.base/pc-fp.exp: get value of $pc (timeout) > ERROR: tcl error sourcing pc-fp.exp. > ERROR: can't read "val": no such variable > > This looks like the obvious fix to me; probably a simple typo that has > gone unnoticed/unexercised until now. > > -Fred > > > 2004-03-02 Fred Fish > > * gdb.base/pc-fp.exp (get_valueofx): Fix apparent typo to now set > "val" instead of unused "size". Yes, "oops". Probably also for 6.1. Andrew