From: Mark Kettenis <kettenis@chello.nl>
To: rearnsha@arm.com
Cc: drow@false.org, gdb-patches@sources.redhat.com, rearnsha@arm.com
Subject: Re: [rfa/arm] Fix some structs.exp failures
Date: Wed, 03 Mar 2004 21:35:00 -0000 [thread overview]
Message-ID: <200403032134.i23LYqYD001561@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <200403031729.i23HTi021640@pc960.cambridge.arm.com> (message from Richard Earnshaw on Wed, 03 Mar 2004 17:29:44 +0000)
Date: Wed, 03 Mar 2004 17:29:44 +0000
From: Richard Earnshaw <rearnsha@arm.com>
> structs.exp uses "typedef float tf". A structure type that would
> otherwise be returned by reference is returned by value, because
> GDB doesn't realize that it counts as a floating-point-like
> structure.
>
> OK?
>
> --
> Daniel Jacobowitz
> MontaVista Software Debian GNU/Linux Developer
>
> 2004-03-02 Daniel Jacobowitz <drow@mvista.com>
>
> * arm-tdep.c (arm_use_struct_convention): Look through typedefs.
I think this is OK, but it's hard to be sure: check_typedef is completely
undocumented -- no mention in the internals documentation, and not even a
comment in gdbtypes.[ch].
There is one comment about check_typedef()/CHECK_TYPEDEF() in
gdbtypes.h. Anyway, Daniels fix is OK. Before you look at a type the
way arm_use_struct_convention does, you should have called
check_typedef(), otherwise you'll look at the typedef itself, and not
its underlying type.
Mark
WARNING: multiple messages have this Message-ID
From: Mark Kettenis <kettenis@chello.nl>
To: rearnsha@arm.com
Cc: drow@false.org, gdb-patches@sources.redhat.com, rearnsha@arm.com
Subject: Re: [rfa/arm] Fix some structs.exp failures
Date: Fri, 19 Mar 2004 00:09:00 -0000 [thread overview]
Message-ID: <200403032134.i23LYqYD001561@elgar.kettenis.dyndns.org> (raw)
Message-ID: <20040319000900.UqRqv5uW_HHdFie9p2muQahAUVNog-PzOwLFOGqSp-c@z> (raw)
In-Reply-To: <200403031729.i23HTi021640@pc960.cambridge.arm.com> (message from Richard Earnshaw on Wed, 03 Mar 2004 17:29:44 +0000)
Date: Wed, 03 Mar 2004 17:29:44 +0000
From: Richard Earnshaw <rearnsha@arm.com>
> structs.exp uses "typedef float tf". A structure type that would
> otherwise be returned by reference is returned by value, because
> GDB doesn't realize that it counts as a floating-point-like
> structure.
>
> OK?
>
> --
> Daniel Jacobowitz
> MontaVista Software Debian GNU/Linux Developer
>
> 2004-03-02 Daniel Jacobowitz <drow@mvista.com>
>
> * arm-tdep.c (arm_use_struct_convention): Look through typedefs.
I think this is OK, but it's hard to be sure: check_typedef is completely
undocumented -- no mention in the internals documentation, and not even a
comment in gdbtypes.[ch].
There is one comment about check_typedef()/CHECK_TYPEDEF() in
gdbtypes.h. Anyway, Daniels fix is OK. Before you look at a type the
way arm_use_struct_convention does, you should have called
check_typedef(), otherwise you'll look at the typedef itself, and not
its underlying type.
Mark
next prev parent reply other threads:[~2004-03-03 21:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-02 17:17 Daniel Jacobowitz
2004-03-03 17:29 ` Richard Earnshaw
2004-03-03 21:35 ` Mark Kettenis [this message]
2004-03-04 9:58 ` Richard Earnshaw
2004-03-19 0:09 ` Richard Earnshaw
2004-03-19 0:09 ` Mark Kettenis
2004-03-09 17:11 ` Daniel Jacobowitz
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-19 0:09 ` Richard Earnshaw
2004-03-19 0:09 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200403032134.i23LYqYD001561@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=rearnsha@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox