From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com
Cc: rearnsha@arm.com
Subject: [rfa/arm] Fix some structs.exp failures
Date: Tue, 02 Mar 2004 17:17:00 -0000 [thread overview]
Message-ID: <20040302171658.GA24060@nevyn.them.org> (raw)
structs.exp uses "typedef float tf". A structure type that would otherwise
be returned by reference is returned by value, because GDB doesn't realize
that it counts as a floating-point-like structure.
OK?
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
2004-03-02 Daniel Jacobowitz <drow@mvista.com>
* arm-tdep.c (arm_use_struct_convention): Look through typedefs.
Index: gdb/arm-tdep.c
===================================================================
RCS file: /big/fsf/rsync/src-cvs/src/gdb/arm-tdep.c,v
retrieving revision 1.164
diff -u -p -r1.164 arm-tdep.c
--- gdb/arm-tdep.c 16 Feb 2004 21:49:21 -0000 1.164
+++ gdb/arm-tdep.c 2 Mar 2004 17:11:25 -0000
@@ -2141,6 +2142,8 @@ arm_use_struct_convention (int gcc_p, st
int nRc;
enum type_code code;
+ CHECK_TYPEDEF (type);
+
/* In the ARM ABI, "integer" like aggregate types are returned in
registers. For an aggregate type to be integer like, its size
must be less than or equal to DEPRECATED_REGISTER_SIZE and the
@@ -2198,7 +2201,7 @@ arm_use_struct_convention (int gcc_p, st
for (i = 0; i < TYPE_NFIELDS (type); i++)
{
enum type_code field_type_code;
- field_type_code = TYPE_CODE (TYPE_FIELD_TYPE (type, i));
+ field_type_code = TYPE_CODE (check_typedef (TYPE_FIELD_TYPE (type, i)));
/* Is it a floating point type field? */
if (field_type_code == TYPE_CODE_FLT)
WARNING: multiple messages have this Message-ID
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com
Cc: rearnsha@arm.com
Subject: [rfa/arm] Fix some structs.exp failures
Date: Fri, 19 Mar 2004 00:09:00 -0000 [thread overview]
Message-ID: <20040302171658.GA24060@nevyn.them.org> (raw)
Message-ID: <20040319000900.4-4MFBXp78UQWqOKZqA9YjsmJnoWDpXEwkeL2Bs0nJ4@z> (raw)
structs.exp uses "typedef float tf". A structure type that would otherwise
be returned by reference is returned by value, because GDB doesn't realize
that it counts as a floating-point-like structure.
OK?
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
2004-03-02 Daniel Jacobowitz <drow@mvista.com>
* arm-tdep.c (arm_use_struct_convention): Look through typedefs.
Index: gdb/arm-tdep.c
===================================================================
RCS file: /big/fsf/rsync/src-cvs/src/gdb/arm-tdep.c,v
retrieving revision 1.164
diff -u -p -r1.164 arm-tdep.c
--- gdb/arm-tdep.c 16 Feb 2004 21:49:21 -0000 1.164
+++ gdb/arm-tdep.c 2 Mar 2004 17:11:25 -0000
@@ -2141,6 +2142,8 @@ arm_use_struct_convention (int gcc_p, st
int nRc;
enum type_code code;
+ CHECK_TYPEDEF (type);
+
/* In the ARM ABI, "integer" like aggregate types are returned in
registers. For an aggregate type to be integer like, its size
must be less than or equal to DEPRECATED_REGISTER_SIZE and the
@@ -2198,7 +2201,7 @@ arm_use_struct_convention (int gcc_p, st
for (i = 0; i < TYPE_NFIELDS (type); i++)
{
enum type_code field_type_code;
- field_type_code = TYPE_CODE (TYPE_FIELD_TYPE (type, i));
+ field_type_code = TYPE_CODE (check_typedef (TYPE_FIELD_TYPE (type, i)));
/* Is it a floating point type field? */
if (field_type_code == TYPE_CODE_FLT)
next reply other threads:[~2004-03-02 17:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-02 17:17 Daniel Jacobowitz [this message]
2004-03-03 17:29 ` Richard Earnshaw
2004-03-03 21:35 ` Mark Kettenis
2004-03-04 9:58 ` Richard Earnshaw
2004-03-19 0:09 ` Richard Earnshaw
2004-03-19 0:09 ` Mark Kettenis
2004-03-09 17:11 ` Daniel Jacobowitz
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-19 0:09 ` Richard Earnshaw
2004-03-19 0:09 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040302171658.GA24060@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=rearnsha@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox