Re: [rfa/arm] Fix some structs.exp failures

[Daniel Jacobowitz <drow@false.org>]

On Wed, Mar 03, 2004 at 05:29:44PM +0000, Richard Earnshaw wrote:
> > structs.exp uses "typedef float tf".  A structure type that would otherwise
> > be returned by reference is returned by value, because GDB doesn't realize
> > that it counts as a floating-point-like structure.
> > 
> > OK?
> > 
> > -- 
> > Daniel Jacobowitz
> > MontaVista Software                         Debian GNU/Linux Developer
> > 
> > 2004-03-02  Daniel Jacobowitz  <drow@mvista.com>
> > 
> > 	* arm-tdep.c (arm_use_struct_convention): Look through typedefs.
> 
> I think this is OK, but it's hard to be sure:  check_typedef is completely 
> undocumented -- no mention in the internals documentation, and not even a 
> comment in gdbtypes.[ch].

I can take a hint :)  Here's what I checked in.

Note that there actually is a comment right above check_typedef.  It's
not very clear, though, and another little function has gotten in the
way.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

2004-03-09  Daniel Jacobowitz  <drow@mvista.com>

	* arm-tdep.c (arm_use_struct_convention): Look through typedefs.
	* gdbtypes.c (check_typedef): Update comments.

Index: gdbtypes.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtypes.c,v
retrieving revision 1.81
diff -u -p -r1.81 gdbtypes.c
--- gdbtypes.c	15 Feb 2004 15:22:06 -0000	1.81
+++ gdbtypes.c	9 Mar 2004 17:06:06 -0000
@@ -1343,6 +1343,12 @@ get_destructor_fn_field (struct type *t,
   return 0;
 }
 
+static void
+stub_noname_complaint (void)
+{
+  complaint (&symfile_complaints, "stub type has NULL name");
+}
+
 /* Added by Bryan Boreham, Kewill, Sun Sep 17 18:07:17 1989.
 
    If this is a stubbed struct (i.e. declared as struct foo *), see if
@@ -1356,11 +1362,10 @@ get_destructor_fn_field (struct type *t,
    This used to be coded as a macro, but I don't think it is called 
    often enough to merit such treatment.  */
 
-static void
-stub_noname_complaint (void)
-{
-  complaint (&symfile_complaints, "stub type has NULL name");
-}
+/* Find the real type of TYPE.  This function returns the real type, after
+   removing all layers of typedefs and completing opaque or stub types.
+   Completion changes the TYPE argument, but stripping of typedefs does
+   not.  */
 
 struct type *
 check_typedef (struct type *type)
Index: arm-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-tdep.c,v
retrieving revision 1.166
diff -u -p -r1.166 arm-tdep.c
--- arm-tdep.c	9 Mar 2004 15:44:26 -0000	1.166
+++ arm-tdep.c	9 Mar 2004 17:06:07 -0000
@@ -2173,6 +2173,8 @@ arm_use_struct_convention (int gcc_p, st
   int nRc;
   enum type_code code;
 
+  CHECK_TYPEDEF (type);
+
   /* In the ARM ABI, "integer" like aggregate types are returned in
      registers.  For an aggregate type to be integer like, its size
      must be less than or equal to DEPRECATED_REGISTER_SIZE and the
@@ -2230,7 +2232,7 @@ arm_use_struct_convention (int gcc_p, st
       for (i = 0; i < TYPE_NFIELDS (type); i++)
 	{
 	  enum type_code field_type_code;
-	  field_type_code = TYPE_CODE (TYPE_FIELD_TYPE (type, i));
+	  field_type_code = TYPE_CODE (check_typedef (TYPE_FIELD_TYPE (type, i)));
 
 	  /* Is it a floating point type field?  */
 	  if (field_type_code == TYPE_CODE_FLT)