From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12763 invoked by alias); 3 Mar 2004 21:35:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12755 invoked from network); 3 Mar 2004 21:35:44 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144) by sources.redhat.com with SMTP; 3 Mar 2004 21:35:44 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i23LYr0u001347; Wed, 3 Mar 2004 22:34:53 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i23LYrEU001564; Wed, 3 Mar 2004 22:34:53 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i23LYqYD001561; Wed, 3 Mar 2004 22:34:52 +0100 (CET) Date: Wed, 03 Mar 2004 21:35:00 -0000 Message-Id: <200403032134.i23LYqYD001561@elgar.kettenis.dyndns.org> From: Mark Kettenis To: rearnsha@arm.com CC: drow@false.org, gdb-patches@sources.redhat.com, rearnsha@arm.com In-reply-to: <200403031729.i23HTi021640@pc960.cambridge.arm.com> (message from Richard Earnshaw on Wed, 03 Mar 2004 17:29:44 +0000) Subject: Re: [rfa/arm] Fix some structs.exp failures References: <200403031729.i23HTi021640@pc960.cambridge.arm.com> X-SW-Source: 2004-03.o/txt/msg00063.txt Date: Wed, 03 Mar 2004 17:29:44 +0000 From: Richard Earnshaw > structs.exp uses "typedef float tf". A structure type that would > otherwise be returned by reference is returned by value, because > GDB doesn't realize that it counts as a floating-point-like > structure. > > OK? > > -- > Daniel Jacobowitz > MontaVista Software Debian GNU/Linux Developer > > 2004-03-02 Daniel Jacobowitz > > * arm-tdep.c (arm_use_struct_convention): Look through typedefs. I think this is OK, but it's hard to be sure: check_typedef is completely undocumented -- no mention in the internals documentation, and not even a comment in gdbtypes.[ch]. There is one comment about check_typedef()/CHECK_TYPEDEF() in gdbtypes.h. Anyway, Daniels fix is OK. Before you look at a type the way arm_use_struct_convention does, you should have called check_typedef(), otherwise you'll look at the typedef itself, and not its underlying type. Mark From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12763 invoked by alias); 3 Mar 2004 21:35:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12755 invoked from network); 3 Mar 2004 21:35:44 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144) by sources.redhat.com with SMTP; 3 Mar 2004 21:35:44 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i23LYr0u001347; Wed, 3 Mar 2004 22:34:53 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i23LYrEU001564; Wed, 3 Mar 2004 22:34:53 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i23LYqYD001561; Wed, 3 Mar 2004 22:34:52 +0100 (CET) Date: Fri, 19 Mar 2004 00:09:00 -0000 Message-ID: <200403032134.i23LYqYD001561@elgar.kettenis.dyndns.org> From: Mark Kettenis To: rearnsha@arm.com CC: drow@false.org, gdb-patches@sources.redhat.com, rearnsha@arm.com In-reply-to: <200403031729.i23HTi021640@pc960.cambridge.arm.com> (message from Richard Earnshaw on Wed, 03 Mar 2004 17:29:44 +0000) Subject: Re: [rfa/arm] Fix some structs.exp failures References: <200403031729.i23HTi021640@pc960.cambridge.arm.com> X-SW-Source: 2004-03/txt/msg00063.txt.bz2 Message-ID: <20040319000900.UqRqv5uW_HHdFie9p2muQahAUVNog-PzOwLFOGqSp-c@z> Date: Wed, 03 Mar 2004 17:29:44 +0000 From: Richard Earnshaw > structs.exp uses "typedef float tf". A structure type that would > otherwise be returned by reference is returned by value, because > GDB doesn't realize that it counts as a floating-point-like > structure. > > OK? > > -- > Daniel Jacobowitz > MontaVista Software Debian GNU/Linux Developer > > 2004-03-02 Daniel Jacobowitz > > * arm-tdep.c (arm_use_struct_convention): Look through typedefs. I think this is OK, but it's hard to be sure: check_typedef is completely undocumented -- no mention in the internals documentation, and not even a comment in gdbtypes.[ch]. There is one comment about check_typedef()/CHECK_TYPEDEF() in gdbtypes.h. Anyway, Daniels fix is OK. Before you look at a type the way arm_use_struct_convention does, you should have called check_typedef(), otherwise you'll look at the typedef itself, and not its underlying type. Mark