* PATCH: Make sure gdb-cfg.texi is created
@ 2003-05-09 19:24 H. J. Lu
2003-05-09 19:34 ` Daniel Jacobowitz
2003-05-10 9:49 ` Eli Zaretskii
0 siblings, 2 replies; 12+ messages in thread
From: H. J. Lu @ 2003-05-09 19:24 UTC (permalink / raw)
To: GDB
[-- Attachment #1: Type: text/plain, Size: 143 bytes --]
My gdb source tree is created with relative symlinks. ln -s won't work
with them. Here is a patch to make sure gdb-cfg.texi is created.
H.J.
[-- Attachment #2: gdb-link.patch --]
[-- Type: text/plain, Size: 991 bytes --]
2003-05-09 H.J. Lu <hongjiu.lu@intel.com>
* Makefile.in (gdb-cfg.texi): Make sure it is created.
--- gdb/doc/Makefile.in.link 2003-04-02 16:40:17.000000000 -0800
+++ gdb/doc/Makefile.in 2003-05-09 12:19:13.000000000 -0700
@@ -246,9 +246,13 @@ GDBvn.texi : ${gdbdir}/version.in
# defined anyways).
gdb-cfg.texi: ${srcdir}/${DOC_CONFIG}-cfg.texi
(test "$$LN_S" = "ln -s" && \
- ln -s ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi) || \
- ln ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi || \
- cp ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi
+ ln -s ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi && \
+ test -e gdb-cfg.texi) || \
+ (rm -f gdb-cfg.texi && \
+ ln ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi && \
+ test -e gdb-cfg.texi) || \
+ (rm -f gdb-cfg.texi && \
+ cp ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi)
# GDB MANUAL: texinfo source, using @set/@clear/@value/@ifset/@ifclear
# If your texinfo or makeinfo don't support these, get a new texinfo release
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: PATCH: Make sure gdb-cfg.texi is created
2003-05-09 19:24 PATCH: Make sure gdb-cfg.texi is created H. J. Lu
@ 2003-05-09 19:34 ` Daniel Jacobowitz
2003-05-09 19:59 ` H. J. Lu
2003-05-10 9:49 ` Eli Zaretskii
1 sibling, 1 reply; 12+ messages in thread
From: Daniel Jacobowitz @ 2003-05-09 19:34 UTC (permalink / raw)
To: H. J. Lu; +Cc: GDB
On Fri, May 09, 2003 at 12:24:34PM -0700, H. J. Lu wrote:
> My gdb source tree is created with relative symlinks. ln -s won't work
> with them. Here is a patch to make sure gdb-cfg.texi is created.
That patch doesn't make sense. You're saying that ln -s can succeed
when test -e would fail?
> 2003-05-09 H.J. Lu <hongjiu.lu@intel.com>
>
> * Makefile.in (gdb-cfg.texi): Make sure it is created.
>
> --- gdb/doc/Makefile.in.link 2003-04-02 16:40:17.000000000 -0800
> +++ gdb/doc/Makefile.in 2003-05-09 12:19:13.000000000 -0700
> @@ -246,9 +246,13 @@ GDBvn.texi : ${gdbdir}/version.in
> # defined anyways).
> gdb-cfg.texi: ${srcdir}/${DOC_CONFIG}-cfg.texi
> (test "$$LN_S" = "ln -s" && \
> - ln -s ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi) || \
> - ln ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi || \
> - cp ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi
> + ln -s ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi && \
> + test -e gdb-cfg.texi) || \
> + (rm -f gdb-cfg.texi && \
> + ln ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi && \
> + test -e gdb-cfg.texi) || \
> + (rm -f gdb-cfg.texi && \
> + cp ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi)
>
> # GDB MANUAL: texinfo source, using @set/@clear/@value/@ifset/@ifclear
> # If your texinfo or makeinfo don't support these, get a new texinfo release
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: PATCH: Make sure gdb-cfg.texi is created
2003-05-09 19:34 ` Daniel Jacobowitz
@ 2003-05-09 19:59 ` H. J. Lu
2003-05-09 20:06 ` Daniel Jacobowitz
0 siblings, 1 reply; 12+ messages in thread
From: H. J. Lu @ 2003-05-09 19:59 UTC (permalink / raw)
To: GDB
On Fri, May 09, 2003 at 03:32:06PM -0400, Daniel Jacobowitz wrote:
> On Fri, May 09, 2003 at 12:24:34PM -0700, H. J. Lu wrote:
> > My gdb source tree is created with relative symlinks. ln -s won't work
> > with them. Here is a patch to make sure gdb-cfg.texi is created.
>
> That patch doesn't make sense. You're saying that ln -s can succeed
> when test -e would fail?
>
I got
# bash
# ln -s "doesn't exist" foo || echo bad
# test -e foo || echo "doesn't exist"
doesn't exist
H.J.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: PATCH: Make sure gdb-cfg.texi is created
2003-05-09 19:59 ` H. J. Lu
@ 2003-05-09 20:06 ` Daniel Jacobowitz
2003-05-09 20:10 ` H. J. Lu
0 siblings, 1 reply; 12+ messages in thread
From: Daniel Jacobowitz @ 2003-05-09 20:06 UTC (permalink / raw)
To: H. J. Lu; +Cc: GDB
On Fri, May 09, 2003 at 12:59:43PM -0700, H. J. Lu wrote:
> On Fri, May 09, 2003 at 03:32:06PM -0400, Daniel Jacobowitz wrote:
> > On Fri, May 09, 2003 at 12:24:34PM -0700, H. J. Lu wrote:
> > > My gdb source tree is created with relative symlinks. ln -s won't work
> > > with them. Here is a patch to make sure gdb-cfg.texi is created.
> >
> > That patch doesn't make sense. You're saying that ln -s can succeed
> > when test -e would fail?
> >
>
> I got
>
> # bash
> # ln -s "doesn't exist" foo || echo bad
> # test -e foo || echo "doesn't exist"
> doesn't exist
Sure, but then why would "ln" or "cp" work from "doesn't exist"?
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: PATCH: Make sure gdb-cfg.texi is created
2003-05-09 20:06 ` Daniel Jacobowitz
@ 2003-05-09 20:10 ` H. J. Lu
2003-05-09 20:18 ` Daniel Jacobowitz
0 siblings, 1 reply; 12+ messages in thread
From: H. J. Lu @ 2003-05-09 20:10 UTC (permalink / raw)
To: GDB
On Fri, May 09, 2003 at 04:06:43PM -0400, Daniel Jacobowitz wrote:
> On Fri, May 09, 2003 at 12:59:43PM -0700, H. J. Lu wrote:
> > On Fri, May 09, 2003 at 03:32:06PM -0400, Daniel Jacobowitz wrote:
> > > On Fri, May 09, 2003 at 12:24:34PM -0700, H. J. Lu wrote:
> > > > My gdb source tree is created with relative symlinks. ln -s won't work
> > > > with them. Here is a patch to make sure gdb-cfg.texi is created.
> > >
> > > That patch doesn't make sense. You're saying that ln -s can succeed
> > > when test -e would fail?
> > >
> >
> > I got
> >
> > # bash
> > # ln -s "doesn't exist" foo || echo bad
> > # test -e foo || echo "doesn't exist"
> > doesn't exist
>
> Sure, but then why would "ln" or "cp" work from "doesn't exist"?
I have a tree with relative symlinks. all-cfg.texi in the source tree
is
# ls -l /export/gnu/src/gdb/gdb/gdb/doc/all-cfg.texi
lrwxrwxrwx 1 hjl hjl 50 May 9 09:58 /export/gnu/src/gdb/gdb/gdb/doc/all-cfg.texi -> ../../../../../import/gdb/src/gdb/doc/all-cfg.texi
Since my build dir != source dir,
../../../../../import/gdb/src/gdb/doc/all-cfg.texi
doesn't exist in my build dir.
H.J.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: PATCH: Make sure gdb-cfg.texi is created
2003-05-09 20:10 ` H. J. Lu
@ 2003-05-09 20:18 ` Daniel Jacobowitz
2003-05-09 20:35 ` H. J. Lu
0 siblings, 1 reply; 12+ messages in thread
From: Daniel Jacobowitz @ 2003-05-09 20:18 UTC (permalink / raw)
To: H. J. Lu; +Cc: GDB
On Fri, May 09, 2003 at 01:10:49PM -0700, H. J. Lu wrote:
> On Fri, May 09, 2003 at 04:06:43PM -0400, Daniel Jacobowitz wrote:
> > On Fri, May 09, 2003 at 12:59:43PM -0700, H. J. Lu wrote:
> > > On Fri, May 09, 2003 at 03:32:06PM -0400, Daniel Jacobowitz wrote:
> > > > On Fri, May 09, 2003 at 12:24:34PM -0700, H. J. Lu wrote:
> > > > > My gdb source tree is created with relative symlinks. ln -s won't work
> > > > > with them. Here is a patch to make sure gdb-cfg.texi is created.
> > > >
> > > > That patch doesn't make sense. You're saying that ln -s can succeed
> > > > when test -e would fail?
> > > >
> > >
> > > I got
> > >
> > > # bash
> > > # ln -s "doesn't exist" foo || echo bad
> > > # test -e foo || echo "doesn't exist"
> > > doesn't exist
> >
> > Sure, but then why would "ln" or "cp" work from "doesn't exist"?
>
> I have a tree with relative symlinks. all-cfg.texi in the source tree
> is
>
> # ls -l /export/gnu/src/gdb/gdb/gdb/doc/all-cfg.texi
> lrwxrwxrwx 1 hjl hjl 50 May 9 09:58 /export/gnu/src/gdb/gdb/gdb/doc/all-cfg.texi -> ../../../../../import/gdb/src/gdb/doc/all-cfg.texi
>
> Since my build dir != source dir,
>
> ../../../../../import/gdb/src/gdb/doc/all-cfg.texi
>
> doesn't exist in my build dir.
Maybe I'm missing something obvious. The link will be created to point
at /export/gnu/src/gdb/gdb/gdb/doc/all-cfg.texi. Whether
../../../../../import/gdb/src/gdb/doc/all-cfg.texi exists from that
directory does not matter. It will be resolved from the directory
containing the second symlink.
Otherwise relative symlinks would never be useful.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: PATCH: Make sure gdb-cfg.texi is created
2003-05-09 20:18 ` Daniel Jacobowitz
@ 2003-05-09 20:35 ` H. J. Lu
2003-05-09 20:42 ` Daniel Jacobowitz
0 siblings, 1 reply; 12+ messages in thread
From: H. J. Lu @ 2003-05-09 20:35 UTC (permalink / raw)
To: GDB
[-- Attachment #1: Type: text/plain, Size: 398 bytes --]
On Fri, May 09, 2003 at 04:18:35PM -0400, Daniel Jacobowitz wrote:
> Maybe I'm missing something obvious. The link will be created to point
> at /export/gnu/src/gdb/gdb/gdb/doc/all-cfg.texi. Whether
> ../../../../../import/gdb/src/gdb/doc/all-cfg.texi exists from that
> directory does not matter. It will be resolved from the directory
> containing the second symlink.
>
It is a typo.
H.J.
[-- Attachment #2: gdb-link.patch --]
[-- Type: text/plain, Size: 637 bytes --]
2003-05-09 H.J. Lu <hongjiu.lu@intel.com>
* Makefile.in (gdb-cfg.texi): Fix a typo.
--- gdb/doc/Makefile.in.link 2003-04-02 16:40:17.000000000 -0800
+++ gdb/doc/Makefile.in 2003-05-09 13:33:23.000000000 -0700
@@ -245,7 +245,7 @@ GDBvn.texi : ${gdbdir}/version.in
# not one for their binary config---which may not be specifically
# defined anyways).
gdb-cfg.texi: ${srcdir}/${DOC_CONFIG}-cfg.texi
- (test "$$LN_S" = "ln -s" && \
+ (test "$(LN_S)" = "ln -s" && \
ln -s ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi) || \
ln ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi || \
cp ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: PATCH: Make sure gdb-cfg.texi is created
2003-05-09 20:35 ` H. J. Lu
@ 2003-05-09 20:42 ` Daniel Jacobowitz
0 siblings, 0 replies; 12+ messages in thread
From: Daniel Jacobowitz @ 2003-05-09 20:42 UTC (permalink / raw)
To: H. J. Lu; +Cc: GDB
On Fri, May 09, 2003 at 01:35:11PM -0700, H. J. Lu wrote:
> On Fri, May 09, 2003 at 04:18:35PM -0400, Daniel Jacobowitz wrote:
> > Maybe I'm missing something obvious. The link will be created to point
> > at /export/gnu/src/gdb/gdb/gdb/doc/all-cfg.texi. Whether
> > ../../../../../import/gdb/src/gdb/doc/all-cfg.texi exists from that
> > directory does not matter. It will be resolved from the directory
> > containing the second symlink.
> >
>
> It is a typo.
That makes more sense. Please check this in if you haven't already.
> 2003-05-09 H.J. Lu <hongjiu.lu@intel.com>
>
> * Makefile.in (gdb-cfg.texi): Fix a typo.
>
> --- gdb/doc/Makefile.in.link 2003-04-02 16:40:17.000000000 -0800
> +++ gdb/doc/Makefile.in 2003-05-09 13:33:23.000000000 -0700
> @@ -245,7 +245,7 @@ GDBvn.texi : ${gdbdir}/version.in
> # not one for their binary config---which may not be specifically
> # defined anyways).
> gdb-cfg.texi: ${srcdir}/${DOC_CONFIG}-cfg.texi
> - (test "$$LN_S" = "ln -s" && \
> + (test "$(LN_S)" = "ln -s" && \
> ln -s ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi) || \
> ln ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi || \
> cp ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: PATCH: Make sure gdb-cfg.texi is created
2003-05-09 19:24 PATCH: Make sure gdb-cfg.texi is created H. J. Lu
2003-05-09 19:34 ` Daniel Jacobowitz
@ 2003-05-10 9:49 ` Eli Zaretskii
2003-05-10 15:39 ` Andreas Schwab
1 sibling, 1 reply; 12+ messages in thread
From: Eli Zaretskii @ 2003-05-10 9:49 UTC (permalink / raw)
To: hjl; +Cc: gdb-patches
> Date: Fri, 9 May 2003 12:24:34 -0700
> From: "H. J. Lu" <hjl@lucon.org>
>
> + ln -s ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi && \
> + test -e gdb-cfg.texi) || \
Is the `-e' option a standard option of `test' in the shell, or is it
some kind of extension? I don't think we should use it unless it is
standard.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: PATCH: Make sure gdb-cfg.texi is created
2003-05-10 9:49 ` Eli Zaretskii
@ 2003-05-10 15:39 ` Andreas Schwab
2003-05-10 17:57 ` Eli Zaretskii
0 siblings, 1 reply; 12+ messages in thread
From: Andreas Schwab @ 2003-05-10 15:39 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: hjl, gdb-patches
"Eli Zaretskii" <eliz@elta.co.il> writes:
|> > Date: Fri, 9 May 2003 12:24:34 -0700
|> > From: "H. J. Lu" <hjl@lucon.org>
|> >
|> > + ln -s ${srcdir}/${DOC_CONFIG}-cfg.texi gdb-cfg.texi && \
|> > + test -e gdb-cfg.texi) || \
|>
|> Is the `-e' option a standard option of `test' in the shell, or is it
|> some kind of extension? I don't think we should use it unless it is
|> standard.
`test -e' is POSIX, but not supported by some older shells (according to
the autoconf docs Solaris 2.5 does not have it).
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: PATCH: Make sure gdb-cfg.texi is created
2003-05-10 15:39 ` Andreas Schwab
@ 2003-05-10 17:57 ` Eli Zaretskii
2003-05-10 19:00 ` Andreas Schwab
0 siblings, 1 reply; 12+ messages in thread
From: Eli Zaretskii @ 2003-05-10 17:57 UTC (permalink / raw)
To: schwab; +Cc: hjl, gdb-patches
> From: Andreas Schwab <schwab@suse.de>
> Date: Sat, 10 May 2003 17:39:04 +0200
>
> `test -e' is POSIX, but not supported by some older shells (according to
> the autoconf docs Solaris 2.5 does not have it).
What version of POSIX standardizes it? If Solaris 2.5 doesn't have
it, I'd be very uneasy about using it. Did we discontinue support for
Solaris 2.5?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: PATCH: Make sure gdb-cfg.texi is created
2003-05-10 17:57 ` Eli Zaretskii
@ 2003-05-10 19:00 ` Andreas Schwab
0 siblings, 0 replies; 12+ messages in thread
From: Andreas Schwab @ 2003-05-10 19:00 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: hjl, gdb-patches
"Eli Zaretskii" <eliz@elta.co.il> writes:
|> > From: Andreas Schwab <schwab@suse.de>
|> > Date: Sat, 10 May 2003 17:39:04 +0200
|> >
|> > `test -e' is POSIX, but not supported by some older shells (according to
|> > the autoconf docs Solaris 2.5 does not have it).
|>
|> What version of POSIX standardizes it?
At least since POSIX.2:1993, IIRC.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2003-05-10 19:00 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-09 19:24 PATCH: Make sure gdb-cfg.texi is created H. J. Lu
2003-05-09 19:34 ` Daniel Jacobowitz
2003-05-09 19:59 ` H. J. Lu
2003-05-09 20:06 ` Daniel Jacobowitz
2003-05-09 20:10 ` H. J. Lu
2003-05-09 20:18 ` Daniel Jacobowitz
2003-05-09 20:35 ` H. J. Lu
2003-05-09 20:42 ` Daniel Jacobowitz
2003-05-10 9:49 ` Eli Zaretskii
2003-05-10 15:39 ` Andreas Schwab
2003-05-10 17:57 ` Eli Zaretskii
2003-05-10 19:00 ` Andreas Schwab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox