[RFA/5.3] Fix a compilation warning in hppa-tdep.c

[RFA/5.3] Fix a compilation warning in hppa-tdep.c

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

I am not sure we want to pull this change in the 5.3 branch, as it does
not fix any regression. It's the change I checked in the trunk to fix a
compilation warning - the same warning appears in the 5.3 branch, so I
though I'd suggest it there too.

2002-10-30  Joel Brobecker  <brobecker@gnat.com>

        * hppa-tdep.c (low_text_segment_addres): Fix a compilation warning.

Should I apply it?

-- 
Joel

[-- Attachment #2: hppa-tdep.c.diff --]
[-- Type: text/plain, Size: 985 bytes --]

Index: hppa-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/hppa-tdep.c,v
retrieving revision 1.27
diff -c -3 -p -r1.27 hppa-tdep.c
*** hppa-tdep.c	5 May 2002 01:15:13 -0000	1.27
--- hppa-tdep.c	30 Oct 2002 23:10:55 -0000
*************** static CORE_ADDR low_text_segment_addres
*** 300,306 ****
  static void
  record_text_segment_lowaddr (bfd *abfd, asection *section, void *ignored)
  {
!   if ((section->flags & (SEC_ALLOC | SEC_LOAD | SEC_READONLY)
         == (SEC_ALLOC | SEC_LOAD | SEC_READONLY))
        && section->vma < low_text_segment_address)
      low_text_segment_address = section->vma;
--- 300,306 ----
  static void
  record_text_segment_lowaddr (bfd *abfd, asection *section, void *ignored)
  {
!   if (((section->flags & (SEC_ALLOC | SEC_LOAD | SEC_READONLY))
         == (SEC_ALLOC | SEC_LOAD | SEC_READONLY))
        && section->vma < low_text_segment_address)
      low_text_segment_address = section->vma;

Re: [RFA/5.3] Fix a compilation warning in hppa-tdep.c

[Andrew Cagney]

> I am not sure we want to pull this change in the 5.3 branch, as it does
> not fix any regression. It's the change I checked in the trunk to fix a
> compilation warning - the same warning appears in the 5.3 branch, so I
> though I'd suggest it there too.
> 
> 2002-10-30  Joel Brobecker  <brobecker@gnat.com>
> 
>         * hppa-tdep.c (low_text_segment_addres): Fix a compilation warning.
> 
> Should I apply it?

I say `Yes', and the same for any other HP changes you feel should be 
pulled in from the mainline.

Just keep an eye out for my long over due e-mail indicating `stop, no 
more 5.3 changes' :-/

> Index: hppa-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/hppa-tdep.c,v
> retrieving revision 1.27
> diff -c -3 -p -r1.27 hppa-tdep.c
> *** hppa-tdep.c	5 May 2002 01:15:13 -0000	1.27
> --- hppa-tdep.c	30 Oct 2002 23:10:55 -0000
> *************** static CORE_ADDR low_text_segment_addres
> *** 300,306 ****
>   static void
>   record_text_segment_lowaddr (bfd *abfd, asection *section, void *ignored)
>   {
> !   if ((section->flags & (SEC_ALLOC | SEC_LOAD | SEC_READONLY)
>          == (SEC_ALLOC | SEC_LOAD | SEC_READONLY))
>         && section->vma < low_text_segment_address)
>       low_text_segment_address = section->vma;
> --- 300,306 ----
>   static void
>   record_text_segment_lowaddr (bfd *abfd, asection *section, void *ignored)
>   {
> !   if (((section->flags & (SEC_ALLOC | SEC_LOAD | SEC_READONLY))
>          == (SEC_ALLOC | SEC_LOAD | SEC_READONLY))
>         && section->vma < low_text_segment_address)
>       low_text_segment_address = section->vma;

Re: [RFA/5.3] Fix a compilation warning in hppa-tdep.c

[Joel Brobecker]

> >2002-10-30  Joel Brobecker  <brobecker@gnat.com>
> >
> >        * hppa-tdep.c (low_text_segment_addres): Fix a compilation warning.
> >
> >Should I apply it?
> 
> I say `Yes', and the same for any other HP changes you feel should be 
> pulled in from the mainline.

Ok, thanks for the rule of thumb.

This change is now checked in.

> Just keep an eye out for my long over due e-mail indicating `stop, no 
> more 5.3 changes' :-/

Wildo.

BTW: I am in the middle of recompiling and testing the 5.3 sources on
most targets supported by ACT. Will report the results (HP is fine).

-- 
Joel